[ckan-changes] [okfn/ckanjs] 2f65ab: [refactor, templates][xs]: split some of dataset re...

Fri Jul 29 07:59:44 UTC 2011

  Branch: refs/heads/master
  Home:   https://github.com/okfn/ckanjs

  Commit: 2f65ab6abe045fa8d17da5013fe519c8973e2303
      https://github.com/okfn/ckanjs/commit/2f65ab6abe045fa8d17da5013fe519c8973e2303
  Author: rgrp <http://rufuspollock.org>
  Date:   2011-07-28 (Thu, 28 Jul 2011)

  Changed paths:
    M app/index.html
  A lib/template/dataset-form.js
  A lib/template/dataset-view.js
  M lib/templates.js
  M test/index.html

  Log Message:
  -----------
  [refactor,templates][xs]: split some of dataset related templates into their own template files.

  Commit: dea0e08bfec9d4a7c091bf8e8959b3042a76d404
      https://github.com/okfn/ckanjs/commit/dea0e08bfec9d4a7c091bf8e8959b3042a76d404
  Author: rgrp <http://rufuspollock.org>
  Date:   2011-07-28 (Thu, 28 Jul 2011)

  Changed paths:
    M lib/template/dataset-view.js
  M lib/view.js

  Log Message:
  -----------
  [refactor,template][xs]: rename datasetFull template to datasetView.

  Commit: 777a280dde30d79f46acce4bc8da3ec4fc940e07
      https://github.com/okfn/ckanjs/commit/777a280dde30d79f46acce4bc8da3ec4fc940e07
  Author: rgrp <http://rufuspollock.org>
  Date:   2011-07-28 (Thu, 28 Jul 2011)

  Changed paths:
    M app/css/ckanjs.css
  M lib/template/dataset-view.js
  M test/fixtures.js

  Log Message:
  -----------
  [dataset/view,template][s]: several minor improvements to dataset view (e.g. say if no resources, and display resource heading etc).

* correct annakarenina notes json to have line endings.

  Commit: 149465fd08675233ce6b0704db6e1f7983cd144d
      https://github.com/okfn/ckanjs/commit/149465fd08675233ce6b0704db6e1f7983cd144d
  Author: rgrp <http://rufuspollock.org>
  Date:   2011-07-28 (Thu, 28 Jul 2011)

  Changed paths:
    M lib/model.js

  Log Message:
  -----------
  [model,bugfix][s]: fix nasty subtle bug (1h+ to track down) whereby dataset change event not being triggered on resource update.

* Details: discovered this because using fixtures dataset view was not showing resources. Tracked this to fact that on dataset.set with fixture data (of existing dataset -- one autocreated for view) change event was getting fired *before* _updateChildren called (or completed) and hence resources not being shown (as render happened before resources on object).

  Commit: 52fd58bddba1e5bd1ffe91f0eafbaa1cf8591787
      https://github.com/okfn/ckanjs/commit/52fd58bddba1e5bd1ffe91f0eafbaa1cf8591787
  Author: rgrp <http://rufuspollock.org>
  Date:   2011-07-28 (Thu, 28 Jul 2011)

  Changed paths:
    M app/index.html
  A lib/template/resource-form.js
  M lib/templates.js
  M test/index.html

  Log Message:
  -----------
  [template,refactor][xs]: split out resourceForm into separate file.

  Commit: 6098af729824c1494426fa5c416194cbe462cdbe
      https://github.com/okfn/ckanjs/commit/6098af729824c1494426fa5c416194cbe462cdbe
  Author: rgrp <http://rufuspollock.org>
  Date:   2011-07-28 (Thu, 28 Jul 2011)

  Changed paths:
    M lib/model.js
  M test/model-test.js

  Log Message:
  -----------
  [model/resource][xs]: allow resource not to have dataset set (was being required in toJSON).

  Commit: 09634289839d9be4db14f03868efc8db1e901d6b
      https://github.com/okfn/ckanjs/commit/09634289839d9be4db14f03868efc8db1e901d6b
  Author: rgrp <http://rufuspollock.org>
  Date:   2011-07-28 (Thu, 28 Jul 2011)

  Changed paths:
    M app/index.html
  A lib/template/resource-view.js
  M lib/view.js
  M test/index.html
  M test/view-test.js

  Log Message:
  -----------
  [view/resource][s]: first pass at resource view with simple template (very incomplete but working).

Compare: https://github.com/okfn/ckanjs/compare/82ee4d2...0963428