[ckan-changes] commit/ckan: John Glover: [search][xs] bug fix: don't use 'edismax' query parser with solr, does not work with solr 1.4

Wed Sep 21 14:50:45 UTC 2011

1 new changeset in ckan:

http://bitbucket.org/okfn/ckan/changeset/7b7d3df51fcf/
changeset:   7b7d3df51fcf
user:        John Glover
date:        2011-09-21 16:50:25
summary:     [search][xs] bug fix: don't use 'edismax' query parser with solr, does not work with solr 1.4
affected #:  2 files (-1 bytes)

--- a/ckan/lib/search/query.py	Wed Sep 21 12:32:09 2011 +0100
+++ b/ckan/lib/search/query.py	Wed Sep 21 15:50:25 2011 +0100
@@ -220,10 +220,13 @@
             licenses = " OR ".join(licenses)
             query['fq'] += " +(%s) " % licenses
 
-        # query field weighting
-        query['defType'] = 'edismax'
-        query['tie'] = '0.5'
-        query['qf'] = query.get('qf', QUERY_FIELDS)
+        # query field weighting: disabled for now as solr 3.* is required for 
+        # the 'edismax' query parser, our current Ubuntu version only has
+        # packages for 1.4
+        #
+        # query['defType'] = 'edismax'
+        # query['tie'] = '0.5'
+        # query['qf'] = query.get('qf', QUERY_FIELDS)
 
         conn = make_connection()
         try:


--- a/ckan/tests/lib/test_solr_package_search.py	Wed Sep 21 12:32:09 2011 +0100
+++ b/ckan/tests/lib/test_solr_package_search.py	Wed Sep 21 15:50:25 2011 +0100
@@ -153,6 +153,13 @@
         assert pkgs == all_pkgs[4:6]
 
     def test_order_by(self):
+        # TODO: fix this test
+        #
+        # as we are not using the 'edismax' query parser now (requires solr >= 3.*), the
+        # search weighting has been changed
+        from nose import SkipTest
+        raise SkipTest()
+
         # large search
         all_results = search.query_for(model.Package).run({'q': self.q_all})
         all_pkgs = all_results['results']

Repository URL: https://bitbucket.org/okfn/ckan/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.


