[ckan-changes] [okfn/ckan] c1ee1e: [#2750] Fix group controller using wrong schema

Fri Aug 10 13:52:19 UTC 2012

  Branch: refs/heads/release-v1.8
  Home:   https://github.com/okfn/ckan
  Commit: c1ee1e995ef7481cd40b9fb3221db1b681293f92
      https://github.com/okfn/ckan/commit/c1ee1e995ef7481cd40b9fb3221db1b681293f92
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2012-08-10 (Fri, 10 Aug 2012)

  Changed paths:
    M ckan/controllers/group.py

  Log Message:
  -----------
  [#2750] Fix group controller using wrong schema

Fix group controller calling form_to_db_schema() from IGroupForm plugin
when it should be using db_to_form_schema()

  Commit: 5d80f7fc5d41225c79625a8dcadd64148d8adc76
      https://github.com/okfn/ckan/commit/5d80f7fc5d41225c79625a8dcadd64148d8adc76
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2012-08-10 (Fri, 10 Aug 2012)

  Changed paths:
    M ckan/lib/plugins.py

  Log Message:
  -----------
  Refactor DefaultGroupForm's form_to_db_schema_options()

The form_to_db_schema() methods of IGroupForm plugins were not being
called if those plugins inherited from DefaultGroupForm. Refactor it in
the same way as DefaultDatasetForm's form_to_db_schema_options() method
was recently refactored.  Make it call self.form_to_db_schema so that
the form_to_db_schema() methods of IGroupForm extensions get called.
Also make it call new form_to_db_schema_api_create() and
form_to_db_schema_api_update() methods which could potentially be
overridden by extensions also.

  Commit: 8938352c1add570f5dabe67167907edb1167392e
      https://github.com/okfn/ckan/commit/8938352c1add570f5dabe67167907edb1167392e
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2012-08-10 (Fri, 10 Aug 2012)

  Changed paths:
    M ckan/logic/action/create.py
    M ckan/logic/action/update.py

  Log Message:
  -----------
  [#2570] Fix IGroupForm check_data_dict not being called

Make group_create() and group_update() call the check_data_dict()
methods of IGroupForm plugins, like package_create() and
package_update() do with IDatasetForm plugins.

  Commit: 5d30fdbc718e2d423b53fdaee1fdf9d22aaa8524
      https://github.com/okfn/ckan/commit/5d30fdbc718e2d423b53fdaee1fdf9d22aaa8524
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2012-08-10 (Fri, 10 Aug 2012)

  Changed paths:
    M ckan/logic/schema.py

  Log Message:
  -----------
  Fix a db_to_form_package_schema() crash

When db_to_form_package_schema() was in use (e.g. when an IDatasetForm
plugin with a db_to_form_schema() method based on
db_to_form_package_schema() was active) then try to edit a package that
has some resources would crash with a 400 Bad Request.

Extremely difficult to debug.

This seems to fix it.

Compare: https://github.com/okfn/ckan/compare/a26d88cf4ef5...5d30fdbc718e