[ckan-changes] [okfn/ckan] 90c76b: [#1719, helpers][xs]: fixes #1719 - broken link for...

Mon Feb 6 09:06:43 UTC 2012

  Branch: refs/heads/master
  Home:   https://github.com/okfn/ckan
  Commit: 90c76b0b006cf505698834e833b548634cf10d17
      https://github.com/okfn/ckan/commit/90c76b0b006cf505698834e833b548634cf10d17
  Author: Rufus Pollock <rufus.pollock at okfn.org>
  Date:   2012-02-06 (Mon, 06 Feb 2012)

  Changed paths:
    M ckan/lib/helpers.py
  M ckan/public/css/style.css
  M ckan/tests/lib/test_helpers.py

  Log Message:
  -----------
  [#1719,helpers][xs]: fixes #1719 - broken link for users without a real gravatar.

* Problem: we were providing a default user icon to gravatar (see http://en.gravatar.com/site/implement/images/). However, we were not providing an *absolute* url just the relevative url on the CKAN instance (also weren't url-encoding the link ...). This led to the following 404 url: http://en.gravatar.com/images/icons/user.png
* Fix: use identicon default image from gravatar (no longer provide our own default image).
  * Could have corrected this but felt simpler option from multiple persepectives (code, resource usage, ux) was to do this.