[ckan-changes] [okfn/ckan] c102a4: [#1788] Remove some trailing commas breaking scrip...

Fri Feb 24 19:12:23 UTC 2012

  Branch: refs/heads/master
  Home:   https://github.com/okfn/ckan
  Commit: c102a468ee90702cbb4a69215a3bbc10d5d3e3a7
      https://github.com/okfn/ckan/commit/c102a468ee90702cbb4a69215a3bbc10d5d3e3a7
  Author: Fulvio Sciarretta <zydio at users.sf.net>
  Date:   2012-02-24 (Fri, 24 Feb 2012)

  Changed paths:
    M ckan/public/scripts/application.js
  M ckan/public/scripts/vendor/ckanjs/1.0.0/ckanjs.js

  Log Message:
  -----------
  [#1788] Remove some trailing commas breaking script execution in IE7, which in turn made the dataset Edit page impossible to work with.

  Commit: 7af8c364b69bc3151fadcdab1bb7ced42982a9b9
      https://github.com/okfn/ckan/commit/7af8c364b69bc3151fadcdab1bb7ced42982a9b9
  Author: Fulvio Sciarretta <zydio at users.sf.net>
  Date:   2012-02-24 (Fri, 24 Feb 2012)

  Changed paths:
    M ckan/public/css/style.css

  Log Message:
  -----------
  [#1788] minornavigation menu incorrectly showed vertically instead of horizontally because of missing support for inline-block in IE <= 7, fixed with a css workaround.

  Commit: 2f4d754b1a2a42f54b6795bc92782147d692923f
      https://github.com/okfn/ckan/commit/2f4d754b1a2a42f54b6795bc92782147d692923f
  Author: Fulvio Sciarretta <zydio at users.sf.net>
  Date:   2012-02-24 (Fri, 24 Feb 2012)

  Changed paths:
    A ckan/public/scripts/vendor/html5shiv/html5.js
  M ckan/templates/layout_base.html

  Log Message:
  -----------
  [#1788] added html5shiv, and conditionally included in layout_base.html for IE < 9, to properly show HTML5 section elements which corrupted the layout on those browsers.

It must be included in <head> tag because it is said to be required to come before the <body> tag: http://code.google.com/p/html5shiv/

  Commit: 703064c64786531ed7acb7490b57a7ed53a51a9b
      https://github.com/okfn/ckan/commit/703064c64786531ed7acb7490b57a7ed53a51a9b
  Author: Fulvio Sciarretta <zydio at users.sf.net>
  Date:   2012-02-24 (Fri, 24 Feb 2012)

  Changed paths:
    M ckan/public/css/style.css
  M ckan/templates/layout_base.html

  Log Message:
  -----------
  [#1788] change of some style and layout to have a properly sized footer element in all browsers, and fix the footer appearance in IE <= 8.

This not only fixes IE7 behavior (the first half of the footer gray, the second half white), but also shows footer containers stretching properly to content in Firefox with Firebug element highlighting feature.
Side effect: there may be less white space below the three boxes in a empty homepage.

  Commit: 27f4fc776b9199621d259749cf20787328df101f
      https://github.com/okfn/ckan/commit/27f4fc776b9199621d259749cf20787328df101f
  Author: Rufus Pollock <rufus.pollock at okfn.org>
  Date:   2012-02-24 (Fri, 24 Feb 2012)

  Changed paths:
    M ckan/public/css/style.css
  M ckan/public/scripts/application.js
  M ckan/public/scripts/vendor/ckanjs/1.0.0/ckanjs.js
  A ckan/public/scripts/vendor/html5shiv/html5.js
  M ckan/templates/layout_base.html

  Log Message:
  -----------
  Merge pull request #2 from zydio/defect-1788-ie7-compatibility-problems

[#1788,master][s]: solves the vast majority of layout and misc issues encountered in IE < 9 (and hence IE7 as well).

The first two commits, the "light" ones:

- some Javascript errors which prevented the dataset page to work correctly
- minornavigation links layout.

The third commit also tries to deal with the major layout issue: the missing support for HTML5 elements which breaks the header and footer layout (as shown in the screenshot in the ticket #1788 ). It does so by conditionally including html5shiv for IE < 9, which currently seems to be the best way (besides removing all HTML5 elements from ckan).

The fourth commit sorts the last annoying visual problem: the footer in IE <= 8 shows half grey and half white, with lists overflowing in the white half. Reworked a bit the html layout and some css properties, and the layout now seems to work better (even analyzing the page with Firebug).

Compare: https://github.com/okfn/ckan/compare/9f8aef8...27f4fc7