[ckan-changes] [okfn/ckan] : [#1631] Add simple updated group activities

Fri Jan 13 14:41:48 UTC 2012

  Branch: refs/heads/feature-1515-activity-streams
  Home:   https://github.com/okfn/ckan
  Commit: 9d4b9c798c07f6cc6f03b609fd702f81cfdad3b4
      https://github.com/okfn/ckan/commit/9d4b9c798c07f6cc6f03b609fd702f81cfdad3b4
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2012-01-13 (Fri, 13 Jan 2012)

  Changed paths:
    M ckan/logic/action/get.py
  M ckan/logic/action/update.py
  A ckan/templates/activity_streams/changed_group.html
  M ckan/tests/models/test_activity.py

  Log Message:
  -----------
  [#1631] Add simple updated group activities

Just:

    USER updated the group GROUP
    DESCRIPTION
    DATE

These could be improved, e.g.  specific messages for renamed group,
changed description of group, added dataset to group, etc.

  Commit: 914220ae02799fceeb5274c2d8f048514c3730aa
      https://github.com/okfn/ckan/commit/914220ae02799fceeb5274c2d8f048514c3730aa
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2012-01-13 (Fri, 13 Jan 2012)

  Changed paths:
    M ckan/lib/activity.py
  M ckan/logic/action/create.py
  M ckan/tests/models/test_activity.py

  Log Message:
  -----------
  Don't make new revision in activity_create() logic function.

Since activities aren't revisioned, it's not necessary to make a new
revision.

Somehow this changed introduced an error where updating a group would
also emit 'changed package' activities for each of the group's
activities, so tweak ckan/lib/activity.py to fix this.

Somehow _that_ fix revealed a mistake in test_delete_resources, it would
delete all the resources for a package that had no resources in the
first place (i.e. it would change nothing) and then would expect to see
a new activity stream item, when in fact (correctly) no new activity
stream item was emitted. Somehow this bad test was passing before this
commit. Fix the test.

  Commit: 4764350c435e4897e69970c415dd46a2ad74cebc
      https://github.com/okfn/ckan/commit/4764350c435e4897e69970c415dd46a2ad74cebc
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2012-01-13 (Fri, 13 Jan 2012)

  Changed paths:
    M ckan/tests/functional/test_user.py

  Log Message:
  -----------
  Revert "[#1625] Remove a functional test from test_user.py"

This reverts commit 21dcf04543f1bd2d42804fdc70f35f03abea7646, which was
a mistake, activity streams should not have been creating new revisions
in the first place.

Compare: https://github.com/okfn/ckan/compare/2e0b88f...4764350