[ckan-changes] [okfn/ckan] 2a08c3: Refactor DefaultGroupForm's form_to_db_schema_opti...

Mon Jul 30 09:44:23 UTC 2012

  Branch: refs/heads/2750-add-docs-and-examples-for-idatasetform-and-igroupform
  Home:   https://github.com/okfn/ckan
  Commit: 2a08c3ef5df27aa0f7b77d077cb0780f55d1e013
      https://github.com/okfn/ckan/commit/2a08c3ef5df27aa0f7b77d077cb0780f55d1e013
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2012-07-28 (Sat, 28 Jul 2012)

  Changed paths:
    M ckan/lib/plugins.py

  Log Message:
  -----------
  Refactor DefaultGroupForm's form_to_db_schema_options()

The form_to_db_schema() methods of IGroupForm plugins were not being
called if those plugins inherited from DefaultGroupForm. Refactor it in
the same way as DefaultDatasetForm's form_to_db_schema_options() method
was recently refactored.  Make it call self.form_to_db_schema so that
the form_to_db_schema() methods of IGroupForm extensions get called.
Also make it call new form_to_db_schema_api_create() and
form_to_db_schema_api_update() methods which could potentially be
overridden by extensions also.

  Commit: 75618153bb3bf483bd4584e12e79632a1a07a770
      https://github.com/okfn/ckan/commit/75618153bb3bf483bd4584e12e79632a1a07a770
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2012-07-28 (Sat, 28 Jul 2012)

  Changed paths:
    M ckan/controllers/group.py

  Log Message:
  -----------
  [#2750] Fix group controller using wrong schema

Fix group controller calling form_to_db_schema() from IGroupForm plugin
when it should be using db_to_form_schema()

  Commit: eac57b2335e037f5cde67e2344092c0e8f0199c2
      https://github.com/okfn/ckan/commit/eac57b2335e037f5cde67e2344092c0e8f0199c2
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2012-07-28 (Sat, 28 Jul 2012)

  Changed paths:
    M ckan/logic/action/create.py
    M ckan/logic/action/update.py

  Log Message:
  -----------
  [#2570] Fix IGroupForm check_data_dict not being called

Make group_create() and group_update() call the check_data_dict()
methods of IGroupForm plugins, like package_create() and
package_update() do with IDatasetForm plugins.

  Commit: 243478be39d548414447bcb82beb3bf6ec56d0e8
      https://github.com/okfn/ckan/commit/243478be39d548414447bcb82beb3bf6ec56d0e8
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2012-07-28 (Sat, 28 Jul 2012)

  Changed paths:
    A ckanext/example_igroupform/__init__.py
    A ckanext/example_igroupform/plugin.py
    A ckanext/example_igroupform/templates/group/new_group_form.html
    A ckanext/example_igroupform/templates/group/read.html
    M setup.py

  Log Message:
  -----------
  [#2570] Add ckanext/example_igroupform

  Commit: 4dbe1191376e8ec6295caac8f992cb4099224551
      https://github.com/okfn/ckan/commit/4dbe1191376e8ec6295caac8f992cb4099224551
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2012-07-28 (Sat, 28 Jul 2012)

  Changed paths:
    A ckanext/example_idatasetform/__init__.py
    A ckanext/example_idatasetform/plugin.py
    A ckanext/example_idatasetform/templates/package/new_package_form.html
    A ckanext/example_idatasetform/templates/package/read_core.html
    M setup.py

  Log Message:
  -----------
  [#2570] Add ckanext/example_idatasetform

Compare: https://github.com/okfn/ckan/compare/2a08c3ef5df2^...4dbe1191376e