[ckan-changes] [okfn/ckan] 817cba: [2330] First stab at making the get.py logic actio...

Tue May 15 08:41:26 UTC 2012

  Branch: refs/heads/master
  Home:   https://github.com/okfn/ckan
  Commit: 817cba888ba5b5d90d583004cd7350365f5b49b4
      https://github.com/okfn/ckan/commit/817cba888ba5b5d90d583004cd7350365f5b49b4
  Author: Ian Murray <ian.murray at okfn.org>
  Date:   2012-05-03 (Thu, 03 May 2012)

  Changed paths:
    M ckan/controllers/api.py
    M ckan/lib/base.py
    M ckan/logic/__init__.py
    M ckan/tests/functional/api/test_api.py

  Log Message:
  -----------
  [2330] First stab at making the get.py logic actions GETable

  Commit: d94f0108a3387ff439d525f0553a5152e6c038d1
      https://github.com/okfn/ckan/commit/d94f0108a3387ff439d525f0553a5152e6c038d1
  Author: Ian Murray <ian.murray at okfn.org>
  Date:   2012-05-03 (Thu, 03 May 2012)

  Changed paths:
    M ckan/logic/__init__.py
    M ckan/plugins/interfaces.py

  Log Message:
  -----------
  [2330] Created a decorator for marking actions as side-effect-free.

For use by users defining their own actions through the IActions interface.

  Commit: fd49c456c75e7cabb9e9fc7a7591a07379996914
      https://github.com/okfn/ckan/commit/fd49c456c75e7cabb9e9fc7a7591a07379996914
  Author: Ian Murray <ian.murray at okfn.org>
  Date:   2012-05-03 (Thu, 03 May 2012)

  Changed paths:
    M ckan/logic/__init__.py

  Log Message:
  -----------
  [2330] Only load functions from the action module.

We were loading every public object in the module as an action.  Whilst not perfect, this at least
ensures that only functions are loaded, and not things like get.log

  Commit: 55d8ea418b94a9cedab3f95e4c50b929f2f527d1
      https://github.com/okfn/ckan/commit/55d8ea418b94a9cedab3f95e4c50b929f2f527d1
  Author: Ian Murray <ian.murray at okfn.org>
  Date:   2012-05-04 (Fri, 04 May 2012)

  Changed paths:
    M ckan/tests/functional/api/test_api.py

  Log Message:
  -----------
  [2330] Some comments

  Commit: 3bd5b89b9a44372fe37e10edb67a6e7910ab141a
      https://github.com/okfn/ckan/commit/3bd5b89b9a44372fe37e10edb67a6e7910ab141a
  Author: Ian Murray <ian.murray at okfn.org>
  Date:   2012-05-04 (Fri, 04 May 2012)

  Changed paths:
    M ckan/logic/action/get.py

  Log Message:
  -----------
  [2330] Ensured that only action functions (in get.py) are turned into actions by the actin API

 - renamed functions not being exported by the module to have an underscore
   prefix, ensuring that they are then not exposed as actions in the action
   API.
 - fixed sqlalchemy imports

  Commit: c4a0d488302bb6d5083c479ffd0b18f85c20ae07
      https://github.com/okfn/ckan/commit/c4a0d488302bb6d5083c479ffd0b18f85c20ae07
  Author: Ian Murray <ian.murray at okfn.org>
  Date:   2012-05-04 (Fri, 04 May 2012)

  Changed paths:
    M doc/apiv3.rst

  Log Message:
  -----------
  [2330] Docs

  Commit: 52e1c1eb46b7da5a5ec761f560e6e9f5bd74a0eb
      https://github.com/okfn/ckan/commit/52e1c1eb46b7da5a5ec761f560e6e9f5bd74a0eb
  Author: Ian Murray <ian.murray at okfn.org>
  Date:   2012-05-04 (Fri, 04 May 2012)

  Changed paths:
    M ckan/logic/action/create.py
    M ckan/logic/action/delete.py
    M ckan/logic/action/get.py
    M ckan/logic/action/update.py

  Log Message:
  -----------
  [2330] Use get_or_bust in the actions layer.

This function raises a ValidationError if the key doesn't exist in the given
(data_)dict.  This means better error messages for the user.

  Commit: f2ddf0dfb5c31018d2e4e03fd7522d54bc9de930
      https://github.com/okfn/ckan/commit/f2ddf0dfb5c31018d2e4e03fd7522d54bc9de930
  Author: Ian Murray <ian.murray at okfn.org>
  Date:   2012-05-04 (Fri, 04 May 2012)

  Changed paths:
    M ckan/logic/__init__.py

  Log Message:
  -----------
  [2330] Small fix to get_or_bust() function.

It should only raise a ValidationError if the key cannot be found.  And not
if the value is false-y.

  Commit: aa1a09b9878060fbe21ee78038bb9c3f8def8a3f
      https://github.com/okfn/ckan/commit/aa1a09b9878060fbe21ee78038bb9c3f8def8a3f
  Author: Ian Murray <ian.murray at okfn.org>
  Date:   2012-05-04 (Fri, 04 May 2012)

  Changed paths:
    M ckan/logic/action/create.py
    M ckan/logic/action/delete.py
    M ckan/logic/action/update.py

  Log Message:
  -----------
  [2330] Ensure that only action functions in the action modules are exposed through the action API

  Commit: 79c8b5f57ecf1bc48f34a47914bab4d1f5cb8f99
      https://github.com/okfn/ckan/commit/79c8b5f57ecf1bc48f34a47914bab4d1f5cb8f99
  Author: Ian Murray <ian.murray at okfn.org>
  Date:   2012-05-07 (Mon, 07 May 2012)

  Changed paths:
    M ckan/lib/base.py

  Log Message:
  -----------
  [2330] Allow the passing of the data_dict through the GET request's body

  Commit: 33ba385bb5182ed989b6fddfd669c6ac33ce6913
      https://github.com/okfn/ckan/commit/33ba385bb5182ed989b6fddfd669c6ac33ce6913
  Author: Ian Murray <ian.murray at okfn.org>
  Date:   2012-05-14 (Mon, 14 May 2012)

  Changed paths:
    M ckan/lib/base.py
    M ckan/tests/functional/api/test_api.py
    M doc/apiv3.rst

  Log Message:
  -----------
  [2330] Simplified passing of GETable action's paramters.

 - Removed ability to pass in arguments in the GET request's body.
 - Removed ability to pass in a nested, json-encoded data_dict in the
   'data_dict' url parameter.

Decided that these two methods just made for an unecessary complexity and
unclarity for users of the api.

  Commit: 4e522324d3617693f3a2d25685008ab5be4e6745
      https://github.com/okfn/ckan/commit/4e522324d3617693f3a2d25685008ab5be4e6745
  Author: Ian Murray <ian.murray at okfn.org>
  Date:   2012-05-14 (Mon, 14 May 2012)

  Changed paths:
    M ckan/logic/action/get.py

  Log Message:
  -----------
  [2330] Extended allowable argument types of "term_translation_show" action.

Extended the `terms` and (optional) `lang_codes` arguments to accept a
string in lieu of a unit-length list of strings.  This ensures compatibility
with access to this action via a GET request where the arguments are
constructed from URL parameters.

  Commit: 62030d76940de644ad5ac953d58e78b9689ac592
      https://github.com/okfn/ckan/commit/62030d76940de644ad5ac953d58e78b9689ac592
  Author: Ian Murray <ian.murray at okfn.org>
  Date:   2012-05-15 (Tue, 15 May 2012)

  Changed paths:
    M ckan/controllers/api.py
    M ckan/lib/base.py
    M ckan/logic/__init__.py
    M ckan/logic/action/create.py
    M ckan/logic/action/delete.py
    M ckan/logic/action/get.py
    M ckan/logic/action/update.py
    M ckan/plugins/interfaces.py
    M ckan/tests/functional/api/test_api.py
    M doc/apiv3.rst

  Log Message:
  -----------
  Merge branch 'feature-2330-make-api-read-actions-GETable' into master.

Conflicts:
	ckan/logic/action/create.py
	ckan/logic/action/delete.py
	ckan/logic/action/get.py

Compare: https://github.com/okfn/ckan/compare/54e67cf...62030d7