[ckan-changes] [okfn/ckan] c58215: Fixes in order to prevent the flickering from happ...

Thu Oct 4 11:53:44 UTC 2012

  Branch: refs/heads/master
  Home:   https://github.com/okfn/ckan
  Commit: c58215e5a2ed475ae5ab82f49358ff274827e08d
      https://github.com/okfn/ckan/commit/c58215e5a2ed475ae5ab82f49358ff274827e08d
  Author: John Martin <me at johnmart.in>
  Date:   2012-10-03 (Wed, 03 Oct 2012)

  Changed paths:
    M ckan/public/base/javascript/modules/data-viewer.js

  Log Message:
  -----------
  Fixes in order to prevent the flickering from happening with the data-viewer

  Commit: dc46a41f163faa9f70f47c0217e4f731c75c097d
      https://github.com/okfn/ckan/commit/dc46a41f163faa9f70f47c0217e4f731c75c097d
  Author: John Martin <me at johnmart.in>
  Date:   2012-10-03 (Wed, 03 Oct 2012)

  Changed paths:
    M ckan/public/base/javascript/modules/data-viewer.js

  Log Message:
  -----------
  Remove fix for `overflow:hidden` on iframe body

It wasn't need as it was a problem that I spotted that only occured when we used `jQuery.animate` and since we moved to `jQuery.css` it doesn't happen any more.

  Commit: 3a3fc1f1344ef60f68444a84f4cb396c559d0768
      https://github.com/okfn/ckan/commit/3a3fc1f1344ef60f68444a84f4cb396c559d0768
  Author: John Martin <me at johnmart.in>
  Date:   2012-10-03 (Wed, 03 Oct 2012)

  Changed paths:
    M ckan/public/base/javascript/modules/data-viewer.js

  Log Message:
  -----------
  Added deltaHeight back in... as it was the simplest solution to the problem

- Tried https://github.com/house9/jquery-iframe-auto-height but it only works onload and there is no api to allow for refiring a resize event
- Tried using `document.scrollHeight` but it was too flaky in returning correct values and could cause the iframe to resize by 1px every timer tick

  Commit: 7841c45f8694b32f5f1064ca0de7a9a403e9e0d6
      https://github.com/okfn/ckan/commit/7841c45f8694b32f5f1064ca0de7a9a403e9e0d6
  Author: John Martin <me at johnmart.in>
  Date:   2012-10-03 (Wed, 03 Oct 2012)

  Changed paths:
    M ckan/public/base/javascript/modules/data-viewer.js

  Log Message:
  -----------
  Removed deltaHeight as it was uneeded, it was only really the padding that was really needed

  Commit: b5332a15a42189f68c7667bb2fe67bd90cf53f49
      https://github.com/okfn/ckan/commit/b5332a15a42189f68c7667bb2fe67bd90cf53f49
  Author: amercader <amercadero at gmail.com>
  Date:   2012-10-04 (Thu, 04 Oct 2012)

  Changed paths:
    M ckan/public/base/javascript/modules/data-viewer.js

  Log Message:
  -----------
  Merge branch '2954-data-viewer-flickering'

Compare: https://github.com/okfn/ckan/compare/21612acd3893...b5332a15a421