[ckan-changes] [okfn/ckan] c76c35: [#621] Move extras_validation into __before

Tue Apr 16 08:49:11 UTC 2013

  Branch: refs/heads/master
  Home:   https://github.com/okfn/ckan
  Commit: c76c351555f7daa44aa2be1f671363a76857d2b7
      https://github.com/okfn/ckan/commit/c76c351555f7daa44aa2be1f671363a76857d2b7
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-04-01 (Mon, 01 Apr 2013)

  Changed paths:
    M ckan/logic/schema.py
    M ckan/logic/validators.py

  Log Message:
  -----------
  [#621] Move extras_validation into __before

This fixes an issue where creating a new resource would crash in
validation if there was a custom field (using convert_to/from_extras)
with a name that sorted after extras validation alphabetically. Fixes #621.

  Commit: 938a346af96fbe1f91c0f19c7acd16fd89b87ab2
      https://github.com/okfn/ckan/commit/938a346af96fbe1f91c0f19c7acd16fd89b87ab2
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-04-10 (Wed, 10 Apr 2013)

  Changed paths:
    M ckan/logic/validators.py

  Log Message:
  -----------
  [#621] Fix crash on duplicate extras key error

Fix a crash when generating a 'duplicate extras key' error. To trigger
the crash, post a dataset dict to package_create() containing two extras
dicts with the same key. There is no test for this yet.

  Commit: f0aeecefe2a742b5923a04cced5e16d1524d70fc
      https://github.com/okfn/ckan/commit/f0aeecefe2a742b5923a04cced5e16d1524d70fc
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-04-10 (Wed, 10 Apr 2013)

  Changed paths:
    M ckan/tests/logic/test_action.py

  Log Message:
  -----------
  [#621] Add tests for duplicate extras key error

This code path was not covered by the tests.

  Commit: ed0b8527d106583714a223ff841ecd618b08c8e4
      https://github.com/okfn/ckan/commit/ed0b8527d106583714a223ff841ecd618b08c8e4
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-04-10 (Wed, 10 Apr 2013)

  Changed paths:
    M bin/osx-postgres-mem.sh
    M bin/travis-build
    M ckan/config/deployment.ini_tmpl
    M ckan/controllers/api.py
    M ckan/controllers/group.py
    M ckan/lib/search/query.py
    M ckan/logic/action/create.py
    M ckan/logic/action/get.py
    M ckan/logic/action/update.py
    M ckan/model/tag.py
    A ckan/templates/group/history.html
    A ckan/templates/group/snippets/history_revisions.html
    A ckan/templates/group/snippets/revisions_table.html
    A ckan/templates/package/history.html
    M ckan/templates/package/read_base.html
    M ckan/templates/package/search.html
    A ckan/templates/package/snippets/history_revisions.html
    A ckan/templates/package/snippets/revisions_table.html
    A ckan/templates/revision/__init__.py
    A ckan/templates/revision/diff.html
    A ckan/templates/revision/list.html
    A ckan/templates/revision/read.html
    A ckan/templates/revision/read_base.html
    A ckan/templates/revision/snippets/revisions_list.html
    M ckanext/datastore/db.py
    M ckanext/datastore/plugin.py
    M ckanext/datastore/tests/test_configure.py
    R doc/contrib.rst
    M doc/index.rst
    M doc/install-from-source.rst
    M doc/legacy-api.rst
    M doc/test.rst
    M test-core.ini

  Log Message:
  -----------
  Merge branch 'master' of github.com:okfn/ckan into 621-bug-move-extras_validation_into___before

  Commit: bcff15ac0c6262b81d3ff2ed5454f7899e3f8a3c
      https://github.com/okfn/ckan/commit/bcff15ac0c6262b81d3ff2ed5454f7899e3f8a3c
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-04-10 (Wed, 10 Apr 2013)

  Changed paths:
    M ckan/logic/validators.py
    M ckan/tests/logic/test_action.py

  Log Message:
  -----------
  [#621] Return duplicate extras key error in a list

This makes it consistent with other errors that CKAN returns.

  Commit: 98e98f0089edaf3b7e44aab50ab74dae679ef595
      https://github.com/okfn/ckan/commit/98e98f0089edaf3b7e44aab50ab74dae679ef595
  Author: kindly <kindly at gmail.com>
  Date:   2013-04-16 (Tue, 16 Apr 2013)

  Changed paths:
    M CONTRIBUTING.rst
    M ckan/config/routing.py
    M ckan/controllers/error.py
    M ckan/controllers/feed.py
    M ckan/controllers/home.py
    M ckan/controllers/organization.py
    M ckan/controllers/package.py
    M ckan/controllers/related.py
    M ckan/controllers/storage.py
    M ckan/controllers/tag.py
    M ckan/controllers/user.py
    M ckan/lib/app_globals.py
    M ckan/lib/cli.py
    M ckan/lib/dictization/model_save.py
    M ckan/public/base/css/main.css
    M ckan/public/base/less/layout.less
    M ckan/public/base/less/mixins.less
    M ckan/public/base/less/prose.less
    M ckan/templates/organization/index.html
    M ckan/templates/package/resource_read.html
    M ckan/tests/lib/test_dictization.py
    M ckanext/datastore/commands.py
    A doc/contributing.rst
    M doc/database-dumps.rst
    M doc/index.rst
    M doc/paster.rst

  Log Message:
  -----------
  Merge branch 'master' into 621-bug-move-extras_validation_into___before

  Commit: f75d21b288e5e2b1dbb7c2c416a498a28d6a5ad1
      https://github.com/okfn/ckan/commit/f75d21b288e5e2b1dbb7c2c416a498a28d6a5ad1
  Author: kindly <kindly at gmail.com>
  Date:   2013-04-16 (Tue, 16 Apr 2013)

  Changed paths:
    M ckan/logic/schema.py
    M ckan/logic/validators.py
    M ckan/tests/logic/test_action.py

  Log Message:
  -----------
  Merge branch '621-bug-move-extras_validation_into___before'

Compare: https://github.com/okfn/ckan/compare/061fdc4b7165...f75d21b288e5