[ckan-changes] [okfn/ckan] e55204: [#1384] Make the database query in related_list

Tue Dec 17 14:02:52 UTC 2013

  Branch: refs/heads/master
  Home:   https://github.com/okfn/ckan
  Commit: e552048dba78f44edd9589c0400eb0561cc0b4b0
      https://github.com/okfn/ckan/commit/e552048dba78f44edd9589c0400eb0561cc0b4b0
  Author: Nigel Babu <nigelbabu at gmail.com>
  Date:   2013-12-12 (Thu, 12 Dec 2013)

  Changed paths:
    M ckan/logic/action/get.py

  Log Message:
  -----------
  [#1384] Make the database query in related_list

* We didn't actually do the database query in related_list if we
  didn't pass a dataset. This commit fixes that.
* Share the dictize function for both cases.

  Commit: d2693b834af3516d279827181bb6f0d88d005ad1
      https://github.com/okfn/ckan/commit/d2693b834af3516d279827181bb6f0d88d005ad1
  Author: Nigel Babu <nigelbabu at gmail.com>
  Date:   2013-12-16 (Mon, 16 Dec 2013)

  Changed paths:
    M ckan/controllers/related.py

  Log Message:
  -----------
  [#1384] Update related controller to use a list

The controller relied on the output of related_list being a
Query object. Updated them to use the list.

  Commit: f32277034a326867df84082a69fd3d2452a82d3a
      https://github.com/okfn/ckan/commit/f32277034a326867df84082a69fd3d2452a82d3a
  Author: Nigel Babu <nigelbabu at gmail.com>
  Date:   2013-12-16 (Mon, 16 Dec 2013)

  Changed paths:
    M ckan/tests/functional/test_related.py

  Log Message:
  -----------
  [#1384] Update tests to deal with list

The tests also relied on related_list being a Query instead of
a list. Updated them and added new asserts.

  Commit: 546caa71b66df2cbcab34bbb50b6ebabab66cdfc
      https://github.com/okfn/ckan/commit/546caa71b66df2cbcab34bbb50b6ebabab66cdfc
  Author: Nigel Babu <nigelbabu at gmail.com>
  Date:   2013-12-16 (Mon, 16 Dec 2013)

  Changed paths:
    M ckan/logic/action/get.py

  Log Message:
  -----------
  [#1384] Update documentation for related_list

The related_list function should not need an id or dataset
parameter. We use it ourselves in the related dashboard
without an id or dataset parameter.

  Commit: d621b8b2e7c8064779401343ff1460dfdb36facc
      https://github.com/okfn/ckan/commit/d621b8b2e7c8064779401343ff1460dfdb36facc
  Author: Nigel Babu <nigelbabu at gmail.com>
  Date:   2013-12-16 (Mon, 16 Dec 2013)

  Changed paths:
    M ckan/lib/dictization/model_dictize.py

  Log Message:
  -----------
  [#1384] Remove sorted from model_dictize

related_items is already sorted from the database query.
Adding another sorting at the model_dictize level looks
unnecessary and overrides the one from the query.

  Commit: 27831b326959706f8b91b43bff4405ea9171981c
      https://github.com/okfn/ckan/commit/27831b326959706f8b91b43bff4405ea9171981c
  Author: Nigel Babu <nigelbabu at gmail.com>
  Date:   2013-12-16 (Mon, 16 Dec 2013)

  Changed paths:
    M ckan/controllers/related.py
    M ckan/tests/functional/test_related.py

  Log Message:
  -----------
  [#1384] Fix test broken due to sorted change

* Fix the test broken because it expects results from sorted.
* Correct the PEP8 change in related controller.

  Commit: ec8e5a03b10e4b00a49b291b76f96d85c8c2ed6a
      https://github.com/okfn/ckan/commit/ec8e5a03b10e4b00a49b291b76f96d85c8c2ed6a
  Author: amercader <amercadero at gmail.com>
  Date:   2013-12-17 (Tue, 17 Dec 2013)

  Changed paths:
    M ckan/controllers/related.py
    M ckan/lib/dictization/model_dictize.py
    M ckan/logic/action/get.py
    M ckan/tests/functional/test_related.py

  Log Message:
  -----------
  Merge branch '1384-related-list-503'

Compare: https://github.com/okfn/ckan/compare/5b30653d0376...ec8e5a03b10e