[ckan-changes] [okfn/ckan] e6acbd: Revert "[#406] Don't strip id's from extras in val...

Fri Feb 15 16:53:39 UTC 2013

  Branch: refs/heads/idatasetform-fixes
  Home:   https://github.com/okfn/ckan
  Commit: e6acbd4bc64580604d88d01c794db14911f5c258
      https://github.com/okfn/ckan/commit/e6acbd4bc64580604d88d01c794db14911f5c258
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-02-15 (Fri, 15 Feb 2013)

  Changed paths:
    M ckan/logic/schema.py

  Log Message:
  -----------
  Revert "[#406] Don't strip id's from extras in validate()"

This reverts commit ecfacbbc41d85bc4a83bd3ac008f185ec31b9185.

It's fine to strip IDs from extras, extra IDs are never useful or needed
by users. Any tests that are failing (or templates that are crashing,
etc.) by trying to read extra IDs should be fixed to not read extra IDs.

  Commit: d176b49636b488ff246107d4d58ec4be9dade8c8
      https://github.com/okfn/ckan/commit/d176b49636b488ff246107d4d58ec4be9dade8c8
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-02-15 (Fri, 15 Feb 2013)

  Changed paths:
    M ckan/tests/functional/api/test_activity.py

  Log Message:
  -----------
  [#406] Fix some broken tests

These tests were failing when run with an IDatasetForm plugin active
because they're trying to read extra IDs, which they shouldn't do.
Change the tests to not read extra IDs, now they pass.

See commits ecfacbbc4 and e6acbd4bc645.

Compare: https://github.com/okfn/ckan/compare/ecfacbbc41d8...d176b49636b4