[ckan-changes] [okfn/ckan] 717167: [#415] db_to_form_package_schema() don't strip key...

[GitHub]

  Branch: refs/heads/idatasetform-fixes
  Home:   https://github.com/okfn/ckan
  Commit: 717167cfb94f12ad557bc3835e73985cd8fdb642
      https://github.com/okfn/ckan/commit/717167cfb94f12ad557bc3835e73985cd8fdb642
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-02-18 (Mon, 18 Feb 2013)

  Changed paths:
    M ckan/logic/schema.py

  Log Message:
  -----------
  [#415] db_to_form_package_schema() don't strip keys from resource dicts

Add several keys to the 'resources' subschema in
db_to_form_package_schema() so that validation doesn't strip the keys
from the resources dicts. This fixes a test that was failing if run with
an IDatasetForm plugin active, and may also fix some template crashes
when an IDatasetForm plugin is active if people are accessing these
resource keys in their templates.

Fixes #415.


  Commit: aaa10bbff6e4c704e58f651f13b5b18cfa0a2571
      https://github.com/okfn/ckan/commit/aaa10bbff6e4c704e58f651f13b5b18cfa0a2571
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-02-18 (Mon, 18 Feb 2013)

  Changed paths:
    M ckan/logic/schema.py

  Log Message:
  -----------
  Remove free_tags_only from db_to_form_package_schema()

Remove the free_tags_only converter from db_to_form_package_schema's
tags subschema.

This fixes a couple of tag vocabularies tests that were failing.

Not sure if this at the same time breaks something that we don't have
tests for, we may have to put this back in later if we find a problem.


  Commit: b39fd05466ca53a869948810fb00fefff9f6c276
      https://github.com/okfn/ckan/commit/b39fd05466ca53a869948810fb00fefff9f6c276
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-02-18 (Mon, 18 Feb 2013)

  Changed paths:
    M ckan/logic/schema.py

  Log Message:
  -----------
  Delete some unhelpful comments

Not clear what these comments mean or whether it's still true.


  Commit: b0ad742736a3a8481b8d8967c5f0236850c4db32
      https://github.com/okfn/ckan/commit/b0ad742736a3a8481b8d8967c5f0236850c4db32
  Author: Ian Ward <ian at excess.org>
  Date:   2013-02-18 (Mon, 18 Feb 2013)

  Changed paths:
    M ckan/lib/navl/dictization_functions.py

  Log Message:
  -----------
  navl.validate: unflatten before restoring empty lists


  Commit: 320696932d9d1e59d5963f8e586ce0432359b0dd
      https://github.com/okfn/ckan/commit/320696932d9d1e59d5963f8e586ce0432359b0dd
  Author: Ian Ward <ian at excess.org>
  Date:   2013-02-18 (Mon, 18 Feb 2013)

  Changed paths:
    M ckan/lib/navl/dictization_functions.py

  Log Message:
  -----------
  navl.validate: fix key names in restored empty lists


  Commit: e78eb14a493601ec989855f1b3f6e1ca8a2222a3
      https://github.com/okfn/ckan/commit/e78eb14a493601ec989855f1b3f6e1ca8a2222a3
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-02-18 (Mon, 18 Feb 2013)

  Changed paths:
    M ckan/logic/schema.py

  Log Message:
  -----------
  [#375] Add license_title back to db_to_form_package_schema()

Looks like this got removed by accident, so license titles weren't
showing on dataset pages.


  Commit: 4fc12b1803c69b87ff7117a36a89b4af79715112
      https://github.com/okfn/ckan/commit/4fc12b1803c69b87ff7117a36a89b4af79715112
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-02-18 (Mon, 18 Feb 2013)

  Changed paths:
    M ckan/logic/schema.py

  Log Message:
  -----------
  Revert "Remove free_tags_only from db_to_form_package_schema()"

This reverts commit aaa10bbff6e4c704e58f651f13b5b18cfa0a2571.

The free_tags_only converter is needed after all, because it prevents
vocab tags from appearing as normal tags on the dataset read and search
pages.

Reverting aaa10bbf means that a couple of tests are failing, but I think
it's the tests that are wrong not the code.


Compare: https://github.com/okfn/ckan/compare/2d6489060e51...4fc12b1803c6