[ckan-changes] [okfn/ckan] 3811fa: [#431] Use db_to_form_package_schema() by default

Wed Feb 20 16:57:28 UTC 2013

  Branch: refs/heads/431-use-db-to-form-package-schema-by-default
  Home:   https://github.com/okfn/ckan
  Commit: 3811facd6554ecf771ab36a98b37e9e2fcd8566b
      https://github.com/okfn/ckan/commit/3811facd6554ecf771ab36a98b37e9e2fcd8566b
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-02-20 (Wed, 20 Feb 2013)

  Changed paths:
    M ckan/lib/plugins.py

  Log Message:
  -----------
  [#431] Use db_to_form_package_schema() by default

Make DefaultDatasetForm's db_to_form_schema() method return
db_to_form_package_schema() rather than None, so that validation against
db_to_form_package_schema() is done by default, even when there's no
IDatasetForm plugin active.

The reason for this is that bugs in db_to_form_package_schema() can
cause pages to crash, features to stop working, etc., but the tests
currently do not catch these bugs because db_to_form_package_schema() is
only used when an IDatasetForm plugin that returns a schema based on
db_to_form_package_schema() is active, and no such plugin is active when
the tests run.

  Commit: 8c40222cd0e3db01529400c9134a5bd7e7a746bd
      https://github.com/okfn/ckan/commit/8c40222cd0e3db01529400c9134a5bd7e7a746bd
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-02-20 (Wed, 20 Feb 2013)

  Changed paths:
    M ckan/logic/schema.py

  Log Message:
  -----------
  [#431] Show vocab tags as normal tags by default

Commit 77663865a changed the default behaviour of vocab tags so that
they are _not_ shown as normal tags (e.g. on the dataset read and search
pages). I thought this was a good idea because it's weird when you use
tag vocabulary to add a custom field, to see that tag also appear in the
normal tags. However, changing this behaviour breaks some tests, so I'm
changing it back!

If an extension is using a tag vocabulary to add a custom field, and it
doesn't want tags from that vocabulary to appear alongside normal tags,
then the extension can add the freet_tags_only converter to the schema
itself.

Compare: https://github.com/okfn/ckan/compare/3811facd6554^...8c40222cd0e3