[ckan-changes] [okfn/ckan] 4c917f: Fix #430: packages not appearing in vocabulary_sho...

GitHub noreply at github.com
Thu Feb 21 22:05:35 UTC 2013


  Branch: refs/heads/430-bug-packages-missing-from-vocabulary-show
  Home:   https://github.com/okfn/ckan
  Commit: 4c917f58e544d42c101964077a684db27caf293a
      https://github.com/okfn/ckan/commit/4c917f58e544d42c101964077a684db27caf293a
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-02-21 (Thu, 21 Feb 2013)

  Changed paths:
    M ckan/lib/dictization/model_dictize.py
    M ckan/tests/functional/api/model/test_vocabulary.py

  Log Message:
  -----------
  Fix #430: packages not appearing in vocabulary_show

vocabulary_show() had gotten broken so that the 'packages' list in a
vocabulary dict was always empty even if the vocab did have some
packages. No test was failing because this wasn't tested.

This fixes the issue and also adds a test.


  Commit: faa58686d962fe4a5da26f736edf29d1aa9998d5
      https://github.com/okfn/ckan/commit/faa58686d962fe4a5da26f736edf29d1aa9998d5
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-02-21 (Thu, 21 Feb 2013)

  Changed paths:
    M ckan/tests/functional/api/model/test_vocabulary.py

  Log Message:
  -----------
  PEP8


  Commit: d2891c3fc16302eb5f5c26e039a5711e766efdca
      https://github.com/okfn/ckan/commit/d2891c3fc16302eb5f5c26e039a5711e766efdca
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-02-21 (Thu, 21 Feb 2013)

  Changed paths:
    M ckan/lib/dictization/model_dictize.py

  Log Message:
  -----------
  [#430] Use package_dictize() for a tag's packages

Use package_dictize() not obj_list_dictize() to dictize a tag's
list of packages. This means that certain keys such as "isopen" that
were missing from the package dicts, are now there. This fixes some
tests that were failing due to crashes from code trying to read these
keys.


Compare: https://github.com/okfn/ckan/compare/4c917f58e544^...d2891c3fc163


More information about the ckan-changes mailing list