[ckan-changes] [okfn/ckan] 0caa88: [#1025] User log in/out fixes including i18n and n...

Mon Jul 1 11:40:06 UTC 2013

  Branch: refs/heads/release-v2.1
  Home:   https://github.com/okfn/ckan
  Commit: 0caa88a5e0c47a278046e1216d950b01ef0a44da
      https://github.com/okfn/ckan/commit/0caa88a5e0c47a278046e1216d950b01ef0a44da
  Author: tobes <toby.junk at gmail.com>
  Date:   2013-07-01 (Mon, 01 Jul 2013)

  Changed paths:
    M ckan/controllers/user.py
    M ckan/lib/repoze_patch.py

  Log Message:
  -----------
  [#1025] User log in/out fixes including i18n and non standard root url

  Commit: c41b5259c4e140f1433895639c23b88a53dbffdd
      https://github.com/okfn/ckan/commit/c41b5259c4e140f1433895639c23b88a53dbffdd
  Author: tobes <toby.junk at gmail.com>
  Date:   2013-07-01 (Mon, 01 Jul 2013)

  Changed paths:
    M ckan/tests/functional/test_user.py

  Log Message:
  -----------
  [#1025] Fix failing tests due to extra redirect etc (stupid tests)

  Commit: d093b5e2e87cfd7168e435621c046f9d0653ba9f
      https://github.com/okfn/ckan/commit/d093b5e2e87cfd7168e435621c046f9d0653ba9f
  Author: tobes <toby.junk at gmail.com>
  Date:   2013-07-01 (Mon, 01 Jul 2013)

  Changed paths:
    M ckan/controllers/user.py

  Log Message:
  -----------
  [#1039] make sure came_from url is sane (local)

  Commit: 9a755e8e3d8b872a8a0a31915bac26edbdc6074f
      https://github.com/okfn/ckan/commit/9a755e8e3d8b872a8a0a31915bac26edbdc6074f
  Author: tobes <toby.junk at gmail.com>
  Date:   2013-07-01 (Mon, 01 Jul 2013)

  Changed paths:
    M ckan/controllers/user.py

  Log Message:
  -----------
  [#1039] Minor code cleanup - unused imports

  Commit: da182f3c86c9a85a583a6f66d0b91eefd4dd655e
      https://github.com/okfn/ckan/commit/da182f3c86c9a85a583a6f66d0b91eefd4dd655e
  Author: tobes <toby.junk at gmail.com>
  Date:   2013-07-01 (Mon, 01 Jul 2013)

  Changed paths:
    M ckan/controllers/user.py

  Log Message:
  -----------
  [#1039] Fix for own domain

  Commit: ce12b3cfb3557ad3ad8601c224f2fdf8de4c6edb
      https://github.com/okfn/ckan/commit/ce12b3cfb3557ad3ad8601c224f2fdf8de4c6edb
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-07-01 (Mon, 01 Jul 2013)

  Changed paths:
    M ckan/tests/functional/api/test_activity.py

  Log Message:
  -----------
  [#953] Add API tests for private dataset activities

Add tests that no activities are emitted when creating, updating or
deleting private datasets via the API.

These could be more detailed, e.g. test adding, deleting and updating
groups as well, or moving the dataset between groups or between orgs, or
testing what happens when a private dataset is made public or
vice-versa.

  Commit: 2dfe7b6f7f6a12d8487e59e2f9673967770805a3
      https://github.com/okfn/ckan/commit/2dfe7b6f7f6a12d8487e59e2f9673967770805a3
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-07-01 (Mon, 01 Jul 2013)

  Changed paths:
    M ckan/templates/package/snippets/package_basic_fields.html
    M ckan/templates/package/snippets/package_metadata_fields.html

  Log Message:
  -----------
  [#953] Move new dataset visibility to first stage

Move the visibility option (public or private) when creating a dataset
to the first stage of the dataset creation form. This fixes the issue
(#953) that an activity is emitted when creating private datasets. Since
the dataset is actually created when the first form is submitted, and
the public/private setting is not chosen until the third form, the
dataset is public at the moment when it's created and an activity is
emitted.

It seems to make a lot more sense fo the visibility option to be on the
first form next to the organization option anyway.

Fixes #953.

  Commit: 3cf799317f1d03df103d64f9be6efc57a0705b8f
      https://github.com/okfn/ckan/commit/3cf799317f1d03df103d64f9be6efc57a0705b8f
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-07-01 (Mon, 01 Jul 2013)

  Changed paths:
    M ckan/logic/auth/get.py

  Log Message:
  -----------
  [#953] Allow anyone to read datasets with no org

If a dataset has no owner organization, authorize anyone to read that
dataset (regardless of whether it's public or private).

  Commit: d9bb57c5b5490dc07ff80abadfcd4407b02398d8
      https://github.com/okfn/ckan/commit/d9bb57c5b5490dc07ff80abadfcd4407b02398d8
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-07-01 (Mon, 01 Jul 2013)

  Changed paths:
    M ckan/templates/package/snippets/package_basic_fields.html

  Log Message:
  -----------
  [#953] Fix display or Organization and Visibility dropdowns

Fix the logic for displaying the Organization and Visibility dropdowns
when creating or updating a dataset.

We really need frontend tests for this.

I tested these cases manually:

User is not logged in and anon_create_dataset = True: neither
Organization nor Visibility shows, either when creating or when updating
a dataset.

User is logged in, but is not a member of any organization: neither
Organization nor Visibility shows, either when creating or when updating
a dataset. Tested both when the site has no organizations and when the
site does have orgs but user is not a member of any.

User is logged in, and is a member of an organization: Both Organization
and Visibility show when creating a dataset.

When creating a private dataset, no activities appear in the activity
stream.

User is logged in, and is a member of an organization, but dataset is
not a member of any org: neither Organization nor Visibility shows when
updating a dataset.

User is logged in, and is a member of an organization, and dataset is a
member of any org: Visibility shows but Organization does not show when
updating a dataset.

User is sysadmin, site has no orgs: neither Organization nor Visibility
shows when creating or updating a dataset.

User is sysadmin, site does have orgs: both Organization and Visibility
show when creating or updating a dataset.

  Commit: 1a05c7495ecc12754a7484ac8c8ed1ccf78a71bd
      https://github.com/okfn/ckan/commit/1a05c7495ecc12754a7484ac8c8ed1ccf78a71bd
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-07-01 (Mon, 01 Jul 2013)

  Changed paths:
    M ckan/logic/auth/get.py

  Log Message:
  -----------
  [#953] Don't show inactive datasets

Don't allow non-sysadmins to read inactive datasets.

This fixes a test that was failing.

  Commit: f7ee934a4d2410219808d2a6fa70a5573f989293
      https://github.com/okfn/ckan/commit/f7ee934a4d2410219808d2a6fa70a5573f989293
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-07-01 (Mon, 01 Jul 2013)

  Changed paths:
    M ckan/logic/schema.py
    M ckan/logic/validators.py
    M ckan/tests/functional/api/model/test_package.py

  Log Message:
  -----------
  [#953] Don't allow private datasets with no organization

Add a validator to prevent private datasets with no organization from
being created by package_create or package_update.

Conflicts:

	ckan/logic/schema.py
	ckan/logic/validators.py

  Commit: 475a266d053960f475102f18069384bccbdd1201
      https://github.com/okfn/ckan/commit/475a266d053960f475102f18069384bccbdd1201
  Author: John Martin <me at johnmart.in>
  Date:   2013-07-01 (Mon, 01 Jul 2013)

  Changed paths:
    A ckan/public/base/javascript/modules/dataset-visibility.js
    M ckan/public/base/javascript/resource.config
    M ckan/templates/package/snippets/package_basic_fields.html

  Log Message:
  -----------
  [#953] Adds JS module for disabling visibility field on dataset creation

Essentially we get the current value of the visibility dropdown and then if no
org is selected then we disable the visibilty dropdown and set it to be public.

Conflicts:

	ckan/public/base/javascript/resource.config

  Commit: 40a408bf9763b978429379bae6421f389f2a8f7c
      https://github.com/okfn/ckan/commit/40a408bf9763b978429379bae6421f389f2a8f7c
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-07-01 (Mon, 01 Jul 2013)

  Changed paths:
    M ckan/tests/logic/test_action.py

  Log Message:
  -----------
  [#953] Fix a broken test

This test was trying to create private datasets that don't belong to any
organization, which isn't allowed.

  Commit: 2676bb233e02628ab4587082560ad9d17482fafb
      https://github.com/okfn/ckan/commit/2676bb233e02628ab4587082560ad9d17482fafb
  Author: joetsoi <joe.yeung.tsoi at gmail.com>
  Date:   2013-07-01 (Mon, 01 Jul 2013)

  Changed paths:
    M ckanext/datastore/tests/test_search.py

  Log Message:
  -----------
  [#953] fix datastore tests

create an organization in setup and use it in package_create

Compare: https://github.com/okfn/ckan/compare/769092d2319f...2676bb233e02