[ckan-changes] [okfn/ckan] 1eb9d9: [#1011] Fix a 500 to a 404

GitHub noreply at github.com
Wed Jun 19 14:13:31 UTC 2013


  Branch: refs/heads/1011-template-not-found
  Home:   https://github.com/okfn/ckan
  Commit: 1eb9d94077bd7d0dc586fefcb0d6b49042606b6c
      https://github.com/okfn/ckan/commit/1eb9d94077bd7d0dc586fefcb0d6b49042606b6c
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-06-19 (Wed, 19 Jun 2013)

  Changed paths:
    M ckan/controllers/package.py
    M ckan/plugins/interfaces.py

  Log Message:
  -----------
  [#1011] Fix a 500 to a 404

Catch Genshi TemplateNotFound errors when rendering the package read
page. This can happen if an IDatasetForm plugin returns a custom package
read template, e.g. 'read.html', but the user has requested the dataset
in RDF format and the plugin does not provide a corresponding 'read.rdf'
template. (CKAN will take the path to read.html, replace the filename
extension with rdf, try to render this non-existing template file, and
crash.)

Replace this crash with a proper 404.

Add to the IDatasetForm docs, explaining how to provide RDF templates
for datasets.

Fixes #1011.





More information about the ckan-changes mailing list