[ckan-changes] [okfn/ckan] 433181: [#2750] Add example_idatasetform example extension
GitHub
noreply at github.com
Tue Mar 19 18:18:01 UTC 2013
Branch: refs/heads/idatasetform-package-schemas-simplification
Home: https://github.com/okfn/ckan
Commit: 4331816b09dc92cb7c0dfb6aa7b95d49ea89d3da
https://github.com/okfn/ckan/commit/4331816b09dc92cb7c0dfb6aa7b95d49ea89d3da
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-02-25 (Mon, 25 Feb 2013)
Changed paths:
A ckanext/example_idatasetform/__init__.py
A ckanext/example_idatasetform/plugin.py
A ckanext/example_idatasetform/templates/package/new_package_metadata.html
A ckanext/example_idatasetform/templates/package/read.html
A ckanext/example_idatasetform/templates/package/snippets/package_form.html
A ckanext/example_idatasetform/templates/package/snippets/package_metadata_fields.html
A ckanext/example_idatasetform/templates/package/snippets/package_metadata_form.html
A ckanext/example_idatasetform/tests/test_example_idatasetform_plugin.py
M setup.py
Log Message:
-----------
[#2750] Add example_idatasetform example extension
Commit: a1bedacb926557e673cb2365928e4c8e864d477b
https://github.com/okfn/ckan/commit/a1bedacb926557e673cb2365928e4c8e864d477b
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-02-25 (Mon, 25 Feb 2013)
Changed paths:
M ckan/lib/plugins.py
M ckan/plugins/interfaces.py
M doc/conf.py
Log Message:
-----------
[#2750] Improve IDatasetForm docstrings
- Rewrite the IDatasetForm docstrings to make them clearer,
and conform to PEP257
- Reorder methods in IDatasetForm and DefaultDatasetForm
so that they're 1. in a more logical order and 2. in the
same order as eachother
- Tell autodoc to put the methods in source-code order,
not alphabetical, in the sphinx docs
- Remove docstrings from DefaultDatasetForm that are
exact repeats of corresponding docstrings in IDatasetForm
- Add edit_template() to IDatasetForm, it was missing
db_to_form_schema_options() and form_to_db_schema_options() and some
other schema methods in DefaultDatasetForm are still missing from
IDatasetForm but I'm leaving it that way for now, consider them
unofficial.
Commit: cec55a24b305919c0251f706af6cc290406c93ef
https://github.com/okfn/ckan/commit/cec55a24b305919c0251f706af6cc290406c93ef
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-02-25 (Mon, 25 Feb 2013)
Changed paths:
R doc/forms.rst
M doc/index.rst
Log Message:
-----------
[#2750] Delete 'Customizing Forms' docs
They are out of date, and we have ckanext/example_idatasetform instead
now.
Commit: d1f557c4e13cffa5c68180b06659ebea150a3601
https://github.com/okfn/ckan/commit/d1f557c4e13cffa5c68180b06659ebea150a3601
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-02-26 (Tue, 26 Feb 2013)
Changed paths:
M doc/tag-vocabularies.rst
Log Message:
-----------
[#2750] Rewrite tag vocabularies docs
Change the tag vocabularies docs to refer to the working example in
ckanext/example_idatasetform instead of providing their own detailed
instructions.
Also add some more general explanation at the start about what tag
vocabularies are for/why you might want to use them/what you can do with
them, it was all a bit mysterious.
Remove some false claims from the Properties section, I don't think that
the restricted/free vocabulary types are implemented (they are either
always restricted or always free, can't remember), vocabularies do not
have descriptions.
Commit: 9808ed42c68612b40227480d86613729f1c89b0d
https://github.com/okfn/ckan/commit/9808ed42c68612b40227480d86613729f1c89b0d
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-02-26 (Tue, 26 Feb 2013)
Changed paths:
M ckanext/example_idatasetform/plugin.py
Log Message:
-----------
[#2750] example_idatasetform use toolkit not logic
Use ckan.plugins.toolkit instead of ckan.logic in ckanext/example_idatasetform
Commit: 9de978e4e63ec684d43bed9b41fc5c24fda05ecf
https://github.com/okfn/ckan/commit/9de978e4e63ec684d43bed9b41fc5c24fda05ecf
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-02-27 (Wed, 27 Feb 2013)
Changed paths:
M .travis.yml
M ckan/controllers/home.py
M ckan/controllers/package.py
M ckan/controllers/revision.py
M ckan/controllers/tag.py
M ckan/controllers/template.py
M ckan/lib/base.py
M ckan/lib/helpers.py
M ckan/lib/jinja_extensions.py
M ckan/lib/search/__init__.py
M ckan/model/group.py
M ckan/templates/package/search.html
M ckan/templates_legacy/package/search.html
M ckan/tests/functional/api/base.py
M ckan/tests/functional/api/model/test_group.py
M ckan/tests/functional/api/model/test_licenses.py
M ckan/tests/functional/api/model/test_package.py
M ckan/tests/functional/api/model/test_ratings.py
M ckan/tests/functional/api/model/test_relationships.py
M ckan/tests/functional/api/model/test_revisions.py
M ckan/tests/functional/api/model/test_tag.py
M ckan/tests/functional/api/test_api.py
M ckan/tests/functional/api/test_misc.py
M ckan/tests/functional/api/test_package_search.py
M ckan/tests/functional/api/test_resource_search.py
M ckan/tests/models/test_group.py
M ckanext/datastore/db.py
M ckanext/datastore/tests/test_create.py
M ckanext/datastore/tests/test_unit.py
M ckanext/resourceproxy/controller.py
M pip-requirements.txt
M test-core.ini
Log Message:
-----------
Merge branch 'master' of github.com:okfn/ckan into example_idatasetform_without_tests
Commit: aeb26878986832db8528fb3b3f74fe5976a06462
https://github.com/okfn/ckan/commit/aeb26878986832db8528fb3b3f74fe5976a06462
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-02-27 (Wed, 27 Feb 2013)
Changed paths:
M ckanext/example_idatasetform/plugin.py
M ckanext/example_idatasetform/templates/package/snippets/package_metadata_fields.html
Log Message:
-----------
[#2750] Add a convert_to_extras field to ExampleIDatasetFormPlugin
Add another custom field to ExampleIDatasetFormPlugin, one that uses
convert_to/from_extras instead of convert_to/from_tags.
I also had to make the plugin disable DefaultDatasetForm's
check_data_dict() because it breaks with the new three-stage dataset
creation when using convert_to_extras.
Commit: 7e3de5fb9ac074acc892f029f211d0a31bea4df9
https://github.com/okfn/ckan/commit/7e3de5fb9ac074acc892f029f211d0a31bea4df9
Author: tobes <toby.junk at gmail.com>
Date: 2013-03-04 (Mon, 04 Mar 2013)
Changed paths:
M ckan/controllers/group.py
M ckan/lib/dictization/model_dictize.py
M ckan/lib/search/index.py
Log Message:
-----------
[#515] Fix issue with orgs appearing in group facet
Commit: 04d0a7445061b7ae0342e81a639f28aae75878aa
https://github.com/okfn/ckan/commit/04d0a7445061b7ae0342e81a639f28aae75878aa
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-05 (Tue, 05 Mar 2013)
Changed paths:
M ckanext/example_idatasetform/tests/test_example_idatasetform_plugin.py
Log Message:
-----------
[#2750] Fix tag editing test in example_idatasetform
Commit: 8757d2a99a8c6fcb35e57ecd40c43fb6dd219a2b
https://github.com/okfn/ckan/commit/8757d2a99a8c6fcb35e57ecd40c43fb6dd219a2b
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-05 (Tue, 05 Mar 2013)
Changed paths:
M ckanext/example_idatasetform/tests/test_example_idatasetform_plugin.py
Log Message:
-----------
[#2750] Edit some other fields in example_idatasetform test
Test that normal dataset fields can still be edited when using
IDatasetForm.
Commit: 2f2a960b5aa0e0b3706c4ea38425cb626ccbd7b8
https://github.com/okfn/ckan/commit/2f2a960b5aa0e0b3706c4ea38425cb626ccbd7b8
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-05 (Tue, 05 Mar 2013)
Changed paths:
M ckanext/example_idatasetform/plugin.py
M ckanext/example_idatasetform/tests/test_example_idatasetform_plugin.py
Log Message:
-----------
[#2750] Finish example_idatasetform tests
This just finishes up the example_idatasetform tests that count how many
times the per-dataset-type templates are called.
Commit: 9a56e8e6f5b53b2e2b0e8a7fe2842e2716700319
https://github.com/okfn/ckan/commit/9a56e8e6f5b53b2e2b0e8a7fe2842e2716700319
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-11 (Mon, 11 Mar 2013)
Changed paths:
A ckanext/example_idatasetform/__init__.py
A ckanext/example_idatasetform/plugin.py
A ckanext/example_idatasetform/templates/package/new_package_metadata.html
A ckanext/example_idatasetform/templates/package/read.html
A ckanext/example_idatasetform/templates/package/snippets/package_form.html
A ckanext/example_idatasetform/templates/package/snippets/package_metadata_fields.html
A ckanext/example_idatasetform/templates/package/snippets/package_metadata_form.html
M setup.py
Log Message:
-----------
[#2750] Add ckanext/example_idatasetform
Commit: 5f21ec9596af67c1dd9282d3b9628fd642d0bce8
https://github.com/okfn/ckan/commit/5f21ec9596af67c1dd9282d3b9628fd642d0bce8
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-11 (Mon, 11 Mar 2013)
Changed paths:
M ckan/lib/plugins.py
M ckan/plugins/interfaces.py
M doc/conf.py
Log Message:
-----------
[#2750] Improve IDatasetForm docstrings
- Rewrite the IDatasetForm docstrings to make them clearer,
and conform to PEP257
- Reorder methods in IDatasetForm and DefaultDatasetForm
so that they're 1. in a more logical order and 2. in the
same order as eachother
- Tell autodoc to put the methods in source-code order,
not alphabetical, in the sphinx docs
- Remove docstrings from DefaultDatasetForm that are
exact repeats of corresponding docstrings in IDatasetForm
- Add edit_template() to IDatasetForm, it was missing
db_to_form_schema_options() and form_to_db_schema_options() and some
other schema methods in DefaultDatasetForm are still missing from
IDatasetForm but I'm leaving it that way for now, consider them
unofficial.
Commit: 8e0604217112ed7a95856cea723d2f551aac6341
https://github.com/okfn/ckan/commit/8e0604217112ed7a95856cea723d2f551aac6341
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-11 (Mon, 11 Mar 2013)
Changed paths:
R doc/forms.rst
M doc/index.rst
Log Message:
-----------
[#2750] Delete 'Customizing Forms' docs
They are out of date, and we have ckanext/example_idatasetform instead
now.
Commit: bd44895179ef576ba624c64c88453e269461d26d
https://github.com/okfn/ckan/commit/bd44895179ef576ba624c64c88453e269461d26d
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-11 (Mon, 11 Mar 2013)
Changed paths:
M doc/tag-vocabularies.rst
Log Message:
-----------
[#2750] Rewrite tag vocabularies docs
Change the tag vocabularies docs to refer to the working example in
ckanext/example_idatasetform instead of providing their own detailed
instructions.
Also add some more general explanation at the start about what tag
vocabularies are for/why you might want to use them/what you can do with
them, it was all a bit mysterious.
Remove some false claims from the Properties section, I don't think that
the restricted/free vocabulary types are implemented (they are either
always restricted or always free, can't remember), vocabularies do not
have descriptions.
Commit: d0f8e93fcdeb1a1dfc26a5fd58def35372b55fe6
https://github.com/okfn/ckan/commit/d0f8e93fcdeb1a1dfc26a5fd58def35372b55fe6
Author: tobes <toby.junk at gmail.com>
Date: 2013-03-13 (Wed, 13 Mar 2013)
Changed paths:
M .travis.yml
A bin/travis-build
A ckan/common.py
M ckan/config/routing.py
M ckan/controllers/api.py
M ckan/controllers/feed.py
M ckan/controllers/group.py
M ckan/controllers/organization.py
M ckan/controllers/package.py
M ckan/controllers/user.py
M ckan/lib/app_globals.py
R ckan/lib/authztool.py
M ckan/lib/base.py
M ckan/lib/cli.py
M ckan/lib/create_test_data.py
M ckan/lib/datapreview.py
M ckan/lib/dumper.py
M ckan/lib/field_types.py
M ckan/lib/helpers.py
M ckan/lib/jinja_extensions.py
M ckan/lib/jsonp.py
M ckan/lib/mailer.py
M ckan/lib/plugins.py
M ckan/lib/repoze_patch.py
M ckan/lib/search/query.py
M ckan/logic/__init__.py
M ckan/logic/action/create.py
M ckan/logic/action/get.py
M ckan/logic/validators.py
M ckan/migration/versions/022_add_group_extras.py
M ckan/migration/versions/029_version_groups.py
M ckan/migration/versions/067_turn_extras_to_strings.py
M ckan/plugins/interfaces.py
M ckan/plugins/toolkit.py
R ckan/public/base/css/fuchsia.min.css
R ckan/public/base/css/green.min.css
M ckan/public/base/css/main.css
R ckan/public/base/css/main.min.css
R ckan/public/base/css/maroon.min.css
R ckan/public/base/css/red.min.css
R ckan/public/base/datapreview/vendor/flot/0.7/excanvas.min.js
R ckan/public/base/datapreview/vendor/flot/0.7/jquery.flot.min.js
R ckan/public/base/datapreview/vendor/leaflet.markercluster/MarkerCluster.Default.ie.min.css
R ckan/public/base/datapreview/vendor/leaflet.markercluster/MarkerCluster.Default.min.css
R ckan/public/base/datapreview/vendor/leaflet.markercluster/MarkerCluster.min.css
R ckan/public/base/datapreview/vendor/leaflet.markercluster/leaflet.markercluster.min.js
R ckan/public/base/datapreview/vendor/leaflet/0.3.1/leaflet.ie.min.css
R ckan/public/base/datapreview/vendor/leaflet/0.3.1/leaflet.min.css
R ckan/public/base/datapreview/vendor/leaflet/0.3.1/leaflet.min.js
R ckan/public/base/datapreview/vendor/leaflet/0.4.4/leaflet-src.min.js
R ckan/public/base/i18n/bg.min.js
R ckan/public/base/i18n/ca.min.js
R ckan/public/base/i18n/cs_CZ.min.js
R ckan/public/base/i18n/de.min.js
R ckan/public/base/i18n/el.min.js
R ckan/public/base/i18n/es.min.js
R ckan/public/base/i18n/fi.min.js
R ckan/public/base/i18n/fr.min.js
R ckan/public/base/i18n/hu.min.js
R ckan/public/base/i18n/it.min.js
R ckan/public/base/i18n/lt.min.js
R ckan/public/base/i18n/lv.min.js
R ckan/public/base/i18n/nl.min.js
R ckan/public/base/i18n/no.min.js
R ckan/public/base/i18n/pl.min.js
R ckan/public/base/i18n/pt_BR.min.js
R ckan/public/base/i18n/ro.min.js
R ckan/public/base/i18n/ru.min.js
R ckan/public/base/i18n/sk.min.js
R ckan/public/base/i18n/sl.min.js
R ckan/public/base/i18n/sq.min.js
R ckan/public/base/i18n/sr.min.js
R ckan/public/base/i18n/sr_Latn.min.js
R ckan/public/base/i18n/sv.min.js
R ckan/public/base/i18n/zh_TW.min.js
A ckan/public/base/images/table-seperator.png
R ckan/public/base/javascript/client.min.js
R ckan/public/base/javascript/i18n.min.js
R ckan/public/base/javascript/main.min.js
R ckan/public/base/javascript/module.min.js
R ckan/public/base/javascript/modules/api-info.min.js
R ckan/public/base/javascript/modules/autocomplete.min.js
R ckan/public/base/javascript/modules/basic-form.min.js
R ckan/public/base/javascript/modules/confirm-action.min.js
R ckan/public/base/javascript/modules/custom-fields.min.js
R ckan/public/base/javascript/modules/dashboard.min.js
R ckan/public/base/javascript/modules/data-viewer.min.js
R ckan/public/base/javascript/modules/follow.min.js
R ckan/public/base/javascript/modules/related-item.min.js
R ckan/public/base/javascript/modules/resource-form.min.js
R ckan/public/base/javascript/modules/resource-upload-field.min.js
R ckan/public/base/javascript/modules/select-switch.min.js
R ckan/public/base/javascript/modules/slug-preview.min.js
A ckan/public/base/javascript/modules/table-toggle-more.js
R ckan/public/base/javascript/notify.min.js
R ckan/public/base/javascript/plugins/jquery.date-helpers.min.js
R ckan/public/base/javascript/plugins/jquery.form-warning.min.js
R ckan/public/base/javascript/plugins/jquery.inherit.min.js
R ckan/public/base/javascript/plugins/jquery.proxy-all.min.js
R ckan/public/base/javascript/plugins/jquery.slug-preview.min.js
R ckan/public/base/javascript/plugins/jquery.slug.min.js
R ckan/public/base/javascript/plugins/jquery.truncator.min.js
R ckan/public/base/javascript/plugins/jquery.url-helpers.min.js
R ckan/public/base/javascript/pubsub.min.js
M ckan/public/base/javascript/resource.config
R ckan/public/base/javascript/sandbox.min.js
R ckan/public/base/javascript/tracking.min.js
M ckan/public/base/less/dataset.less
M ckan/public/base/less/homepage.less
M ckan/public/base/less/mixins.less
M ckan/public/base/less/module.less
M ckan/public/base/less/nav.less
M ckan/public/base/less/tables.less
M ckan/public/base/less/variables.less
R ckan/public/base/test/spec/ckan.spec.min.js
R ckan/public/base/test/spec/client.spec.min.js
R ckan/public/base/test/spec/module.spec.min.js
R ckan/public/base/test/spec/modules/autocomplete.spec.min.js
R ckan/public/base/test/spec/modules/basic-form.spec.min.js
R ckan/public/base/test/spec/modules/confirm-action.spec.min.js
R ckan/public/base/test/spec/modules/custom-fields.spec.min.js
R ckan/public/base/test/spec/modules/related-item.spec.min.js
R ckan/public/base/test/spec/modules/resource-form.spec.min.js
R ckan/public/base/test/spec/modules/resource-upload-field.spec.min.js
R ckan/public/base/test/spec/notify.spec.min.js
R ckan/public/base/test/spec/plugins/jquery.date-helpers.spec.min.js
R ckan/public/base/test/spec/plugins/jquery.form-warning.spec.min.js
R ckan/public/base/test/spec/plugins/jquery.inherit.spec.min.js
R ckan/public/base/test/spec/plugins/jquery.proxy-all.spec.min.js
R ckan/public/base/test/spec/plugins/jquery.slug-preview.spec.min.js
R ckan/public/base/test/spec/plugins/jquery.slug.spec.min.js
R ckan/public/base/test/spec/plugins/jquery.url-helpers.spec.min.js
R ckan/public/base/test/spec/pubsub.spec.min.js
R ckan/public/base/test/spec/sandbox.spec.min.js
M ckan/templates/admin/base.html
M ckan/templates/admin/config.html
M ckan/templates/admin/index.html
M ckan/templates/ajax_snippets/api_info.html
M ckan/templates/dataviewer/snippets/no_preview.html
M ckan/templates/development/snippets/page_header.html
M ckan/templates/error_document_template.html
M ckan/templates/footer.html
M ckan/templates/group/index.html
M ckan/templates/group/read.html
M ckan/templates/group/read_base.html
M ckan/templates/home/about.html
M ckan/templates/home/index.html
M ckan/templates/home/snippets/about_text.html
A ckan/templates/organization/activity_stream.html
M ckan/templates/organization/edit.html
M ckan/templates/organization/edit_base.html
M ckan/templates/organization/index.html
M ckan/templates/organization/new.html
M ckan/templates/organization/read.html
M ckan/templates/organization/read_base.html
M ckan/templates/package/base.html
M ckan/templates/package/read_base.html
M ckan/templates/package/related_list.html
M ckan/templates/package/resource_edit.html
M ckan/templates/package/resource_read.html
M ckan/templates/package/search.html
M ckan/templates/package/snippets/data_api_button.html
M ckan/templates/package/snippets/info.html
M ckan/templates/package/snippets/package_metadata_fields.html
M ckan/templates/package/snippets/search_form.html
M ckan/templates/page.html
M ckan/templates/related/base_form_page.html
M ckan/templates/related/snippets/related_form.html
M ckan/templates/snippets/datapreview_embed_dialog.html
M ckan/templates/snippets/disqus_trackback.html
M ckan/templates/snippets/facet_list.html
M ckan/templates/snippets/home_breadcrumb_item.html
M ckan/templates/snippets/license.html
M ckan/templates/snippets/organization.html
M ckan/templates/snippets/package_item.html
R ckan/templates/snippets/page_header.html
M ckan/templates/snippets/popular.html
M ckan/templates/snippets/related.html
A ckan/templates/snippets/search_result_text.html
M ckan/templates/snippets/social.html
M ckan/templates/snippets/subscribe.html
M ckan/templates/user/edit_base.html
M ckan/templates/user/logout_first.html
M ckan/templates/user/read_base.html
M ckan/templates/user/snippets/followee_dropdown.html
M ckan/tests/__init__.py
M ckan/tests/functional/api/base.py
M ckan/tests/functional/api/model/test_vocabulary.py
M ckan/tests/functional/api/test_activity.py
M ckan/tests/functional/api/test_dashboard.py
M ckan/tests/functional/api/test_util.py
M ckan/tests/functional/test_group.py
M ckan/tests/functional/test_preview_interface.py
M ckan/tests/functional/test_search.py
M ckan/tests/lib/test_cli.py
M ckan/tests/lib/test_datapreview.py
M ckan/tests/logic/test_action.py
M ckan/tests/misc/test_sync.py
R ckan/tests/mock_publisher_auth.py
M ckan/tests/test_dumper.py
M ckanext/datastore/db.py
M ckanext/datastore/plugin.py
A ckanext/datastore/tests/test_configure.py
M ckanext/datastore/tests/test_search.py
M ckanext/datastore/tests/test_unit.py
R ckanext/jsonpreview/theme/public/css/json.min.css
R ckanext/jsonpreview/theme/public/preview_json.min.js
R ckanext/pdfpreview/theme/public/css/pdf.min.css
R ckanext/pdfpreview/theme/public/css/recline.min.css
R ckanext/pdfpreview/theme/public/preview_pdf.min.js
R ckanext/publisher_form/__init__.py
R ckanext/publisher_form/forms.py
R ckanext/publisher_form/templates/dataset_form.html
R ckanext/publisher_form/templates/publisher_form.html
R ckanext/publisher_form/templates/publisher_index.html
R ckanext/publisher_form/templates/publisher_layout.html
R ckanext/publisher_form/templates/publisher_new.html
R ckanext/publisher_form/templates/publisher_read.html
R ckanext/reclinepreview/theme/public/css/recline.min.css
R doc/api-tutorial.rst
R doc/api-util.rst
R doc/api-v2.rst
M doc/api.rst
R doc/apiv3.rst
M doc/architecture.rst
A doc/ckan.logic.action.create.rst
A doc/ckan.logic.action.delete.rst
A doc/ckan.logic.action.get.rst
A doc/ckan.logic.action.update.rst
M doc/conf.py
M doc/datastore-api.rst
A doc/filestore-api.rst
M doc/filestore.rst
M doc/index.rst
M doc/install-from-source.rst
A doc/legacy-api.rst
M doc/loading-data.rst
M doc/multilingual.rst
M doc/python-coding-standards.rst
M doc/tag-vocabularies.rst
M setup.py
Log Message:
-----------
Merge branch 'master' into 515-org-group-search-issue
Commit: 106c9024e6a6d2c27e336808baa675e8799027e6
https://github.com/okfn/ckan/commit/106c9024e6a6d2c27e336808baa675e8799027e6
Author: tobes <toby.junk at gmail.com>
Date: 2013-03-13 (Wed, 13 Mar 2013)
Changed paths:
M ckan/lib/search/index.py
Log Message:
-----------
[#515] Add a check to stop errors
Commit: 417999c9249776817c9167057498bddc3c53472d
https://github.com/okfn/ckan/commit/417999c9249776817c9167057498bddc3c53472d
Author: John Martin <me at johnmart.in>
Date: 2013-03-14 (Thu, 14 Mar 2013)
Changed paths:
M ckan/templates/organization/members.html
Log Message:
-----------
[#630] Members table now has header and behaves like the other tables within admin
Commit: f35bbdef8e71bba575062a0eb72af7d0677e9024
https://github.com/okfn/ckan/commit/f35bbdef8e71bba575062a0eb72af7d0677e9024
Author: John Martin <me at johnmart.in>
Date: 2013-03-14 (Thu, 14 Mar 2013)
Changed paths:
M ckan/templates/organization/members.html
Log Message:
-----------
[#630] Moves 'Add member' button into the correct position
Commit: f609bf1ab848c65849ed3041fc61c6c51a1495d3
https://github.com/okfn/ckan/commit/f609bf1ab848c65849ed3041fc61c6c51a1495d3
Author: John Martin <me at johnmart.in>
Date: 2013-03-14 (Thu, 14 Mar 2013)
Changed paths:
M ckan/templates/organization/bulk_process.html
M ckan/templates/organization/members.html
Log Message:
-----------
[#630] Adds 'Add Dataset' button into bulk_process page
Commit: c790b48762adba05094132781d52517e04bcc85c
https://github.com/okfn/ckan/commit/c790b48762adba05094132781d52517e04bcc85c
Author: tobes <toby.junk at gmail.com>
Date: 2013-03-15 (Fri, 15 Mar 2013)
Changed paths:
M ckan/lib/app_globals.py
Log Message:
-----------
[#288] Fix for unicode/latin1 .ini values
Commit: ff05a0abf795c623660d4c77f0bc124a0905ac17
https://github.com/okfn/ckan/commit/ff05a0abf795c623660d4c77f0bc124a0905ac17
Author: tobes <toby.junk at gmail.com>
Date: 2013-03-15 (Fri, 15 Mar 2013)
Changed paths:
M ckan/controllers/group.py
M ckan/controllers/package.py
M ckan/new_authz.py
Log Message:
-----------
[#638] Clean up some imports and remove OrderedDict redefine
Commit: b2930026c5af646ffcf97a886714d5fab5dc6285
https://github.com/okfn/ckan/commit/b2930026c5af646ffcf97a886714d5fab5dc6285
Author: tobes <toby.junk at gmail.com>
Date: 2013-03-15 (Fri, 15 Mar 2013)
Changed paths:
M ckan/controllers/package.py
Log Message:
-----------
[#638] Use correct function
Commit: 00c2898c804399608e38f970e12f53db5767e77c
https://github.com/okfn/ckan/commit/00c2898c804399608e38f970e12f53db5767e77c
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-15 (Fri, 15 Mar 2013)
Changed paths:
M ckan/controllers/package.py
M ckan/lib/plugins.py
M ckan/logic/action/create.py
M ckan/logic/action/update.py
M ckan/plugins/interfaces.py
M ckan/tests/functional/test_package.py
M ckanext/example_idatasetform/plugin.py
Log Message:
-----------
[#602] Deprecate IDatasetForm's check_data_dict
With the new three-stage dataset creation form in CKAN 2.0
check_data_dict() no longer works as intended. For example,
DefaultDatasetForm's check_data_dict() breaks any IDatasetForm plugins
that are trying to use convert_to_extras() (if they inherit from
DefaultDatasetForm).
Remove the method from IDatasetForm and DefaultDatasetForm, but still
call the method in all the places it would previously have been called
_if_ the active IDatasetForm plugin has the method.
Also remove three tests that seem to be testing check_data_dict()'s
behaviours.
Note that in the existing code, check_data_dict() seems to be called
twice when creating a package, once by the package controller and once
by package_create(), and the two are inconsistent in the number of
params they expect check_data_dict() to take! On updating a package it's
called just once, by package_update(). I have preserved these "legacy"
behaviours.
Also note that IGroupForm and IOrganizationForm still have
check_data_dict() methods, we probably want to get rid of them in the
future as well.
Commit: 119800723cbdd865674ecaf38e31a9c1dc24bd70
https://github.com/okfn/ckan/commit/119800723cbdd865674ecaf38e31a9c1dc24bd70
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-15 (Fri, 15 Mar 2013)
Changed paths:
A ckan/common.py
M ckan/controllers/feed.py
M ckan/controllers/group.py
M ckan/controllers/package.py
M ckan/lib/base.py
M ckan/lib/dumper.py
M ckan/lib/field_types.py
M ckan/lib/helpers.py
M ckan/lib/jsonp.py
M ckan/lib/mailer.py
M ckan/lib/repoze_patch.py
M ckan/lib/search/index.py
M ckan/lib/search/query.py
M ckan/logic/action/create.py
M ckan/logic/action/get.py
M ckan/logic/action/update.py
M ckan/logic/schema.py
M ckan/logic/validators.py
M ckan/migration/versions/022_add_group_extras.py
M ckan/migration/versions/029_version_groups.py
M ckan/plugins/interfaces.py
M ckan/public/base/css/main.css
M ckan/public/base/less/dataset.less
M ckan/public/base/less/forms.less
M ckan/templates/ajax_snippets/api_info.html
M ckan/templates/organization/bulk_process.html
M ckan/templates/package/search.html
M ckan/templates/snippets/simple_search.html
M ckan/tests/__init__.py
M ckan/tests/functional/api/base.py
M ckan/tests/functional/api/model/test_vocabulary.py
M ckan/tests/functional/api/test_activity.py
M ckan/tests/functional/api/test_dashboard.py
M ckan/tests/functional/api/test_util.py
M ckan/tests/functional/test_search.py
M ckan/tests/lib/test_cli.py
M ckan/tests/lib/test_dictization_schema.py
M ckan/tests/lib/test_solr_search_index.py
M ckan/tests/logic/test_action.py
M ckan/tests/misc/test_sync.py
M ckan/tests/test_dumper.py
R doc/api-tutorial.rst
R doc/api-util.rst
R doc/api-v2.rst
M doc/api.rst
R doc/apiv3.rst
M doc/architecture.rst
A doc/ckan.logic.action.create.rst
A doc/ckan.logic.action.delete.rst
A doc/ckan.logic.action.get.rst
A doc/ckan.logic.action.update.rst
M doc/conf.py
M doc/datastore-api.rst
A doc/filestore-api.rst
M doc/filestore.rst
M doc/index.rst
M doc/install-from-source.rst
A doc/legacy-api.rst
M doc/loading-data.rst
M doc/multilingual.rst
M doc/python-coding-standards.rst
M pip-requirements.txt
Log Message:
-----------
Merge branch 'master' of github.com:okfn/ckan into example_idatasetform_without_tests_second_try
Conflicts:
doc/tag-vocabularies.rst
Commit: 0221455e6f1caede611881d155acfc7d5eb69815
https://github.com/okfn/ckan/commit/0221455e6f1caede611881d155acfc7d5eb69815
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-15 (Fri, 15 Mar 2013)
Changed paths:
M ckan/plugins/toolkit.py
M ckanext/example_idatasetform/plugin.py
Log Message:
-----------
[#2750] Add DefaultDatasetForm to plugins toolkit
At DefaultDatasetForm to the plugins toolkit. This means that
IDatasetForm plugins based on DefaultDatasetForm no longer need to
import ckan.lib.plugins.
Also change ExampleIDatasetForm to no longer import ckan.lib.plugins.
Commit: 4d455686b57bf94e7bb81dbd916f2b43b09cfbe7
https://github.com/okfn/ckan/commit/4d455686b57bf94e7bb81dbd916f2b43b09cfbe7
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-15 (Fri, 15 Mar 2013)
Changed paths:
M ckanext/example_idatasetform/plugin.py
R ckanext/example_idatasetform/templates/package/new_package_metadata.html
R ckanext/example_idatasetform/templates/package/snippets/package_form.html
M ckanext/example_idatasetform/templates/package/snippets/package_metadata_fields.html
R ckanext/example_idatasetform/templates/package/snippets/package_metadata_form.html
Log Message:
-----------
[#2750] Use ITemplateHelpers not setup_template_variables()
In ExampleIDatasetForm use ITemplateHelpers not
setup_template_variables() to pass the list of available country codes
to the template. This greatly reduces the number of templates that need
to be overridden!
Commit: dbc15266b966e0eac091d24b08787e9203dc2873
https://github.com/okfn/ckan/commit/dbc15266b966e0eac091d24b08787e9203dc2873
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-15 (Fri, 15 Mar 2013)
Changed paths:
M ckanext/example_idatasetform/plugin.py
Log Message:
-----------
[#2750] Move create_country_codes() to a better place
Move example_idatasetform's create_country_codes() to a better place.
Commit: 9fc9c0fd5855e620c99ac7c2835a1d6afd76c985
https://github.com/okfn/ckan/commit/9fc9c0fd5855e620c99ac7c2835a1d6afd76c985
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-15 (Fri, 15 Mar 2013)
Changed paths:
M ckanext/example_idatasetform/plugin.py
Log Message:
-----------
[#2750] Add setup_template_variables() back
Add setup_template_variables() back into ExampleIDatasetFormPlugin, just
counts how many times it gets called, for testing purposes.
Commit: d7ca27fddad1506829bca620780d464a87850317
https://github.com/okfn/ckan/commit/d7ca27fddad1506829bca620780d464a87850317
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-15 (Fri, 15 Mar 2013)
Changed paths:
M ckanext/example_idatasetform/plugin.py
Log Message:
-----------
[#2750] Use super()
Seems like the right thing to do
Commit: fb09c310a595f65dbde922acfc875d1ed1cb48d8
https://github.com/okfn/ckan/commit/fb09c310a595f65dbde922acfc875d1ed1cb48d8
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-15 (Fri, 15 Mar 2013)
Changed paths:
M ckanext/example_idatasetform/templates/package/read.html
Log Message:
-----------
[#2750] Change an HTML comment into a Jinja comment
Commit: 34911b9921756469a40ceb5320ba9451ecd75fe7
https://github.com/okfn/ckan/commit/34911b9921756469a40ceb5320ba9451ecd75fe7
Author: kindly <kindly at gmail.com>
Date: 2013-03-18 (Mon, 18 Mar 2013)
Changed paths:
M ckan/logic/action/get.py
Log Message:
-----------
#515 make it so organization titles are in facet listing
Commit: 4204dee347e40f76661dc2d781e237d79236a113
https://github.com/okfn/ckan/commit/4204dee347e40f76661dc2d781e237d79236a113
Author: John Martin <me at johnmart.in>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckan/public/base/less/module.less
Log Message:
-----------
[#629] Adds .clearfix to .module-heading to make the 'Clear all' a little nicer
Commit: 71119013dc7f78c471fbe6305457eafdc6276e55
https://github.com/okfn/ckan/commit/71119013dc7f78c471fbe6305457eafdc6276e55
Author: John Martin <me at johnmart.in>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckan/templates/package/snippets/package_metadata_fields.html
M ckanext/example_idatasetform/templates/package/snippets/package_metadata_fields.html
Log Message:
-----------
[#2750] Tweaks base package_metadata_fields.html and then {% ckan_extends %} from it.
Commit: 7ab3d44eb788331d623c57994f47de083cf6f3a0
https://github.com/okfn/ckan/commit/7ab3d44eb788331d623c57994f47de083cf6f3a0
Author: John Martin <me at johnmart.in>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckanext/example_idatasetform/templates/package/snippets/package_metadata_fields.html
Log Message:
-----------
[#2750] Simplify the template yet more
Commit: e5aac37bc235054e5ccd50b0e0285ce218b5d928
https://github.com/okfn/ckan/commit/e5aac37bc235054e5ccd50b0e0285ce218b5d928
Author: amercader <amercadero at gmail.com>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckan/lib/app_globals.py
Log Message:
-----------
Merge branch '288-unicode-title-support'
Commit: a933addf4d8cd5297ac3ae13de4923584300e93c
https://github.com/okfn/ckan/commit/a933addf4d8cd5297ac3ae13de4923584300e93c
Author: amercader <amercadero at gmail.com>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckan/public/base/less/module.less
Log Message:
-----------
Merge branch '629-clear-all-facet'
Commit: e7fa13716b42f0dcede7afbb093241a589a11aa8
https://github.com/okfn/ckan/commit/e7fa13716b42f0dcede7afbb093241a589a11aa8
Author: amercader <amercadero at gmail.com>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckan/templates/organization/bulk_process.html
M ckan/templates/organization/members.html
Log Message:
-----------
Merge branch '630-org-template-tidy-up'
Commit: 579ee38be17426d023d698bff8025c4f5849b824
https://github.com/okfn/ckan/commit/579ee38be17426d023d698bff8025c4f5849b824
Author: amercader <amercadero at gmail.com>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckan/controllers/group.py
M ckan/lib/dictization/model_dictize.py
M ckan/lib/search/index.py
M ckan/logic/action/get.py
Log Message:
-----------
Merge branch '515-org-group-search-issue'
Conflicts:
ckan/lib/search/index.py
Commit: 41684e58e917bdc710beea07b895b795addb1a53
https://github.com/okfn/ckan/commit/41684e58e917bdc710beea07b895b795addb1a53
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckanext/example_idatasetform/templates/package/snippets/package_metadata_fields.html
Log Message:
-----------
[#2750] Add custom_text_field back into example idatasetform templates
This field accidentally got removed from the templates in a previous
commit
Commit: 4483c53137a5099bcbdc7e701e92a2e2f236c9fd
https://github.com/okfn/ckan/commit/4483c53137a5099bcbdc7e701e92a2e2f236c9fd
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckanext/example_idatasetform/templates/package/snippets/package_metadata_fields.html
Log Message:
-----------
[#2750] Remove 'free extras' from package form in example idatasetform
This is necessary to make convert_to/from_extras() work
Commit: 307c89efc1cab1674eea2eb503627ccf7f1e6a0f
https://github.com/okfn/ckan/commit/307c89efc1cab1674eea2eb503627ccf7f1e6a0f
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckan/controllers/group.py
M ckan/lib/app_globals.py
M ckan/lib/dictization/model_dictize.py
M ckan/lib/search/index.py
M ckan/logic/action/get.py
M ckan/logic/auth/create.py
M ckan/logic/auth/update.py
M ckan/public/base/less/module.less
M ckan/templates/organization/bulk_process.html
M ckan/templates/organization/members.html
Log Message:
-----------
Merge branch 'master' of github.com:okfn/ckan into example_idatasetform_without_tests_second_try
Commit: 0ce63eee311a371bfcda603a01da5657f9f6892e
https://github.com/okfn/ckan/commit/0ce63eee311a371bfcda603a01da5657f9f6892e
Author: tobes <toby.junk at gmail.com>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckan/lib/plugins.py
M ckan/plugins/interfaces.py
A ckanext/example_idatasetform/__init__.py
A ckanext/example_idatasetform/plugin.py
A ckanext/example_idatasetform/templates/package/new_package_metadata.html
A ckanext/example_idatasetform/templates/package/read.html
A ckanext/example_idatasetform/templates/package/snippets/package_form.html
A ckanext/example_idatasetform/templates/package/snippets/package_metadata_fields.html
A ckanext/example_idatasetform/templates/package/snippets/package_metadata_form.html
A ckanext/example_idatasetform/tests/test_example_idatasetform_plugin.py
M doc/conf.py
R doc/forms.rst
M doc/index.rst
M doc/tag-vocabularies.rst
M setup.py
Log Message:
-----------
Merge branch 'example_idatasetform_without_tests'
Conflicts:
doc/tag-vocabularies.rst
removed
This needs to be done via the action API (:doc:`api`). Please check
the examples section to see which calls are needed.
Commit: dce07c1de1b02a243b299e241f99fb4eb7faf231
https://github.com/okfn/ckan/commit/dce07c1de1b02a243b299e241f99fb4eb7faf231
Author: John Glover <j at johnglover.net>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckan/controllers/group.py
Log Message:
-----------
[#638] PEP8
Commit: 0716121287e699f085efab684146b4409e09887d
https://github.com/okfn/ckan/commit/0716121287e699f085efab684146b4409e09887d
Author: John Glover <j at johnglover.net>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckan/controllers/group.py
M ckan/lib/app_globals.py
M ckan/lib/dictization/model_dictize.py
M ckan/lib/plugins.py
M ckan/lib/search/index.py
M ckan/logic/action/get.py
M ckan/logic/auth/create.py
M ckan/logic/auth/update.py
M ckan/plugins/interfaces.py
M ckan/public/base/less/module.less
M ckan/templates/organization/bulk_process.html
M ckan/templates/organization/members.html
A ckanext/example_idatasetform/__init__.py
A ckanext/example_idatasetform/plugin.py
A ckanext/example_idatasetform/templates/package/new_package_metadata.html
A ckanext/example_idatasetform/templates/package/read.html
A ckanext/example_idatasetform/templates/package/snippets/package_form.html
A ckanext/example_idatasetform/templates/package/snippets/package_metadata_fields.html
A ckanext/example_idatasetform/templates/package/snippets/package_metadata_form.html
A ckanext/example_idatasetform/tests/test_example_idatasetform_plugin.py
M doc/conf.py
R doc/forms.rst
M doc/index.rst
M doc/tag-vocabularies.rst
M setup.py
Log Message:
-----------
Merge remote-tracking branch 'origin/master' into 638-code-clean
Commit: fca50036635c8dfeffca8d7163b150b22efc1112
https://github.com/okfn/ckan/commit/fca50036635c8dfeffca8d7163b150b22efc1112
Author: John Glover <glover.john at gmail.com>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckan/controllers/group.py
M ckan/controllers/package.py
M ckan/new_authz.py
Log Message:
-----------
Merge pull request #638 from okfn/638-code-clean
Minor code clean OrderedDict
Commit: cfddd3c5ff2cb7cbc38ce0bb7453cbe39edd21e1
https://github.com/okfn/ckan/commit/cfddd3c5ff2cb7cbc38ce0bb7453cbe39edd21e1
Author: tobes <toby.junk at gmail.com>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckan/lib/plugins.py
M ckan/plugins/interfaces.py
R ckanext/example_idatasetform/__init__.py
R ckanext/example_idatasetform/plugin.py
R ckanext/example_idatasetform/templates/package/new_package_metadata.html
R ckanext/example_idatasetform/templates/package/read.html
R ckanext/example_idatasetform/templates/package/snippets/package_form.html
R ckanext/example_idatasetform/templates/package/snippets/package_metadata_fields.html
R ckanext/example_idatasetform/templates/package/snippets/package_metadata_form.html
R ckanext/example_idatasetform/tests/test_example_idatasetform_plugin.py
M doc/conf.py
A doc/forms.rst
M doc/index.rst
M doc/tag-vocabularies.rst
M setup.py
Log Message:
-----------
Revert "Merge branch 'example_idatasetform_without_tests'"
This reverts commit 0ce63eee311a371bfcda603a01da5657f9f6892e, reversing
changes made to 579ee38be17426d023d698bff8025c4f5849b824.
Commit: 7f24242bbd2de9345d343c22bab6b84a125bedee
https://github.com/okfn/ckan/commit/7f24242bbd2de9345d343c22bab6b84a125bedee
Author: tobes <toby.junk at gmail.com>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckan/controllers/group.py
M ckan/controllers/package.py
M ckan/new_authz.py
Log Message:
-----------
Merge branch 'master' of github.com:okfn/ckan
Commit: 3efeda6fb0cd5a381d288d728e03a8a5ea988868
https://github.com/okfn/ckan/commit/3efeda6fb0cd5a381d288d728e03a8a5ea988868
Author: tobes <toby.junk at gmail.com>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckan/controllers/package.py
M ckan/lib/plugins.py
M ckan/logic/action/create.py
M ckan/logic/action/update.py
M ckan/plugins/interfaces.py
M ckan/plugins/toolkit.py
M ckan/templates/package/snippets/package_metadata_fields.html
M ckan/tests/functional/test_package.py
A ckanext/example_idatasetform/__init__.py
A ckanext/example_idatasetform/plugin.py
A ckanext/example_idatasetform/templates/package/read.html
A ckanext/example_idatasetform/templates/package/snippets/package_metadata_fields.html
M doc/conf.py
R doc/forms.rst
M doc/index.rst
M doc/tag-vocabularies.rst
M setup.py
Log Message:
-----------
Merge branch 'example_idatasetform_without_tests_second_try'
Commit: cc4c9093526fea25ad4340b1530ef8f26dd7a9e6
https://github.com/okfn/ckan/commit/cc4c9093526fea25ad4340b1530ef8f26dd7a9e6
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckan/controllers/group.py
M ckan/controllers/package.py
M ckan/lib/app_globals.py
M ckan/lib/dictization/model_dictize.py
M ckan/lib/plugins.py
M ckan/lib/search/index.py
M ckan/logic/action/create.py
M ckan/logic/action/get.py
M ckan/logic/action/update.py
M ckan/new_authz.py
M ckan/plugins/interfaces.py
M ckan/plugins/toolkit.py
M ckan/public/base/less/module.less
M ckan/templates/organization/bulk_process.html
M ckan/templates/organization/members.html
M ckan/templates/package/snippets/package_metadata_fields.html
M ckan/tests/functional/test_package.py
A ckanext/example_idatasetform/__init__.py
A ckanext/example_idatasetform/plugin.py
A ckanext/example_idatasetform/templates/package/read.html
A ckanext/example_idatasetform/templates/package/snippets/package_metadata_fields.html
M doc/conf.py
R doc/forms.rst
M doc/index.rst
M doc/tag-vocabularies.rst
M setup.py
Log Message:
-----------
Merge branch 'master' of github.com:okfn/ckan into idatasetform-package-schemas-simplification
Conflicts:
ckan/controllers/package.py
ckan/lib/plugins.py
At this point ckanext/example_idatasetform/ is broken by the recent #649
commits, will fix it in following commits...
Commit: 0cfc3a162b1f5e3ea7c6f01281bca5b4d2709b79
https://github.com/okfn/ckan/commit/0cfc3a162b1f5e3ea7c6f01281bca5b4d2709b79
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckanext/example_idatasetform/plugin.py
Log Message:
-----------
[#649] Update example_idatasetform to new IDatasetForm interface
This imports ckan.logic.schema which is bad.
Commit: 09583bf1382d181c51786f66a83e2bc06af9588c
https://github.com/okfn/ckan/commit/09583bf1382d181c51786f66a83e2bc06af9588c
Author: Sean Hammond <seanhammond at lavabit.com>
Date: 2013-03-19 (Tue, 19 Mar 2013)
Changed paths:
M ckan/lib/plugins.py
M ckan/logic/action/create.py
M ckan/logic/action/get.py
M ckan/logic/action/update.py
M ckanext/example_idatasetform/plugin.py
Log Message:
-----------
[#649] Make DefaultDatasetForm return default schemas
Make DefaultDatasetForm's create_package_schema(),
update_package_schema() and show_package_schema() methods return
default_create_package_schema(), default_update_package_schema() and
default_show_package_schema() from schema.py.
This makes it easier for plugins as they can just inherit from
DefaultDatasetForm and call super() to get the default schemas, they
don't need to import ckan.logic.schema to get them (or we don't need to
add the default schemas to the plugins toolkit).
This removes the logic, which was repeated in package_create(),
package_update() and package_show(), of getting the schema from the
plugin but if the plugin provided no schema then falling back on the default
one from schema.py. The action functions now simply get the schema from
plugin and always expect the plugin to provide the schema. The default
fallback behaviour is provided by plugins inheriting from
DefaultDatasetForm instead.
Compare: https://github.com/okfn/ckan/compare/24a616fff72a...09583bf1382d
More information about the ckan-changes
mailing list