[ckan-changes] [okfn/ckan] a8853e: [#964] String validator: don't convert values to N...

Fri May 31 18:11:32 UTC 2013

  Branch: refs/heads/964-500-Server-Error-on-non-string-extra-value
  Home:   https://github.com/okfn/ckan
  Commit: a8853e29ece7b8db332fccc9d52cb6e8926a3ea9
      https://github.com/okfn/ckan/commit/a8853e29ece7b8db332fccc9d52cb6e8926a3ea9
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-05-31 (Fri, 31 May 2013)

  Changed paths:
    M ckan/logic/validators.py

  Log Message:
  -----------
  [#964] String validator: don't convert values to None

string_validator() was converting any string values passed to it to
None, when it should be returning the value unchanged. Oops

  Commit: f61a130edaceab3c6fab9f3e1e0c2e0422c1f6f4
      https://github.com/okfn/ckan/commit/f61a130edaceab3c6fab9f3e1e0c2e0422c1f6f4
  Author: Sean Hammond <seanhammond at lavabit.com>
  Date:   2013-05-31 (Fri, 31 May 2013)

  Changed paths:
    M ckan/logic/schema.py
    M ckan/logic/validators.py
    M ckan/tests/functional/api/model/test_package.py

  Log Message:
  -----------
  [#964] Accept null as an extra value

It's undocumented, but you can post null as the value of an extra to
delete the extra. The new string_validator() stopped this from working
and broke some tests. Change string_validator() to
must_be_string_or_none().

Compare: https://github.com/okfn/ckan/compare/ed4a55d77fac...f61a130edace