[ckan-changes] [ckan/ckan] bce737: [#1505] Merge tests that verify that the user was ...

GitHub noreply at github.com
Tue Apr 1 20:12:32 UTC 2014


  Branch: refs/heads/1505-invite-to-organization-causes-error
  Home:   https://github.com/ckan/ckan
  Commit: bce737152f0cef74783fcb4b1e73804e26d65f2c
      https://github.com/ckan/ckan/commit/bce737152f0cef74783fcb4b1e73804e26d65f2c
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-04-01 (Tue, 01 Apr 2014)

  Changed paths:
    M ckan/new_tests/logic/action/test_create.py

  Log Message:
  -----------
  [#1505] Merge tests that verify that the user was invited and it is pending

This is a tiny compromise in readability (IMO) to make the tests a bit faster


  Commit: 8b2150677f65071566ec6b579058563236f64f2b
      https://github.com/ckan/ckan/commit/8b2150677f65071566ec6b579058563236f64f2b
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-04-01 (Tue, 01 Apr 2014)

  Changed paths:
    M ckan/new_tests/logic/auth/test_create.py

  Log Message:
  -----------
  [#1505] Test not only the method call, but also that we're returning the value


  Commit: 073091c3c43dfca0b56bcc761c1322a69eba2058
      https://github.com/ckan/ckan/commit/073091c3c43dfca0b56bcc761c1322a69eba2058
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-04-01 (Tue, 01 Apr 2014)

  Changed paths:
    M ckan/new_tests/logic/auth/test_update.py

  Log Message:
  -----------
  [#1505] Test for actual True-ness, and not truthiness.

If we don't add the ```is True```, any truthy value works (i.e. 'string').


Compare: https://github.com/ckan/ckan/compare/b63da48c5e7a...073091c3c43d


More information about the ckan-changes mailing list