[ckan-changes] [ckan/ckan] e40324: [#1792] Fix issue on FTS' where clause on specific...

Wed Aug 6 21:47:42 UTC 2014

  Branch: refs/heads/1792-filterable-resource-views
  Home:   https://github.com/ckan/ckan
  Commit: e40324a17230f90ee2811d0e401f824327c53bbe
      https://github.com/ckan/ckan/commit/e40324a17230f90ee2811d0e401f824327c53bbe
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-08-06 (Wed, 06 Aug 2014)

  Changed paths:
    M ckanext/datastore/plugin.py

  Log Message:
  -----------
  [#1792] Fix issue on FTS' where clause on specific fields

We were adding the value to the where_values with no need. We ended up with
more where_values than "%s" used in the where string, which could lead to
problems.

  Commit: b3e997e05a695cf5ef4bc5d2b8261fe40ede5460
      https://github.com/ckan/ckan/commit/b3e997e05a695cf5ef4bc5d2b8261fe40ede5460
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-08-06 (Wed, 06 Aug 2014)

  Changed paths:
    M ckanext/datastore/plugin.py

  Log Message:
  -----------
  [#1792] Small refactoring on the FTS where clause creation

It was easy to miss that we were creating a list with one element.

  Commit: e183eba495cfee6fa491c381ff34356902e5333d
      https://github.com/ckan/ckan/commit/e183eba495cfee6fa491c381ff34356902e5333d
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-08-06 (Wed, 06 Aug 2014)

  Changed paths:
    M ckan/public/base/javascript/view-filters.js
    M ckan/public/base/test/spec/view-filters.spec.js

  Log Message:
  -----------
  [#1792] Accept filters with colons in their values

For example, "time:12:00" should be recognized as { "time": "12:00" }. I've
also changed the code to use .match() instead of .split() because of a bug in
IE8.

  Commit: 3e850ff05f0e9fa49e0d4b5c8d00dc352181262b
      https://github.com/ckan/ckan/commit/3e850ff05f0e9fa49e0d4b5c8d00dc352181262b
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-08-06 (Wed, 06 Aug 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/resource-view-filters-form.js
    M ckan/public/base/javascript/modules/resource-view-filters.js

  Log Message:
  -----------
  [#1792] Fix bug with select2 and non-textual filters

select2 requires that the "text" attribute on each autocomplete field is a
string, so we cast to string before sending to it.

  Commit: b4a16d53cfa8963dba4ceac4efd56742b1deb801
      https://github.com/ckan/ckan/commit/b4a16d53cfa8963dba4ceac4efd56742b1deb801
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-08-06 (Wed, 06 Aug 2014)

  Changed paths:
    M ckan/lib/helpers.py
    M ckanext/datastore/plugin.py
    M ckanext/datastore/tests/test_search.py

  Log Message:
  -----------
  [#1792] Enable FTS on non-textual fields

We need this because our filters' autocomplete use full-text searching. If we
want to allow autocomplete on all fields, we also need to allow FTS on all
fields.

  Commit: aa516301ec455b1d58841147ad3aee78838565ea
      https://github.com/ckan/ckan/commit/aa516301ec455b1d58841147ad3aee78838565ea
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-08-06 (Wed, 06 Aug 2014)

  Changed paths:
    M ckanext/datastore/db.py
    M ckanext/datastore/tests/test_create.py
    M ckanext/datastore/tests/test_db.py

  Log Message:
  -----------
  [#1792] Create FTS indexes on fields textual and numeric fields

Unfortunately we couldn't create indexes on other field types as well because I
wasn't able to cast them to text in PostgreSQL using an IMMUTABLE function, so
it would work on the index creation.

Compare: https://github.com/ckan/ckan/compare/68fe1248370e...aa516301ec45