[ckan-changes] [ckan/ckan] 735967: Fixes broken test on master when celery is install...

GitHub noreply at github.com
Tue Dec 30 11:15:50 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/ckan/ckan
  Commit: 735967fda6da41f50803e9fb9bdf5d8f66e8b20e
      https://github.com/ckan/ckan/commit/735967fda6da41f50803e9fb9bdf5d8f66e8b20e
  Author: Ross Jones <ross at servercode.co.uk>
  Date:   2014-12-29 (Mon, 29 Dec 2014)

  Changed paths:
    M ckan/tests/logic/test_action.py

  Log Message:
  -----------
  Fixes broken test on master when celery is installed.

It appears that test_40_task_resource_status was never run if you do not
have celery installed, and so didn't show up on travis.  The fix was to
install celery, and to wrap the 'resource_status_show' with the correct
url as a string.  This threw up another problem in that the results from
the resource status check did not match what the tests assumed they did.

Either this has changed since it last caused a problem for someone, or
it has been hidden for a very long time by the SkipTest :(


  Commit: 9a1b8106ec6b98389e36f2260c8495d0cd4e7c2c
      https://github.com/ckan/ckan/commit/9a1b8106ec6b98389e36f2260c8495d0cd4e7c2c
  Author: David Read <david.read at hackneyworkshop.com>
  Date:   2014-12-30 (Tue, 30 Dec 2014)

  Changed paths:
    M ckan/tests/logic/test_action.py

  Log Message:
  -----------
  Merge pull request #2169 from ckan/fix-skipped-travis-test-for-help

Fixes broken test on master when celery is installed.


Compare: https://github.com/ckan/ckan/compare/52ab5be536d7...9a1b8106ec6b


More information about the ckan-changes mailing list