[ckan-changes] [ckan/ckan] ddd21a: [#1251] Embed view uses absolute URL in iframe

[GitHub]

  Branch: refs/heads/1251-resource-view
  Home:   https://github.com/ckan/ckan
  Commit: ddd21aa144a1f869558edc7f787826fa42d0620d
      https://github.com/ckan/ckan/commit/ddd21aa144a1f869558edc7f787826fa42d0620d
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-02-24 (Mon, 24 Feb 2014)

  Changed paths:
    M ckan/templates/package/snippets/resource_view.html

  Log Message:
  -----------
  [#1251] Embed view uses absolute URL in iframe


  Commit: 09b3d6252271ab9a0e3d28d42594464924e33856
      https://github.com/ckan/ckan/commit/09b3d6252271ab9a0e3d28d42594464924e33856
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-02-24 (Mon, 24 Feb 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/resource-view-embed.js

  Log Message:
  -----------
  [#1251] Adds frameBorder="0" to the resource view's embed iframe

It's not valid HTML5, but there're no better ways so far AFAIK.


  Commit: 37e9428a141dfcdaab12284cd9e9ec5d7b957f90
      https://github.com/ckan/ckan/commit/37e9428a141dfcdaab12284cd9e9ec5d7b957f90
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-02-24 (Mon, 24 Feb 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/resource-view-embed.js

  Log Message:
  -----------
  [#1251] Change embed code's help text

Copied from OpenSpending.


  Commit: de790b3b041cdf5f6a88df3e4b93bf454bf75780
      https://github.com/ckan/ckan/commit/de790b3b041cdf5f6a88df3e4b93bf454bf75780
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-02-24 (Mon, 24 Feb 2014)

  Changed paths:
    M ckan/public/base/css/main.css
    M ckan/public/base/javascript/modules/resource-view-embed.js
    M ckan/public/base/less/ckan.less
    A ckan/public/base/less/resource-view-embed.less

  Log Message:
  -----------
  [#1251] Embed code now has configurable width/height

I also moved the CSS to the right place: the .less files.


  Commit: 59d778269f6baa2157c6742492be2a3de1d80a70
      https://github.com/ckan/ckan/commit/59d778269f6baa2157c6742492be2a3de1d80a70
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-02-24 (Mon, 24 Feb 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/resource-view-embed.js

  Log Message:
  -----------
  [#1251] Don't try to center the modal div

The problem is that we were trying to get the element's height when it was
still hidden (display: none). This always return 0px.

There're a few hacks, or I could've moved the div when it was actually shown,
but I didn't feel it was worth it. I don't think it's that bad to have it show
at the top of the page.


  Commit: 98eb2331a9e280d6033bffc780754703ff6a1afa
      https://github.com/ckan/ckan/commit/98eb2331a9e280d6033bffc780754703ff6a1afa
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-02-24 (Mon, 24 Feb 2014)

  Changed paths:
    M ckan/public/base/css/main.css
    M ckan/public/base/less/resource-view-embed.less

  Log Message:
  -----------
  [#1251] Style embed modal's width and height inputs


Compare: https://github.com/ckan/ckan/compare/e94b2b6489a2...98eb2331a9e2