[ckan-changes] [okfn/ckan] 558a38: [#1449] Fix extras deletion

GitHub noreply at github.com
Tue Jan 28 14:16:41 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/okfn/ckan
  Commit: 558a38cd90d350e731677b3cec8961e9d206cc63
      https://github.com/okfn/ckan/commit/558a38cd90d350e731677b3cec8961e9d206cc63
  Author: amercader <amercadero at gmail.com>
  Date:   2014-01-24 (Fri, 24 Jan 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/custom-fields.js

  Log Message:
  -----------
  [#1449] Fix extras deletion

The custom-fields module was actually disabling the fields when clicking
the delete extra cross button. This prevented the key and value from
being sent, which caused a validation error.
We now change only the class to make it look disabled, which should be
good enough.


  Commit: 55959f6d979b94c0082e65396f837258a64924e7
      https://github.com/okfn/ckan/commit/55959f6d979b94c0082e65396f837258a64924e7
  Author: amercader <amercadero at gmail.com>
  Date:   2014-01-24 (Fri, 24 Jan 2014)

  Changed paths:
    M ckan/public/base/test/spec/modules/custom-fields.spec.js

  Log Message:
  -----------
  [#1449] Remove unneeded tests


  Commit: da20b2c4fefdf3ce06571ac24da6c25fabf345fb
      https://github.com/okfn/ckan/commit/da20b2c4fefdf3ce06571ac24da6c25fabf345fb
  Author: amercader <amercadero at gmail.com>
  Date:   2014-01-27 (Mon, 27 Jan 2014)

  Changed paths:
    M ckan/lib/helpers.py
    M ckan/logic/validators.py
    R ckan/public/base/vendor/jquery.ui.widget.min.js
    M ckan/templates/package/snippets/package_basic_fields.html
    M ckanext/datapusher/logic/action.py
    M ckanext/textpreview/tests/test_preview.py

  Log Message:
  -----------
  Merge branch 'master' into 1449-cant-delete-extra


  Commit: 687491d637cd747ab9e158a3062814802c82f3e4
      https://github.com/okfn/ckan/commit/687491d637cd747ab9e158a3062814802c82f3e4
  Author: kindly <kindly at gmail.com>
  Date:   2014-01-28 (Tue, 28 Jan 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/custom-fields.js
    M ckan/public/base/test/spec/modules/custom-fields.spec.js

  Log Message:
  -----------
  Merge pull request #1449 from okfn/1449-cant-delete-extra

Can't delete extra


Compare: https://github.com/okfn/ckan/compare/ed063f144b91...687491d637cd


More information about the ckan-changes mailing list