[ckan-changes] [ckan/ckan] 987c09: Allow specifying user when creating a group using ...

Thu Jun 19 16:00:23 UTC 2014

  Branch: refs/heads/release-v2.2.1
  Home:   https://github.com/ckan/ckan
  Commit: 987c09054d3cfc4ed19ae62d7077968af77a10c7
      https://github.com/ckan/ckan/commit/987c09054d3cfc4ed19ae62d7077968af77a10c7
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M ckan/new_tests/factories.py

  Log Message:
  -----------
  Allow specifying user when creating a group using the factory

With this, we're able to create a group owned by a specific user.

  Commit: e8a34cee7b0fe9eaf29bad932fdafc7e6c1ceda9
      https://github.com/ckan/ckan/commit/e8a34cee7b0fe9eaf29bad932fdafc7e6c1ceda9
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M ckan/new_tests/helpers.py

  Log Message:
  -----------
  new_tests.helpers.call_auth now work for any auth type (update, create, ...)

  Commit: 9f80c0f318e149bd311c462d9b750edfdecf8d06
      https://github.com/ckan/ckan/commit/9f80c0f318e149bd311c462d9b750edfdecf8d06
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M ckan/logic/auth/create.py
    A ckan/new_tests/logic/action/test_create.py
    A ckan/new_tests/logic/auth/test_create.py
    M ckan/tests/logic/test_action.py
    M ckan/tests/logic/test_auth.py

  Log Message:
  -----------
  [#1505] Fix bug when non-sysadmins invited users to organizations

The problem was with the .user_invite() auth function. Instead of adding 'id'
to the data_dict, I was adding it to the context. Fixed now.

I've also changed it to require a data_dict, and a data_dict['group_id'] (as
they're required anyway).

While I'm at it, I rewrote the tests into the new testing style.

  Commit: 599463c87fd19a22de3e48db4bc30c4ea8d73caf
      https://github.com/ckan/ckan/commit/599463c87fd19a22de3e48db4bc30c4ea8d73caf
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M ckan/new_tests/factories.py
    M ckan/new_tests/logic/action/test_create.py
    M ckan/new_tests/logic/auth/test_create.py

  Log Message:
  -----------
  [#1505] PEP8

  Commit: 9c9481c31c2b08bac3cb4f41014ea16412ae4805
      https://github.com/ckan/ckan/commit/9c9481c31c2b08bac3cb4f41014ea16412ae4805
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M ckan/new_tests/helpers.py
    M ckan/new_tests/logic/auth/test_update.py

  Log Message:
  -----------
  new_tests.helpers.call_auth now uses logic.check_access

  Commit: c289662afeaab6a95c96117953675969d1a5abfb
      https://github.com/ckan/ckan/commit/c289662afeaab6a95c96117953675969d1a5abfb
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M ckan/new_tests/helpers.py
    M ckan/new_tests/logic/auth/test_update.py

  Log Message:
  -----------
  Instead of importing NotAuthorized in test helpers, do it on the test file

  Commit: 8c3040431ab7580e4d5bf1ead3ae172cf73fce0e
      https://github.com/ckan/ckan/commit/8c3040431ab7580e4d5bf1ead3ae172cf73fce0e
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M ckan/new_tests/logic/auth/test_update.py

  Log Message:
  -----------
  Change way to call nose's assert_raises, so it works on Python 2.6

  Commit: 1dc912e243094fbc731d05a428026e954185cf80
      https://github.com/ckan/ckan/commit/1dc912e243094fbc731d05a428026e954185cf80
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M ckan/new_tests/logic/action/test_create.py

  Log Message:
  -----------
  [#1505] Merge tests that verify that the user was invited and it is pending

This is a tiny compromise in readability (IMO) to make the tests a bit faster

  Commit: 893919b04b65c28f952829dada6bc036843d0022
      https://github.com/ckan/ckan/commit/893919b04b65c28f952829dada6bc036843d0022
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M ckan/new_tests/logic/auth/test_create.py

  Log Message:
  -----------
  [#1505] Test not only the method call, but also that we're returning the value

  Commit: ccd45c0bc8065a5580d66327553bb11327b14bb6
      https://github.com/ckan/ckan/commit/ccd45c0bc8065a5580d66327553bb11327b14bb6
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M ckan/new_tests/logic/auth/test_update.py

  Log Message:
  -----------
  [#1505] Test for actual True-ness, and not truthiness.

If we don't add the ```is True```, any truthy value works (i.e. 'string').

  Commit: b6dd902ad382f659db2d50e8711286ee6263bcf9
      https://github.com/ckan/ckan/commit/b6dd902ad382f659db2d50e8711286ee6263bcf9
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M ckan/new_tests/logic/auth/test_create.py

  Log Message:
  -----------
  [#1505] Fix tests on Python 2.6

  Commit: 61dc3a4197e559322e632ce61c7441d0f99b5fbd
      https://github.com/ckan/ckan/commit/61dc3a4197e559322e632ce61c7441d0f99b5fbd
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M ckan/new_tests/logic/auth/test_create.py

  Log Message:
  -----------
  [#1505] Remove assertions that group_member_create was called in the tests

If user_invite fails when group_member_create fails, and succeeds when
group_member_create succeeds, there's no need to assert that
group_member_create was actually called.

  Commit: a89b7297f1ee98f3b13b14a192067ad5ece31465
      https://github.com/ckan/ckan/commit/a89b7297f1ee98f3b13b14a192067ad5ece31465
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M ckan/new_tests/factories.py

  Log Message:
  -----------
  [#1505] Instead of accessing and then deleting an attribute, simply pop() it.

  Commit: 549cf8359557da481080bc5318fe57b7fca26e2b
      https://github.com/ckan/ckan/commit/549cf8359557da481080bc5318fe57b7fca26e2b
  Author: nigelb <nigel.babu at okfn.org>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    A ckan/public/base/vendor/select2/.gitignore
    A ckan/public/base/vendor/select2/LICENSE
    M ckan/public/base/vendor/select2/README.md
    A ckan/public/base/vendor/select2/bower.json
    A ckan/public/base/vendor/select2/component.json
    A ckan/public/base/vendor/select2/composer.json
    A ckan/public/base/vendor/select2/package.json
    A ckan/public/base/vendor/select2/release.sh
    A ckan/public/base/vendor/select2/select2-bootstrap.css
    M ckan/public/base/vendor/select2/select2.css
    A ckan/public/base/vendor/select2/select2.jquery.json
    M ckan/public/base/vendor/select2/select2.js
    M ckan/public/base/vendor/select2/select2.min.js
    A ckan/public/base/vendor/select2/select2_locale_ar.js
    A ckan/public/base/vendor/select2/select2_locale_bg.js
    A ckan/public/base/vendor/select2/select2_locale_ca.js
    A ckan/public/base/vendor/select2/select2_locale_cs.js
    A ckan/public/base/vendor/select2/select2_locale_da.js
    A ckan/public/base/vendor/select2/select2_locale_de.js
    A ckan/public/base/vendor/select2/select2_locale_el.js
    A ckan/public/base/vendor/select2/select2_locale_en.js.template
    A ckan/public/base/vendor/select2/select2_locale_es.js
    A ckan/public/base/vendor/select2/select2_locale_et.js
    A ckan/public/base/vendor/select2/select2_locale_eu.js
    A ckan/public/base/vendor/select2/select2_locale_fa.js
    A ckan/public/base/vendor/select2/select2_locale_fi.js
    A ckan/public/base/vendor/select2/select2_locale_fr.js
    A ckan/public/base/vendor/select2/select2_locale_gl.js
    A ckan/public/base/vendor/select2/select2_locale_he.js
    A ckan/public/base/vendor/select2/select2_locale_hr.js
    A ckan/public/base/vendor/select2/select2_locale_hu.js
    A ckan/public/base/vendor/select2/select2_locale_id.js
    A ckan/public/base/vendor/select2/select2_locale_is.js
    A ckan/public/base/vendor/select2/select2_locale_it.js
    A ckan/public/base/vendor/select2/select2_locale_ja.js
    A ckan/public/base/vendor/select2/select2_locale_ka.js
    A ckan/public/base/vendor/select2/select2_locale_ko.js
    A ckan/public/base/vendor/select2/select2_locale_lt.js
    A ckan/public/base/vendor/select2/select2_locale_lv.js
    A ckan/public/base/vendor/select2/select2_locale_mk.js
    A ckan/public/base/vendor/select2/select2_locale_ms.js
    A ckan/public/base/vendor/select2/select2_locale_nl.js
    A ckan/public/base/vendor/select2/select2_locale_no.js
    A ckan/public/base/vendor/select2/select2_locale_pl.js
    A ckan/public/base/vendor/select2/select2_locale_pt-BR.js
    A ckan/public/base/vendor/select2/select2_locale_pt-PT.js
    A ckan/public/base/vendor/select2/select2_locale_ro.js
    A ckan/public/base/vendor/select2/select2_locale_rs.js
    A ckan/public/base/vendor/select2/select2_locale_ru.js
    A ckan/public/base/vendor/select2/select2_locale_sk.js
    A ckan/public/base/vendor/select2/select2_locale_sv.js
    A ckan/public/base/vendor/select2/select2_locale_th.js
    A ckan/public/base/vendor/select2/select2_locale_tr.js
    A ckan/public/base/vendor/select2/select2_locale_uk.js
    A ckan/public/base/vendor/select2/select2_locale_vi.js
    A ckan/public/base/vendor/select2/select2_locale_zh-CN.js
    A ckan/public/base/vendor/select2/select2_locale_zh-TW.js

  Log Message:
  -----------
  [#1512] Upgrade select2

This fixes the issues we had with tag autocomplete.

Conflicts:
	ckan/public/base/vendor/select2/select2.css
	ckan/public/base/vendor/select2/select2.js
	ckan/public/base/vendor/select2/select2.min.js

  Commit: ed70771951645ec09eff7bb29b0e4a2691f0d69f
      https://github.com/ckan/ckan/commit/ed70771951645ec09eff7bb29b0e4a2691f0d69f
  Author: amercader <amercadero at gmail.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M ckan/controllers/user.py
    M ckan/lib/helpers.py
    M ckan/logic/action/get.py
    M ckan/templates/user/snippets/followee_dropdown.html

  Log Message:
  -----------
  [#1519] Fix organization activity filter in dashboard

The old implementation had the same type for orgs and groups and when an
org was selected a 404 was returned because group_show was called.

I didn't go all the way down separating both, ie group_followee list
still returns both groups and orgs.

Conflicts:
	ckan/logic/action/get.py

  Commit: 98a6bf94eb4dfe0e87250b8cb8b81d7f6414875c
      https://github.com/ckan/ckan/commit/98a6bf94eb4dfe0e87250b8cb8b81d7f6414875c
  Author: amercader <amercadero at gmail.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M ckan/logic/action/get.py
    M ckan/logic/auth/get.py

  Log Message:
  -----------
  [#1519] Separate group / org follow actions

  Commit: e3d8f1c9aa33d591690c2783682ffd06b2015abe
      https://github.com/ckan/ckan/commit/e3d8f1c9aa33d591690c2783682ffd06b2015abe
  Author: amercader <amercadero at gmail.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M ckan/tests/test_coding_standards.py

  Log Message:
  -----------
  [#1519] Fix test

  Commit: 44472641b7f164a62ad414e93aa5b641a18c5a52
      https://github.com/ckan/ckan/commit/44472641b7f164a62ad414e93aa5b641a18c5a52
  Author: kindly <kindly at gmail.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M ckan/controllers/package.py

  Log Message:
  -----------
  [#1534] if mimetype is none then fall back to provided mimetype

  Commit: 56f30159be3f5193c289abc6e0420f25792a0a48
      https://github.com/ckan/ckan/commit/56f30159be3f5193c289abc6e0420f25792a0a48
  Author: RouxRC <b.ooghe at gmail.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M ckan/controllers/revision.py

  Log Message:
  -----------
  Add missing controller to fix broken rss links

Compare: https://github.com/ckan/ckan/compare/cb0674c28cb1...56f30159be3f