[ckan-changes] [ckan/ckan] 0d71de: [#1792] Styling filters

Fri Jun 27 00:10:30 UTC 2014

  Branch: refs/heads/1792-filterable-resource-views
  Home:   https://github.com/ckan/ckan
  Commit: 0d71de08fb0b16356d6e49e5df23cfdafdf71be0
      https://github.com/ckan/ckan/commit/0d71de08fb0b16356d6e49e5df23cfdafdf71be0
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-25 (Wed, 25 Jun 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/resource-view-filters.js
    M ckan/public/base/less/ckan.less
    A ckan/public/base/less/resource-view.less
    M ckan/templates/package/snippets/resource_view_filters.html

  Log Message:
  -----------
  [#1792] Styling filters

  Commit: 04422ef8695e7157c6318c42bc5d63fd98e49e70
      https://github.com/ckan/ckan/commit/04422ef8695e7157c6318c42bc5d63fd98e49e70
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-26 (Thu, 26 Jun 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/resource-view-filters.js

  Log Message:
  -----------
  [#1792] Allow clearing filters

Unfortunately, select2 require not only setting `allowClear`, but also having a
`placeholder`. As I don't want to have a `placeholder`, I've set it to `' '` as
a workaround.

  Commit: b87b9bb60d0216edad5833008388d9901bde1b0d
      https://github.com/ckan/ckan/commit/b87b9bb60d0216edad5833008388d9901bde1b0d
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-26 (Thu, 26 Jun 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/resource-view-filters.js
    M ckan/public/base/less/resource-view.less

  Log Message:
  -----------
  [#1792] Set the filters' width using CSS

  Commit: 3e264835eb8f451e3fbf486b219f4f0820048263
      https://github.com/ckan/ckan/commit/3e264835eb8f451e3fbf486b219f4f0820048263
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-26 (Thu, 26 Jun 2014)

  Changed paths:
    M ckan/templates/package/snippets/resource_views_list.html
    M ckan/templates/package/snippets/resource_views_list_item.html

  Log Message:
  -----------
  [#1792] Keep filters persistent when changing across views

The idea is simple. I changed the links for the other resource views of the
same resource to keep the `filters` query string, if it exist. I do this even
for resource views that aren't filterable, so even if you go from resource view
Foo, which is filterable, and set some filters, then move to resource view Bar
which isn't filterable, then to resource view Baz which is filterable, the
filters you've set in Foo are still set when you visit Baz.

  Commit: d764e11484455e7a72fbca382b523e99b33e5409
      https://github.com/ckan/ckan/commit/d764e11484455e7a72fbca382b523e99b33e5409
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-26 (Thu, 26 Jun 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/resource-view-filters.js

  Log Message:
  -----------
  [#1792] Add polyfill for Object.keys() and remove usage of Array.filter

We need this to make sure the code works on older browsers.

  Commit: 8e77d4433c0e3a95e79dcbbb595c3f6d4d7057e3
      https://github.com/ckan/ckan/commit/8e77d4433c0e3a95e79dcbbb595c3f6d4d7057e3
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-26 (Thu, 26 Jun 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/resource-view-filters.js

  Log Message:
  -----------
  [#1792] Minor refactorings

  Commit: 1f859646deedd1cab8041cac512be43ce9321698
      https://github.com/ckan/ckan/commit/1f859646deedd1cab8041cac512be43ce9321698
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-26 (Thu, 26 Jun 2014)

  Changed paths:
    M ckan/templates/package/snippets/resource_views_list_item.html

  Log Message:
  -----------
  [#1792] Don't set filters on links when there're no filters

  Commit: 09170d8ad7fec3bc58a2ce6f7cb1ec8e84ae5b22
      https://github.com/ckan/ckan/commit/09170d8ad7fec3bc58a2ce6f7cb1ec8e84ae5b22
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-26 (Thu, 26 Jun 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/resource-view-filters.js

  Log Message:
  -----------
  [#1792] Fix bug where filters weren't appearing

  Commit: 223e1dfaaac880162d6114575723dcc46df93134
      https://github.com/ckan/ckan/commit/223e1dfaaac880162d6114575723dcc46df93134
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-06-26 (Thu, 26 Jun 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/resource-view-filters.js

  Log Message:
  -----------
  [#1792] Fix bug where we were unable to remove filters

Instead of removing the filters, we were setting them to `undefined`.

Compare: https://github.com/ckan/ckan/compare/8b56c600516e...223e1dfaaac8