[ckan-changes] [ckan/ckan] 24b147: [#1793] Don't delete all cookies whose names start...

Fri Jun 27 16:22:55 UTC 2014

  Branch: refs/heads/master
  Home:   https://github.com/ckan/ckan
  Commit: 24b147ff355a469ba3fd8bd74f273b332365f018
      https://github.com/ckan/ckan/commit/24b147ff355a469ba3fd8bd74f273b332365f018
  Author: Sean Hammond <git at seanh.cc>
  Date:   2014-06-25 (Wed, 25 Jun 2014)

  Changed paths:
    M ckan/lib/base.py

  Log Message:
  -----------
  [#1793] Don't delete all cookies whose names start with "ckan"

Apparently in 2012 it was necessary (possibly only on demo.ckan.org) to
delete all cookies whose names start with "ckan".

I don't think CKAN sets any cookies today, except for the session
cookie, so this seems unnecessary now.

Deleting all cookies whose names start with "ckan" is likely to delete
cookies created by extensions that are called something like "ckanext-foo",
which is very confusing, especially because the header that deletes the
cookies comes in the /en request not in the first request for the page.

Since I don't know the specific names of the cookies this code was
intended to delete, I'm just removing the code and guessing it's no
longer needed.

  Commit: b8943a21c5c055fb6631abe690108fa64b8029d5
      https://github.com/ckan/ckan/commit/b8943a21c5c055fb6631abe690108fa64b8029d5
  Author: David Read <david.read at hackneyworkshop.com>
  Date:   2014-06-27 (Fri, 27 Jun 2014)

  Changed paths:
    M ckan/lib/base.py

  Log Message:
  -----------
  Merge pull request #1793 from ckan/1793-dont-delete-cookies

Don't delete all cookies whose names start with "ckan"

Compare: https://github.com/ckan/ckan/compare/947737b7355c...b8943a21c5c0