[ckan-changes] [ckan/ckan] e2f9e4: [#1251] Refactor ReclinePreview to not use global ...

Tue May 6 00:51:39 UTC 2014

  Branch: refs/heads/1251-resource-view
  Home:   https://github.com/ckan/ckan
  Commit: e2f9e4aa20d093f558abdafc161a70ac5123015f
      https://github.com/ckan/ckan/commit/e2f9e4aa20d093f558abdafc161a70ac5123015f
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-05-05 (Mon, 05 May 2014)

  Changed paths:
    M ckanext/reclinepreview/theme/public/preview_recline.js
    M ckanext/reclinepreview/theme/templates/recline_view.html

  Log Message:
  -----------
  [#1251] Refactor ReclinePreview to not use global JS variables

Everything our module needs should be passed to it using data-* attributes.
This allow us to add multiple modules on the same page, and they won't mess up
with each other.

  Commit: f3e74a251e828af21b2816315af4eac735bcc444
      https://github.com/ckan/ckan/commit/f3e74a251e828af21b2816315af4eac735bcc444
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-05-05 (Mon, 05 May 2014)

  Changed paths:
    M ckanext/reclinepreview/theme/public/preview_recline.js

  Log Message:
  -----------
  [#1251] Minor refactoring on preview_recline.js

As in JS the variable definitions are hoisted to the beginning of the function,
we were defining "state" twice, which makes JSHint complain.

  Commit: 59f0f99b527b5acab908c997319606d3e157f9b9
      https://github.com/ckan/ckan/commit/59f0f99b527b5acab908c997319606d3e157f9b9
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-05-05 (Mon, 05 May 2014)

  Changed paths:
    M ckanext/reclinepreview/theme/public/preview_recline.js
    M ckanext/reclinepreview/theme/templates/recline_view.html

  Log Message:
  -----------
  [#1251] Change #recline-controls to class, so we can have multiple on one page

  Commit: 69ab2e3933a69c00dedb4b1507587b74d39cf964
      https://github.com/ckan/ckan/commit/69ab2e3933a69c00dedb4b1507587b74d39cf964
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-05-05 (Mon, 05 May 2014)

  Changed paths:
    M ckanext/reclinepreview/theme/public/preview_recline.js
    M ckanext/reclinepreview/theme/templates/recline_view.html

  Log Message:
  -----------
  [#1251] Move recline controls' widget to inside the module

A module should be self-contained, so we're able to have many in the same page.

Compare: https://github.com/ckan/ckan/compare/8ddcb61b0584...69ab2e3933a6