[ckan-changes] [ckan/ckan] 03d8d7: [#1550] Show the file name when uploading a resour...

GitHub noreply at github.com
Wed May 7 05:37:54 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/ckan/ckan
  Commit: 03d8d70dd2262bc53f84cbce0551f57a1616a15c
      https://github.com/ckan/ckan/commit/03d8d70dd2262bc53f84cbce0551f57a1616a15c
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-04-01 (Tue, 01 Apr 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/image-upload.js
    M ckan/public/base/less/forms.less

  Log Message:
  -----------
  [#1550] Show the file name when uploading a resource

Hiding it is bad makes it hard for the user to check its URL (although it makes
it more difficult for her to change it by mistake).

When you first upload, some browsers have a safety feature to not disclosing
the file's full path to the page so, instead of getting something like:

```
/home/vitor/datasets/unemployment.csv
```

You get:

```
C:\fakepath\unemployment.csv
```

To avoid bothering the user showing this ```fakepath``` stuff, we remove it,
showing just the file name. This only happens when uploading a file. The next
time you edit the resource, we'll have the entire URL, so that'll be shown
instead.


  Commit: 375264e28404e998f35dcf1aa878d9dd9edccdfc
      https://github.com/ckan/ckan/commit/375264e28404e998f35dcf1aa878d9dd9edccdfc
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-04-01 (Tue, 01 Apr 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/image-upload.js

  Log Message:
  -----------
  [#1550] Merge the merge and attached states into filled state

They're the same now.


  Commit: 9ab79cf7c85d6877ee8f410ab2ed832908ba1f67
      https://github.com/ckan/ckan/commit/9ab79cf7c85d6877ee8f410ab2ed832908ba1f67
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-04-01 (Tue, 01 Apr 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/image-upload.js

  Log Message:
  -----------
  [#1550] Refactor the state machine into a simpler architecture

We just have two states now, so we can simplify stuff.


  Commit: 5137d6e06693d0fbe954705ef608c5877d992d5e
      https://github.com/ckan/ckan/commit/5137d6e06693d0fbe954705ef608c5877d992d5e
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-04-07 (Mon, 07 Apr 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/image-upload.js

  Log Message:
  -----------
  [#1550] Initialize correctly the status of the image-upload


  Commit: 1d43bc7bbce3b16d6f2de580adfce54ccf6ce97d
      https://github.com/ckan/ckan/commit/1d43bc7bbce3b16d6f2de580adfce54ccf6ce97d
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-04-07 (Mon, 07 Apr 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/image-upload.js

  Log Message:
  -----------
  [#1550] Remove "Remove" button, as we now only use the "X" at the input


  Commit: 567a0dbecb58b4321b37d184da3efa73ca123bf7
      https://github.com/ckan/ckan/commit/567a0dbecb58b4321b37d184da3efa73ca123bf7
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-04-15 (Tue, 15 Apr 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/image-upload.js

  Log Message:
  -----------
  [#1550] Disable URL field when uploading image


  Commit: e70b9c352c68d07e15015ddb132d2c8c01edfeb3
      https://github.com/ckan/ckan/commit/e70b9c352c68d07e15015ddb132d2c8c01edfeb3
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-04-15 (Tue, 15 Apr 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/image-upload.js

  Log Message:
  -----------
  [#1550] Remove unused "template" option

As far as I could see, this was never used. Maybe the structure of this code
came from copy/pasting from somewhere else where it made sense, and it was left
by mistake.


  Commit: e9e3d818174c18cca11a80c25f0b86aef0ceaf9b
      https://github.com/ckan/ckan/commit/e9e3d818174c18cca11a80c25f0b86aef0ceaf9b
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-04-24 (Thu, 24 Apr 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/image-upload.js

  Log Message:
  -----------
  [#1550] Disable URL input if it belongs to an uploaded file


  Commit: 0988eb6a84fff39be1f17c0750a5a4c3ee3ed5ed
      https://github.com/ckan/ckan/commit/0988eb6a84fff39be1f17c0750a5a4c3ee3ed5ed
  Author: Nigel Babu <nigelbabu at gmail.com>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M ckan/public/base/javascript/modules/image-upload.js
    M ckan/public/base/less/forms.less

  Log Message:
  -----------
  Merge pull request #1550 from ckan/1550-what-file-did-i-upload

[#1550] Show uploaded filename


Compare: https://github.com/ckan/ckan/compare/55cdfe4a0477...0988eb6a84ff


More information about the ckan-changes mailing list