[ckan-changes] [ckan/ckan] 860a55: [#1725] Remove useless code

Thu May 29 01:16:08 UTC 2014

  Branch: refs/heads/1725-extend-datastore
  Home:   https://github.com/ckan/ckan
  Commit: 860a557a50491d51c6935ba1187394df82f2fd7e
      https://github.com/ckan/ckan/commit/860a557a50491d51c6935ba1187394df82f2fd7e
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-05-28 (Wed, 28 May 2014)

  Changed paths:
    M ckanext/datastore/db.py

  Log Message:
  -----------
  [#1725] Remove useless code

This was moved to the Datastore plugin, so there's no need to be here anymore.

  Commit: 256e80d6871ed6c6df04f4a0829d5f3e65d4ce37
      https://github.com/ckan/ckan/commit/256e80d6871ed6c6df04f4a0829d5f3e65d4ce37
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-05-28 (Wed, 28 May 2014)

  Changed paths:
    M ckanext/datastore/db.py
    M ckanext/datastore/tests/test_delete.py
    M ckanext/datastore/tests/test_search.py

  Log Message:
  -----------
  [#1725] Add test to guarantee that the filters received are in a dict

  Commit: 1e29f22af5ad1bf22bdad8b1b5209083aa1355db
      https://github.com/ckan/ckan/commit/1e29f22af5ad1bf22bdad8b1b5209083aa1355db
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-05-28 (Wed, 28 May 2014)

  Changed paths:
    M ckanext/datastore/tests/test_interface.py

  Log Message:
  -----------
  [#1725] Add tests asserting that the IDataStore.where() works for delete

It should be used both on datastore_create and datastore_delete.

  Commit: 059a24b97427706b505af50ee681f469a4c5fce2
      https://github.com/ckan/ckan/commit/059a24b97427706b505af50ee681f469a4c5fce2
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-05-28 (Wed, 28 May 2014)

  Changed paths:
    M ckanext/datastore/db.py
    M ckanext/datastore/interfaces.py
    M ckanext/datastore/plugin.py
    M ckanext/datastore/tests/sample_datastore_plugin.py
    M ckanext/datastore/tests/test_interface.py

  Log Message:
  -----------
  [#1725] Add delete_data() extension point and remove where()

@amercader and I agreed that, even though in most cases both select_data() and
delete_data() would create the WHERE clauses with the same code, it's easier to
understand the WHERE being created inside each one of those, not on a separate
where() extension point.

  Commit: d884b6d896f8076d7223414640775807e6d95eaf
      https://github.com/ckan/ckan/commit/d884b6d896f8076d7223414640775807e6d95eaf
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-05-28 (Wed, 28 May 2014)

  Changed paths:
    M ckanext/datastore/db.py
    M ckanext/datastore/interfaces.py
    M ckanext/datastore/plugin.py
    M ckanext/datastore/tests/sample_datastore_plugin.py

  Log Message:
  -----------
  [#1725] Rename IDataStore -> IDatastore

This makes it consistent with the plugin name (DatastorePlugin).

  Commit: 6ba586860d4a5bb86980e7e789789ed2c3dfa4f1
      https://github.com/ckan/ckan/commit/6ba586860d4a5bb86980e7e789789ed2c3dfa4f1
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-05-28 (Wed, 28 May 2014)

  Changed paths:
    M ckanext/datastore/db.py
    M ckanext/datastore/interfaces.py
    M ckanext/datastore/plugin.py
    M ckanext/datastore/tests/sample_datastore_plugin.py

  Log Message:
  -----------
  [#1725] Reorder arguments on search_data() and delete_data()

This keeps our current 3 extensions points, search_data(), delete_data(), and
validate_query(), with the same initial 3 arguments, in the same order. The
interface becomes a bit more consistent.

Compare: https://github.com/ckan/ckan/compare/513e94d6f3ce...6ba586860d4a