[ckan-changes] [ckan/ckan] cc7e91: [#1697] Don't break PEP8 tests if test files have ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/ckan/ckan
  Commit: cc7e91743d179964dcf271875bc10db64b6fc0c9
      https://github.com/ckan/ckan/commit/cc7e91743d179964dcf271875bc10db64b6fc0c9
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-05-01 (Thu, 01 May 2014)

  Changed paths:
    M ckan/tests/test_coding_standards.py

  Log Message:
  -----------
  [#1697] Don't break PEP8 tests if test files have lines >79 chars

According to naming test methods [1] in our testing coding standards, we should
make the test names clear "...even if it means your method name gets really
long, since we don’t write code that calls our test methods there’s no
advantage to having short test method names".  Given this, we shouldn't
validate E501 on our test suite.

[1] https://ckan.readthedocs.org/en/latest/contributing/testing.html#naming-test-methods


  Commit: 56857f20c819c5ac759b507cfcc312ef6eaccd4e
      https://github.com/ckan/ckan/commit/56857f20c819c5ac759b507cfcc312ef6eaccd4e
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-05-01 (Thu, 01 May 2014)

  Changed paths:
    M ckan/tests/test_coding_standards.py

  Log Message:
  -----------
  [#1697] Revert blacklisted files removed in cc7e917

They still fail even without validating E501.


  Commit: 8329733c471f48214617b47112c5069e2e8b4247
      https://github.com/ckan/ckan/commit/8329733c471f48214617b47112c5069e2e8b4247
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-05-01 (Thu, 01 May 2014)

  Changed paths:
    M ckan/tests/test_coding_standards.py

  Log Message:
  -----------
  [#1697] Unblacklist test files that are passing PEP8


  Commit: bcc8ea5836ca2ef8e57f964747645d70bed5a046
      https://github.com/ckan/ckan/commit/bcc8ea5836ca2ef8e57f964747645d70bed5a046
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-05-01 (Thu, 01 May 2014)

  Changed paths:
    M ckan/new_tests/logic/action/test_update.py
    M ckan/new_tests/logic/test_validators.py
    M ckan/tests/functional/test_tracking.py

  Log Message:
  -----------
  [#1697] Fix minor PEP8 issues


  Commit: 5e731d59ed0a83fb76f72c4f7e25cd8d38db32c3
      https://github.com/ckan/ckan/commit/5e731d59ed0a83fb76f72c4f7e25cd8d38db32c3
  Author: Vitor Baptista <vitor at vitorbaptista.com>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M ckan/tests/test_coding_standards.py

  Log Message:
  -----------
  [#1697] Add comment explaining why we're ignoring E501 on tests


  Commit: 5f4d52872111bee7143086e7daa2df7d02db564d
      https://github.com/ckan/ckan/commit/5f4d52872111bee7143086e7daa2df7d02db564d
  Author: Ian Ward <ian at excess.org>
  Date:   2014-05-28 (Wed, 28 May 2014)

  Changed paths:
    M ckan/new_tests/logic/action/test_update.py
    M ckan/new_tests/logic/test_validators.py
    M ckan/tests/functional/test_tracking.py
    M ckan/tests/test_coding_standards.py

  Log Message:
  -----------
  Merge branch '1697-dont-validate-e501-on-tests'


Compare: https://github.com/ckan/ckan/compare/e24f6a07f145...5f4d52872111