[ckan-changes] [ckan/ckan] 895306: [#1852] Remove unused code and add docstrings in d...

[GitHub]

  Branch: refs/heads/1852-default-resource-views
  Home:   https://github.com/ckan/ckan
  Commit: 895306991576ed0ad0a0d5db3fd48ad98512a0df
      https://github.com/ckan/ckan/commit/895306991576ed0ad0a0d5db3fd48ad98512a0df
  Author: amercader <amercadero at gmail.com>
  Date:   2014-11-04 (Tue, 04 Nov 2014)

  Changed paths:
    M ckan/lib/datapreview.py
    M doc/maintaining/configuration.rst

  Log Message:
  -----------
  [#1852] Remove unused code and add docstrings in datapreview


  Commit: b5e7085b83027f2383e6d48012ebb66b10a1e1e3
      https://github.com/ckan/ckan/commit/b5e7085b83027f2383e6d48012ebb66b10a1e1e3
  Author: amercader <amercadero at gmail.com>
  Date:   2014-11-04 (Tue, 04 Nov 2014)

  Changed paths:
    M ckan/lib/datapreview.py
    A ckan/new_tests/lib/test_datapreview.py
    R ckan/tests/lib/test_datapreview.py
    M doc/maintaining/configuration.rst
    M setup.py

  Log Message:
  -----------
  [#1852] Add a function to get default views on new resources

The default view types are defined via the `ckan.views.default_views`
configuration option. If this is not set (as opposed to empty, which means
no default views), the value of DEFAULT_RESOURCE_VIEW_TYPES is used to
look up the plugins.

If `get_datastore_views` is False, only the ones not requiring data to be in
the DataStore are returned, and if True, only the ones requiring it are.

To flag a view plugin as requiring the DataStore, it must have the
`requires_datastore` key set to True in the dict returned by its `info()`
method


  Commit: d1516e48594a80d63d167658f7dbf4b61b797b9f
      https://github.com/ckan/ckan/commit/d1516e48594a80d63d167658f7dbf4b61b797b9f
  Author: amercader <amercadero at gmail.com>
  Date:   2014-11-04 (Tue, 04 Nov 2014)

  Changed paths:
    M ckan/lib/datapreview.py
    M ckan/logic/action/create.py
    M ckan/logic/action/update.py
    M ckan/new_tests/lib/test_datapreview.py

  Log Message:
  -----------
  [#1852] Create default views on dataset creation and update

Rather than relying on system plugins implementing `after_update` and
`after_create` to create default views, we now call the necessary
functions in `datapreview` to create them depeding on the default views
configuration setting.

The resources on the dataset dict that need to be passed to this
function on `package_create` and `package_update` didn't originally have
the ids, as the commit hadn't take place yet. We now do a flush just
before passing the dicts and add the ids so they can be used to create
the resource views.

There is no need to specifically create the default views on
`resource_create` and `resource_update`, as these call `package_update`
anyway.


  Commit: 337d5df54b63557e446d623c814a4b6a917bef9e
      https://github.com/ckan/ckan/commit/337d5df54b63557e446d623c814a4b6a917bef9e
  Author: amercader <amercadero at gmail.com>
  Date:   2014-11-04 (Tue, 04 Nov 2014)

  Changed paths:
    M ckanext/imageview/plugin.py
    M ckanext/webpageview/plugin.py
    M setup.py

  Log Message:
  -----------
  [#1852] Update image and web view plugins

Refactor them to work under the new default views behaviour. Basically
remove all `IPackageController` stuff and move the logic to `can_view`
for deciding if a view should be created.


  Commit: d9bf703b4add9fc4d47fb038631166b84d7446b3
      https://github.com/ckan/ckan/commit/d9bf703b4add9fc4d47fb038631166b84d7446b3
  Author: amercader <amercadero at gmail.com>
  Date:   2014-11-04 (Tue, 04 Nov 2014)

  Changed paths:
    M ckanext/imageview/theme/templates/image_view.html

  Log Message:
  -----------
  [#1852] No need to proxy images when used on a img tag


Compare: https://github.com/ckan/ckan/compare/895306991576^...d9bf703b4add