[ckan-changes] [ckan/ckan] 698833: [#2037] Make resource_create auth work against pac...

GitHub noreply at github.com
Wed Nov 12 13:24:23 UTC 2014


  Branch: refs/heads/2037-fix-resource-create-auth-2
  Home:   https://github.com/ckan/ckan
  Commit: 69883390a99590d5ef0305a0faf527ab24958c47
      https://github.com/ckan/ckan/commit/69883390a99590d5ef0305a0faf527ab24958c47
  Author: amercader <amercadero at gmail.com>
  Date:   2014-11-12 (Wed, 12 Nov 2014)

  Changed paths:
    M ckan/logic/auth/create.py
    M ckan/new_tests/logic/auth/test_create.py

  Log Message:
  -----------
  [#2037] Make resource_create auth work against package_update

Right now it was deferring to package_create, which doesn't make much
sense. Basically if you can update this particular dataset, you should
be able to add a resource to it. Added auth tests.

Also fixed the authorization for resource views creation. This is being
fully tested on #1852


  Commit: cb474d0036855c1e91e55f6e04ee9750bca6747b
      https://github.com/ckan/ckan/commit/cb474d0036855c1e91e55f6e04ee9750bca6747b
  Author: amercader <amercadero at gmail.com>
  Date:   2014-11-12 (Wed, 12 Nov 2014)

  Changed paths:
    M ckan/logic/action/get.py

  Log Message:
  -----------
  [#2037] Fix logger call to allow warning on tests


  Commit: 8b051f54f1e749dbe2903199984af8b5b55981ee
      https://github.com/ckan/ckan/commit/8b051f54f1e749dbe2903199984af8b5b55981ee
  Author: amercader <amercadero at gmail.com>
  Date:   2014-11-12 (Wed, 12 Nov 2014)

  Changed paths:
    M ckan/new_tests/logic/auth/test_create.py

  Log Message:
  -----------
  [#2037] PEP8


  Commit: 424bd37b806ebf7eaf8cbd83cdc0575798921aff
      https://github.com/ckan/ckan/commit/424bd37b806ebf7eaf8cbd83cdc0575798921aff
  Author: amercader <amercadero at gmail.com>
  Date:   2014-11-12 (Wed, 12 Nov 2014)

  Changed paths:
    M ckan/logic/action/create.py
    M ckan/new_tests/logic/action/test_create.py

  Log Message:
  -----------
  [#2037] Don't remove package_id before resource_create auth check

I didn't find any good reason as to why it was being done, and it
prevents `resource_create` auth to check authorization against the
dataset.

Added action tests


Compare: https://github.com/ckan/ckan/compare/69883390a995^...424bd37b806e


More information about the ckan-changes mailing list