[ckan-changes] [ckan/ckan] 39132e: Ensure page parameters are valid.

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/ckan/ckan
  Commit: 39132e3a34c6c9e770ff2ff8525e42919dd67142
      https://github.com/ckan/ckan/commit/39132e3a34c6c9e770ff2ff8525e42919dd67142
  Author: Ross Jones <ross at servercode.co.uk>
  Date:   2014-11-20 (Thu, 20 Nov 2014)

  Changed paths:
    M ckan/controllers/feed.py
    M ckan/controllers/group.py
    M ckan/controllers/package.py
    M ckan/controllers/related.py
    M ckan/controllers/revision.py
    M ckan/controllers/tag.py
    M ckan/controllers/user.py
    M ckan/lib/alphabet_paginate.py
    M ckan/lib/base.py
    M ckan/tests/functional/test_group.py

  Log Message:
  -----------
  Ensure page parameters are valid.

Fixes #2042 by ensuring that:

- Invalid numbers aren't passed through to logic layer or paginator
- There is a default should an invalid number is passed. Numbers less
  than 1 will raise a 400.

Adds a _get_page_number() to the BaseController for re-use in all the
subclasses.


  Commit: 737c4bd2ddf4dd6e836ec3901d3c44844b14fd42
      https://github.com/ckan/ckan/commit/737c4bd2ddf4dd6e836ec3901d3c44844b14fd42
  Author: David Read <david.read at hackneyworkshop.com>
  Date:   2014-11-21 (Fri, 21 Nov 2014)

  Changed paths:
    A ckan/new_tests/controllers/test_feed.py
    M ckan/tests/functional/test_group.py

  Log Message:
  -----------
  [#2042] Move related tests to new_tests.


  Commit: acb3e7fc1463eb97fa06ff5929a62b8ecc4a8121
      https://github.com/ckan/ckan/commit/acb3e7fc1463eb97fa06ff5929a62b8ecc4a8121
  Author: David Read <david.read at hackneyworkshop.com>
  Date:   2014-11-21 (Fri, 21 Nov 2014)

  Changed paths:
    M ckan/new_tests/controllers/test_feed.py

  Log Message:
  -----------
  [#2042] Add extra test for completeness.


  Commit: c1f154e9b80472b66f81606340ade24e0ff777aa
      https://github.com/ckan/ckan/commit/c1f154e9b80472b66f81606340ade24e0ff777aa
  Author: David Read <david.read at hackneyworkshop.com>
  Date:   2014-11-24 (Mon, 24 Nov 2014)

  Changed paths:
    M ckan/controllers/feed.py
    M ckan/controllers/group.py
    M ckan/controllers/package.py
    M ckan/controllers/related.py
    M ckan/controllers/revision.py
    M ckan/controllers/tag.py
    M ckan/controllers/user.py
    M ckan/lib/alphabet_paginate.py
    M ckan/lib/base.py
    A ckan/new_tests/controllers/test_feed.py
    M ckan/tests/functional/test_group.py

  Log Message:
  -----------
  Merge pull request #2062 from ckan/2042-invalid-page-numbers

Ensure page parameters are valid.


Compare: https://github.com/ckan/ckan/compare/b955aff981e9...c1f154e9b804