[ckan-changes] [ckan/ckan] 4fd2ba: [#2554] Don't request all extra fields on group_li...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/ckan/ckan
  Commit: 4fd2baf4a2718eded60e560c2930505c00a1cd45
      https://github.com/ckan/ckan/commit/4fd2baf4a2718eded60e560c2930505c00a1cd45
  Author: amercader <amercadero at gmail.com>
  Date:   2015-08-19 (Wed, 19 Aug 2015)

  Changed paths:
    M ckan/logic/action/get.py
    M ckan/tests/logic/action/test_get.py

  Log Message:
  -----------
  [#2554] Don't request all extra fields on group_list

 #2214 replaced the organization/group_list call to group_list_dictize
by a organization/group_show call for each group, but didn't pass the
include_extras, include_users, etc params set to False, so now on each
call of this extra calls are performed by default on all groups.

Updated docstrings to include all params


  Commit: bbaab15883936ad80d93dd6e978f56a3b799a854
      https://github.com/ckan/ckan/commit/bbaab15883936ad80d93dd6e978f56a3b799a854
  Author: amercader <amercadero at gmail.com>
  Date:   2015-08-19 (Wed, 19 Aug 2015)

  Changed paths:
    M ckan/logic/action/get.py

  Log Message:
  -----------
  [#2554] Refactor group_list to only query necessary fields

Refactor organization/group_list to only query the necessary fields by default
(id, name, title, package_count) depending on the required sort. This massively
speeds up the default query without all_fields. In part this is because then we
no longer need to get all fields in all groups on all cases to do the sorting.
There is a minor drawback in that then we can't take private datasets into
account when sorting by number of datasets. The actual number displayed will
take private datasets into account, as this comes from the dictization, but
there might be inconsistencies (note that the "order by datasets option" is
not offered by default on the UI)


  Commit: 9be68909e4225d4593b558bf37d8b8c2cca66231
      https://github.com/ckan/ckan/commit/9be68909e4225d4593b558bf37d8b8c2cca66231
  Author: amercader <amercadero at gmail.com>
  Date:   2015-08-19 (Wed, 19 Aug 2015)

  Changed paths:
    M ckan/controllers/group.py
    M ckan/logic/action/get.py
    M ckan/tests/controllers/test_group.py
    M ckan/tests/logic/action/test_get.py

  Log Message:
  -----------
  [#2554] Add limit/offset support to group_list

So on the Organizations and Groups page we just dictize the groups on
the page (we need two calls to group_list in the controller, one
with all groups to account for the query, ordering, count, etc
and one with `all_fields` with just the ones to be displayed on
the listing).


  Commit: 8ededef46167e1853b12335e1b198918963e7210
      https://github.com/ckan/ckan/commit/8ededef46167e1853b12335e1b198918963e7210
  Author: amercader <amercadero at gmail.com>
  Date:   2015-08-19 (Wed, 19 Aug 2015)

  Changed paths:
    M ckan/controllers/home.py

  Log Message:
  -----------
  [#2554] Remove unused code from home controller

This was probably used on an old variant of the homepage, but it isn't
anymore. It removes the `c.groups` and `c.group_package_stuff` context
vars.


  Commit: da0177a242af360ca1de96ab3ff0c2976a361284
      https://github.com/ckan/ckan/commit/da0177a242af360ca1de96ab3ff0c2976a361284
  Author: amercader <amercadero at gmail.com>
  Date:   2015-08-25 (Tue, 25 Aug 2015)

  Changed paths:
    M ckan/controllers/home.py

  Log Message:
  -----------
  [#2554] Remove unused 'dirty' var


  Commit: eb30e116722fed03a9c4f9ada43945d8546fdc48
      https://github.com/ckan/ckan/commit/eb30e116722fed03a9c4f9ada43945d8546fdc48
  Author: amercader <amercadero at gmail.com>
  Date:   2015-08-25 (Tue, 25 Aug 2015)

  Changed paths:
    M ckan/tests/controllers/test_group.py

  Log Message:
  -----------
  [#2554] Fix ranges in group list tests


  Commit: 6b82fd47578293e736e66679ee0ff5de7684eca3
      https://github.com/ckan/ckan/commit/6b82fd47578293e736e66679ee0ff5de7684eca3
  Author: Brook Elgie <specialbrew at gmail.com>
  Date:   2015-08-25 (Tue, 25 Aug 2015)

  Changed paths:
    M ckan/controllers/group.py
    M ckan/controllers/home.py
    M ckan/logic/action/get.py
    M ckan/tests/controllers/test_group.py
    M ckan/tests/logic/action/test_get.py

  Log Message:
  -----------
  Merge branch 'ckan-2554-improve-group_list'


Compare: https://github.com/ckan/ckan/compare/942a824c85ec...6b82fd475782