[ckan-changes] [ckan/ckan] 156348: Stop reraising exceptions caused by notifications....

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/ckan/ckan
  Commit: 156348c1d11a5ceb556f593d4094074f912842a6
      https://github.com/ckan/ckan/commit/156348c1d11a5ceb556f593d4094074f912842a6
  Author: David Read <david.read at hackneyworkshop.com>
  Date:   2015-09-08 (Tue, 08 Sep 2015)

  Changed paths:
    M ckan/model/modification.py

  Log Message:
  -----------
  Stop reraising exceptions caused by notifications. They are secondary errors and should not prevent the change to the dataset occurring. e.g. I am harvesting some data, but because datapusher has an exception, every time the harvester tries to write it has an exception and fails. Admins should look at their logs for these exceptions, and the primary functions should carry on working.


  Commit: f19705d92da36d77988c7f6ebed6983d3bd0e043
      https://github.com/ckan/ckan/commit/f19705d92da36d77988c7f6ebed6983d3bd0e043
  Author: Ross Jones <ross at servercode.co.uk>
  Date:   2015-09-08 (Tue, 08 Sep 2015)

  Changed paths:
    M ckan/model/modification.py

  Log Message:
  -----------
  Make sure that SearchIndexErrors *are* raised

CKAN relies on the SearchIndexError being raised in the notify() call
of IDomainObjectNotification.  It still only logs most Exceptions, but
explicitly re-raises SearchIndexErrors as they are fatal to CKAN.


  Commit: b47721a068deaa6e6735855be157bf3fe953b680
      https://github.com/ckan/ckan/commit/b47721a068deaa6e6735855be157bf3fe953b680
  Author: Ross Jones <ross at mailbolt.com>
  Date:   2015-09-08 (Tue, 08 Sep 2015)

  Changed paths:
    M ckan/model/modification.py

  Log Message:
  -----------
  Merge pull request #2623 from ckan/notification-errors

Stop reraising exceptions caused by notifications.


Compare: https://github.com/ckan/ckan/compare/8f7caa50c61f...b47721a068de