[ckan-changes] [ckan/ckan] ae5216: Pad Groups and Org names from factories with zeros

GitHub noreply at github.com
Sat Jun 4 00:24:30 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/ckan/ckan
  Commit: ae52164e009df1863f1451a343041a94c3d0fc0d
      https://github.com/ckan/ckan/commit/ae52164e009df1863f1451a343041a94c3d0fc0d
  Author: Knut Hühne <knut at k-nut.eu>
  Date:   2016-05-27 (Fri, 27 May 2016)

  Changed paths:
    M ckan/tests/factories.py

  Log Message:
  -----------
  Pad Groups and Org names from factories with zeros

The test in ckan/tests/controllers/test_group.py would sometimes fail
when run in an unfortunate order. The
`test_page_thru_list_of_orgs_preserves_sort_order` and
`test_page_thru_list_of_groups_preserves_sort_order` would fail because
some organizations had already been created by oyher tests and the numbering would
start a 5 instead of 1. And because the sorting was done via strings (so
`Group 5` came after `Group 31` the test would fail. By always padding
them with zeros this should not happend anymore and make the tests more
stable (So it is `Group 05` now).


  Commit: a1b33a9787731af093036761e0584b121836c027
      https://github.com/ckan/ckan/commit/a1b33a9787731af093036761e0584b121836c027
  Author: Knut Hühne <knut at k-nut.eu>
  Date:   2016-06-01 (Wed, 01 Jun 2016)

  Changed paths:
    M ckan/tests/factories.py

  Log Message:
  -----------
  Pad all things that come from factories with zeros


  Commit: debc9fb032a97a24fe1f6c60fe0ad4e3e0f2a9e2
      https://github.com/ckan/ckan/commit/debc9fb032a97a24fe1f6c60fe0ad4e3e0f2a9e2
  Author: Ian Ward <ian at excess.org>
  Date:   2016-06-03 (Fri, 03 Jun 2016)

  Changed paths:
    M ckan/tests/factories.py

  Log Message:
  -----------
  Merge pull request #3066 from k-nut/padding-in-group-and-org-names

Pad object names from factories with zeros


Compare: https://github.com/ckan/ckan/compare/ccacc811ac40...debc9fb032a9


More information about the ckan-changes mailing list