[ckan-changes] [ckan/ckan] 92e9cf: [#3041] Raise HelperError when calling bad helper.

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/ckan/ckan
  Commit: 92e9cf36a5bba60d31df8996f9d8fe8334ff02df
      https://github.com/ckan/ckan/commit/92e9cf36a5bba60d31df8996f9d8fe8334ff02df
  Author: Brook Elgie <specialbrew at gmail.com>
  Date:   2016-05-20 (Fri, 20 May 2016)

  Changed paths:
    M ckan/lib/helpers.py
    A ckan/templates/tests/broken_helper_as_attribute.html
    A ckan/templates/tests/broken_helper_as_item.html
    A ckan/templates/tests/helper_as_attribute.html
    A ckan/templates/tests/helper_as_item.html
    M ckan/tests/lib/test_helpers.py
    M ckan/tests/plugins/test_toolkit.py
    M setup.py

  Log Message:
  -----------
  [#3041] Raise HelperError when calling bad helper.

Fixes exception handling introduced in #2908, by fixing call to super
class's __getitem__ and catching correct exception in
HelperAttributeDict.

Tests added for rendering helpers in templates, and using helpers from
toolkit.


  Commit: 56ae1bd8f5e205db7731a11e728f826ef3b051b4
      https://github.com/ckan/ckan/commit/56ae1bd8f5e205db7731a11e728f826ef3b051b4
  Author: Ian Ward <ian at excess.org>
  Date:   2016-05-24 (Tue, 24 May 2016)

  Changed paths:
    M ckan/lib/helpers.py
    A ckan/templates/tests/broken_helper_as_attribute.html
    A ckan/templates/tests/broken_helper_as_item.html
    A ckan/templates/tests/helper_as_attribute.html
    A ckan/templates/tests/helper_as_item.html
    M ckan/tests/lib/test_helpers.py
    M ckan/tests/plugins/test_toolkit.py
    M setup.py

  Log Message:
  -----------
  Merge pull request #3042 from ckan/3041-helpererror

Raise HelperError exception when calling non-existing helper


Compare: https://github.com/ckan/ckan/compare/027c09ada643...56ae1bd8f5e2