[ckan-changes] [ckan/ckan] 18d468: [#4393] Remove catch-all OPTIONS route

Tue Aug 14 14:23:45 UTC 2018

  Branch: refs/heads/4393-remove-old-routes
  Home:   https://github.com/ckan/ckan
  Commit: 18d468da604212d72a02ab76bb7776ee5396a0f5
      https://github.com/ckan/ckan/commit/18d468da604212d72a02ab76bb7776ee5396a0f5
  Author: amercader <amercadero at gmail.com>
  Date:   2018-08-14 (Tue, 14 Aug 2018)

  Changed paths:
    M ckan/config/routing.py

  Log Message:
  -----------
  [#4393] Remove catch-all OPTIONS route

It was added because Pylons was returning the body of the `GET` response
when requesting `OPTIONS`, so a catch-all route was added, pointing to a
view function that just returns an empty response.
Flask handles this automatically (supporting the `OPTIONS` request and
returning an empty response), and all significant routes have
been now migrated to Flask on master, so I think it's safe to remove it.

  Commit: c9c794b25b67e250df480d08c56132ab20ceee95
      https://github.com/ckan/ckan/commit/c9c794b25b67e250df480d08c56132ab20ceee95
  Author: amercader <amercadero at gmail.com>
  Date:   2018-08-14 (Tue, 14 Aug 2018)

  Changed paths:
    M ckan/config/routing.py
    R ckan/controllers/template.py

  Log Message:
  -----------
  [#4393] Remove old catch-all route to render arbitrary templates

It is unused, undocumented and not the safest sounding thing in the
world.

Compare: https://github.com/ckan/ckan/compare/18d468da6042^...c9c794b25b67
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.