[ckan-changes] [ckan/ckan] 457474: [#4031] Add names to organization routes so they c...

GitHub noreply at github.com
Sat Feb 24 02:57:41 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/ckan/ckan
  Commit: 45747407ad680a74921de654202dee3e95ad4d46
      https://github.com/ckan/ckan/commit/45747407ad680a74921de654202dee3e95ad4d46
  Author: amercader <amercadero at gmail.com>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M ckan/config/routing.py

  Log Message:
  -----------
  [#4031] Add names to organization routes so they can be referenced in templates


  Commit: e8f26b461c5e11bc36d2c233093f0c9f0d5cb801
      https://github.com/ckan/ckan/commit/e8f26b461c5e11bc36d2c233093f0c9f0d5cb801
  Author: amercader <amercadero at gmail.com>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M ckan/controllers/group.py

  Log Message:
  -----------
  [#4031] Pass group_type to plugins so they can choose what to do

For instance when rendering the form for a new group/org there is not
way of telling if it's a group, org or custom type. The existing method
for the plugin interface just accepts context and data_dict, so to
maintain backwards compatibility I'm adding the group_type to
data_dict['type'], which is consistent with what they would get on an
update operation.


  Commit: e397e4c0b5eba4e66812ed31aedaaae194f7eb82
      https://github.com/ckan/ckan/commit/e397e4c0b5eba4e66812ed31aedaaae194f7eb82
  Author: amercader <amercadero at gmail.com>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M ckan/controllers/organization.py

  Log Message:
  -----------
  [#4031] Remove _guess_group_type methods from org controller

It had "organization" hardcoded so it prevented custom organization
types to work properly. The parent implementation in the group
controller should work fine for orgs as well as it just uses the URL.


  Commit: 534b7b176d0eaca2f62f7aeae4bf983082b4f7fa
      https://github.com/ckan/ckan/commit/534b7b176d0eaca2f62f7aeae4bf983082b4f7fa
  Author: amercader <amercadero at gmail.com>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M ckan/controllers/group.py

  Log Message:
  -----------
  [#4031] Remove methods that prevented custom types URLs

These two methods had hardcoded calls to the group or org routes defined
in core, so custom types were ignored. Replace them with calls to
`redirect_to` or `url_for` that take the group type into account.


  Commit: a54c906c4dba0361160b74d6ff5e0e7d7580bfbc
      https://github.com/ckan/ckan/commit/a54c906c4dba0361160b74d6ff5e0e7d7580bfbc
  Author: amercader <amercadero at gmail.com>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M ckan/controllers/group.py

  Log Message:
  -----------
  [#4031] Improve search in group read and bulk page


  Commit: 0b8dc27ed53f30db49c2fcc9729c878b3ab41e8d
      https://github.com/ckan/ckan/commit/0b8dc27ed53f30db49c2fcc9729c878b3ab41e8d
  Author: amercader <amercadero at gmail.com>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M ckan/templates/group/edit_base.html
    M ckan/templates/group/index.html
    M ckan/templates/group/member_new.html
    M ckan/templates/group/members.html
    M ckan/templates/group/read_base.html
    M ckan/templates/organization/edit_base.html
    M ckan/templates/organization/index.html
    M ckan/templates/organization/member_new.html
    M ckan/templates/organization/members.html
    M ckan/templates/organization/read_base.html
    M ckan/templates/snippets/organization.html

  Log Message:
  -----------
  [#4031] Use group type when building URLs in templates

TODO bootstrap2 ?


  Commit: 38cdf6291e707e0ddbfcd952379b87703e35cf08
      https://github.com/ckan/ckan/commit/38cdf6291e707e0ddbfcd952379b87703e35cf08
  Author: amercader <amercadero at gmail.com>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M ckan/lib/plugins.py

  Log Message:
  -----------
  [#4031] Add missing routes in group plugins


  Commit: 7ac5546eeceb70d1f53b02d87a346442ae01b385
      https://github.com/ckan/ckan/commit/7ac5546eeceb70d1f53b02d87a346442ae01b385
  Author: amercader <amercadero at gmail.com>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M ckan/lib/plugins.py

  Log Message:
  -----------
  [#4031] Allow registering of fallback org plugins

Right now if an organization plugin implementing `IGroupForm` set
is_fallback to True, the plugin was added as the default *group* plugin,
not the organization one.


  Commit: 2abd5926abbd6b8ae92b1fef1ffdf5ee21ed37c6
      https://github.com/ckan/ckan/commit/2abd5926abbd6b8ae92b1fef1ffdf5ee21ed37c6
  Author: amercader <amercadero at gmail.com>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M ckan/config/routing.py

  Log Message:
  -----------
  [#4031] Add names to group routes as well


  Commit: 7e7e01a6c967a18c1e753ed401d6659463482b2d
      https://github.com/ckan/ckan/commit/7e7e01a6c967a18c1e753ed401d6659463482b2d
  Author: amercader <amercadero at gmail.com>
  Date:   2018-02-23 (Fri, 23 Feb 2018)

  Changed paths:
    M ckan/config/middleware/flask_app.py
    M ckan/controllers/group.py
    M ckan/controllers/package.py
    M ckan/lib/dictization/__init__.py
    M ckan/lib/dictization/model_save.py
    M ckan/lib/extract.py
    M ckan/lib/helpers.py
    M ckan/lib/jinja_extensions.py
    M ckan/lib/search/common.py
    M ckan/lib/search/query.py
    M ckan/logic/__init__.py
    M ckan/logic/action/get.py
    M ckan/logic/converters.py
    M ckan/migration/versions/001_add_existing_tables.py
    M ckan/model/types.py
    M ckan/plugins/core.py
    M ckan/templates/snippets/facet_list.html
    M ckan/tests/controllers/test_api.py
    M ckan/tests/controllers/test_group.py
    M ckan/tests/legacy/html_check.py
    M ckan/tests/logic/action/test_get.py
    M ckan/tests/logic/test_validators.py
    M ckanext/datastore/backend/postgres.py
    M ckanext/datastore/helpers.py
    M ckanext/datastore/logic/schema.py
    M ckanext/datastore/plugin.py
    M ckanext/datastore/templates/datastore/snippets/dictionary_form.html
    M ckanext/example_itranslation/tests/test_plugin.py
    M ckanext/multilingual/plugin.py
    M ckanext/stats/tests/test_stats_lib.py
    M contrib/docker/solr/Dockerfile
    M doc/contributing/documentation.rst
    M doc/contributing/test.rst
    M doc/maintaining/datastore.rst
    M doc/maintaining/installing/install-from-source.rst
    M doc/maintaining/upgrading/upgrade-source.rst
    M requirements.in
    M requirements.txt

  Log Message:
  -----------
  Merge branch 'master' into 4031-improve-igroupform-support


  Commit: b99b85092fd123b266fad93f391dc66ac274f514
      https://github.com/ckan/ckan/commit/b99b85092fd123b266fad93f391dc66ac274f514
  Author: amercader <amercadero at gmail.com>
  Date:   2018-02-23 (Fri, 23 Feb 2018)

  Changed paths:
    M ckan/templates-bs2/group/edit_base.html
    M ckan/templates-bs2/group/index.html
    M ckan/templates-bs2/group/member_new.html
    M ckan/templates-bs2/group/members.html
    M ckan/templates-bs2/group/read_base.html
    M ckan/templates-bs2/organization/edit_base.html
    M ckan/templates-bs2/organization/index.html
    M ckan/templates-bs2/organization/member_new.html
    M ckan/templates-bs2/organization/members.html
    M ckan/templates-bs2/organization/read_base.html
    M ckan/templates-bs2/snippets/organization.html

  Log Message:
  -----------
  [#4013] Update Bootstrap 2 templates to support custom group types


  Commit: a53b7f334e3cc3035684e4ccbb06d683b2fbe58d
      https://github.com/ckan/ckan/commit/a53b7f334e3cc3035684e4ccbb06d683b2fbe58d
  Author: Ian Ward <ian at excess.org>
  Date:   2018-02-23 (Fri, 23 Feb 2018)

  Changed paths:
    M ckan/config/routing.py
    M ckan/controllers/group.py
    M ckan/controllers/organization.py
    M ckan/lib/plugins.py
    M ckan/templates-bs2/group/edit_base.html
    M ckan/templates-bs2/group/index.html
    M ckan/templates-bs2/group/member_new.html
    M ckan/templates-bs2/group/members.html
    M ckan/templates-bs2/group/read_base.html
    M ckan/templates-bs2/organization/edit_base.html
    M ckan/templates-bs2/organization/index.html
    M ckan/templates-bs2/organization/member_new.html
    M ckan/templates-bs2/organization/members.html
    M ckan/templates-bs2/organization/read_base.html
    M ckan/templates-bs2/snippets/organization.html
    M ckan/templates/group/edit_base.html
    M ckan/templates/group/index.html
    M ckan/templates/group/member_new.html
    M ckan/templates/group/members.html
    M ckan/templates/group/read_base.html
    M ckan/templates/organization/edit_base.html
    M ckan/templates/organization/index.html
    M ckan/templates/organization/member_new.html
    M ckan/templates/organization/members.html
    M ckan/templates/organization/read_base.html
    M ckan/templates/snippets/organization.html

  Log Message:
  -----------
  Merge pull request #4032 from ckan/4031-improve-igroupform-support

[#4031] Improve IGroupForm support


Compare: https://github.com/ckan/ckan/compare/3251b50025e8...a53b7f334e3c


More information about the ckan-changes mailing list