[ckan-changes] [ckan/ckan] 357180: Travis CI: Add flake8 jobs on both Python 2.7 and ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/ckan/ckan
  Commit: 357180733c78ccce1c5d096db0d161559cd50e33
      https://github.com/ckan/ckan/commit/357180733c78ccce1c5d096db0d161559cd50e33
  Author: cclauss <cclauss at bluewin.ch>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  Travis CI: Add flake8 jobs on both Python 2.7 and 3.7

Run [flake8](https://gitlab.com/pycqa/flake8) __. --select=E901,E999,F821,F822,F823__ under both Python 2 and Python 3 to find syntax errors and undefined names.  This should help us catch Python incompatibilities in pull requests before they are reviewed.


This PR is an update to  #4227 which I closed because I thought that we could quickly move to Circle CI but that is blocked by #4335 and then #4345.

__E901,E999,F821,F822,F823__ are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc.  Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.
* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable `name` referenced before assignment
* E901: SyntaxError or IndentationError
* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree


  Commit: 9d7ead11a2842e9b0156f10e85de210c3d974f50
      https://github.com/ckan/ckan/commit/9d7ead11a2842e9b0156f10e85de210c3d974f50
  Author: cclauss <cclauss at bluewin.ch>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  Mark the tests in the Travis CI output with FLAKE8=true


  Commit: 6eda7c661ecf5aa7437d5c2c85360d2dfae8db40
      https://github.com/ckan/ckan/commit/6eda7c661ecf5aa7437d5c2c85360d2dfae8db40
  Author: cclauss <cclauss at bluewin.ch>
  Date:   2018-07-24 (Tue, 24 Jul 2018)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  Remove allow_failures for Python 3


  Commit: 4c46765a63966cbf078ad9d4f547b2412bcf27f5
      https://github.com/ckan/ckan/commit/4c46765a63966cbf078ad9d4f547b2412bcf27f5
  Author: Adrià Mercader <amercadero at gmail.com>
  Date:   2018-07-30 (Mon, 30 Jul 2018)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  Merge pull request #4363 from cclauss/patch-2

Travis CI: Add flake8 jobs on both Python 2.7 and 3.7


Compare: https://github.com/ckan/ckan/compare/f1a24c206c54...4c46765a6396
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.