[ckan-changes] [ckan/ckan] c2c8cb: Remove unused RatingsTestCase.test_entity_get()

Thu May 3 13:08:17 UTC 2018

  Branch: refs/heads/master
  Home:   https://github.com/ckan/ckan
  Commit: c2c8cb3e6d1d91a83dd6d1712bd08d78f9bab9d2
      https://github.com/ckan/ckan/commit/c2c8cb3e6d1d91a83dd6d1712bd08d78f9bab9d2
  Author: cclauss <cclauss at bluewin.ch>
  Date:   2018-05-03 (Thu, 03 May 2018)

  Changed paths:
    M ckan/tests/legacy/functional/api/model/test_ratings.py

  Log Message:
  -----------
  Remove unused RatingsTestCase.test_entity_get()

#4219 removed __RatingsTestCase.test_register_get()__
This PR removes __RatingsTestCase.test_entity_get()__

Fixes #3823    The first line of both legacy test case is __raise SkipTest('"Rating register get" functionality is not implemented')__ so this PR recommends removing both methods as discussed in #4211

### Proposed fixes:
* remove skipped legacy test case __RatingsTestCase.test_entity_get()__

### Features:

- [X] includes tests covering changes
- [ ] includes updated documentation
- [ ] includes user-visible changes
- [ ] includes API changes
- [X] includes bugfix for possible backport -- a flake8 undefined name

Please [X] all the boxes above that apply

Fixes: flake8 testing of https://github.com/ckan/ckan on Python 3.6.3

$ __flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics__
```
./ckan/tests/legacy/functional/api/model/test_ratings.py:50:27: F821 undefined name 'rating_opts'
  assert_equal(res, rating_opts['rating'])
                    ^
1     F821 undefined name 'rating_opts'
1
```


  Commit: fa3462e374f80fece9df702bc63d9b645b430173
      https://github.com/ckan/ckan/commit/fa3462e374f80fece9df702bc63d9b645b430173
  Author: Adrià Mercader <amercadero at gmail.com>
  Date:   2018-05-03 (Thu, 03 May 2018)

  Changed paths:
    M ckan/tests/legacy/functional/api/model/test_ratings.py

  Log Message:
  -----------
  Merge pull request #4221 from cclauss/patch-3

Remove unused RatingsTestCase.test_entity_get()


Compare: https://github.com/ckan/ckan/compare/a5c708eee3d4...fa3462e374f8
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.