[ckan-changes] [ckan/ckan] d2409b: Upgrade pycodestyle and requests

[David Read]

  Branch: refs/heads/pycodestyle-upgrade
  Home:   https://github.com/ckan/ckan
  Commit: d2409bd719c52dc38222a8e03a3ce94d8530d1cf
      https://github.com/ckan/ckan/commit/d2409bd719c52dc38222a8e03a3ce94d8530d1cf
  Author: David Read <david.read at hackneyworkshop.com>
  Date:   2019-04-13 (Sat, 13 Apr 2019)

  Changed paths:
    M ckan/cli/search_index.py
    M ckan/cli/translation.py
    M ckan/config/install.py
    M ckan/config/middleware/flask_app.py
    M ckan/config/middleware/pylons_app.py
    M ckan/controllers/api.py
    M ckan/controllers/group.py
    M ckan/controllers/package.py
    M ckan/controllers/util.py
    M ckan/i18n/check_po_files.py
    M ckan/lib/datapreview.py
    M ckan/lib/helpers.py
    M ckan/lib/mailer.py
    M ckan/lib/munge.py
    M ckan/logic/__init__.py
    M ckan/logic/action/create.py
    M ckan/logic/action/patch.py
    M ckan/migration/versions/081_set_datastore_active.py
    M ckan/model/revision.py
    M ckan/tests/controllers/test_api.py
    M ckan/tests/helpers.py
    M ckan/tests/legacy/test_coding_standards.py
    M ckan/tests/logic/action/test_create.py
    M ckan/views/group.py
    M ckan/views/home.py
    M ckanext/datastore/backend/postgres.py
    M ckanext/datastore/controller.py
    M ckanext/datatablesview/controller.py
    M ckanext/example_idatasetform/plugin_v4.py
    M ckanext/example_idatasetform/tests/test_example_idatasetform.py
    M ckanext/example_ivalidators/plugin.py
    M ckanext/imageview/plugin.py
    M ckanext/resourceproxy/controller.py
    M dev-requirements.txt
    M requirements.in
    M requirements.txt

  Log Message:
  -----------
  Upgrade pycodestyle and requests

* Newer pycodestyle requires this newer requests version
  (See
https://stackoverflow.com/questions/44927351/importerror-cannot-import-name-dependencywarning
)
* A whole bunch of new PEP8 errors and warnings come with the new
pycodestyle version, requiring changes in the main code. Feels
good to iron out some of these oddities though.
* Bit unsure if the regex in ckan/cli/translation.py is right to start
with. Not sure this CLI command is used though.