[ckan-changes] [ckan/ckan] 5df316: Retrieving the package after plugins run

Sergey noreply at github.com
Mon Apr 15 10:49:36 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/ckan/ckan
  Commit: 5df316400b25a235a8e4b39b73aa8486d3368679
      https://github.com/ckan/ckan/commit/5df316400b25a235a8e4b39b73aa8486d3368679
  Author: Alex Harding <alexharding at rti.org>
  Date:   2019-04-08 (Mon, 08 Apr 2019)

  Changed paths:
    M ckan/logic/action/delete.py

  Log Message:
  -----------
  Retrieving the package after plugins run

In the current implementation, the package is retrieved once, but not again after the plugin hooks. If a plugin modifies a package in the IResourceController.before_delete methods, the changes made to the package will be overwritten on line 191 when the package is updated using the cached package.

This change re-retrieves the package after the plugin method has run, so that any changes made by plugins are preserved.


  Commit: 4ffbd469f6a1dd0bb7e517f444ae7b99888bc0a9
      https://github.com/ckan/ckan/commit/4ffbd469f6a1dd0bb7e517f444ae7b99888bc0a9
  Author: Sergey <tonnydexter at gmail.com>
  Date:   2019-04-15 (Mon, 15 Apr 2019)

  Changed paths:
    M ckan/logic/action/delete.py

  Log Message:
  -----------
  Merge pull request #4721 from hardingalexh/refetch-package-after-resource-delete

Retrieving the package after plugins run


Compare: https://github.com/ckan/ckan/compare/330d7475d289...4ffbd469f6a1


More information about the ckan-changes mailing list