[ckan-changes] [ckan/ckan] 01481d: [#4801] Align format of flask exceptions with Pylo...

[Adrià Mercader]

  Branch: refs/heads/py3-general-support-3
  Home:   https://github.com/ckan/ckan
  Commit: 01481d973721a9818b387d349b5f124abd536c0a
      https://github.com/ckan/ckan/commit/01481d973721a9818b387d349b5f124abd536c0a
  Author: amercader <amercadero at gmail.com>
  Date:   2019-12-19 (Thu, 19 Dec 2019)

  Changed paths:
    M ckan/config/middleware/flask_app.py
    M ckan/controllers/error.py
    M ckan/templates/error_document_template.html

  Log Message:
  -----------
  [#4801] Align format of flask exceptions with Pylons/webob ones


  Commit: 5c9e38bdabc8cdca8d8f31a79390601ef2077bd3
      https://github.com/ckan/ckan/commit/5c9e38bdabc8cdca8d8f31a79390601ef2077bd3
  Author: amercader <amercadero at gmail.com>
  Date:   2019-12-19 (Thu, 19 Dec 2019)

  Changed paths:
    R ckan/tests/legacy/functional/api/test_util.py
    R ckan/tests/legacy/functional/test_error.py

  Log Message:
  -----------
  [#4801] Remove no longer relevant legacy tests

These were not testing what was intended, and were masked by the
catch-all template controller


  Commit: 8ee21484d3ceb6c0f0d9eb8d239a3a97baf2e5ac
      https://github.com/ckan/ckan/commit/8ee21484d3ceb6c0f0d9eb8d239a3a97baf2e5ac
  Author: amercader <amercadero at gmail.com>
  Date:   2019-12-19 (Thu, 19 Dec 2019)

  Changed paths:
    M ckan/config/routing.py
    A ckan/public/robots.txt
    R ckan/templates/robots.txt

  Log Message:
  -----------
  [#4801] Serve robots.txt from the public folder (not templates)


  Commit: e4d523e06bfbe6cfd17957671f2b995e7d9d2a40
      https://github.com/ckan/ckan/commit/e4d523e06bfbe6cfd17957671f2b995e7d9d2a40
  Author: amercader <amercadero at gmail.com>
  Date:   2019-12-19 (Thu, 19 Dec 2019)

  Changed paths:
    M ckan/tests/test_none_root.py
    M ckanext/example_theme_docs/custom_config_setting/plugin.py
    M ckanext/example_theme_docs/v12_extra_public_dir/plugin.py
    M ckanext/example_theme_docs/v15_fanstatic/plugin.py
    M ckanext/example_theme_docs/v22_fanstatic_and_webassets/plugin.py

  Log Message:
  -----------
  [#4801] Update non-root test using weird URL and fix related bug in example theme plugin


  Commit: edeb59e2002640365d05d24b2fcaae47f614f2ad
      https://github.com/ckan/ckan/commit/edeb59e2002640365d05d24b2fcaae47f614f2ad
  Author: amercader <amercadero at gmail.com>
  Date:   2019-12-19 (Thu, 19 Dec 2019)

  Changed paths:
    M ckan/config/routing.py
    R ckan/controllers/template.py
    M ckan/tests/config/test_middleware.py
    R ckan/tests/controllers/test_template.py

  Log Message:
  -----------
  [#4801] Remove catch-all template controller

Pylons used to have a catch-all route defined that tried to look for the
path in the provided URL in the templates folder. With changed in the
multiple static folders introduced in f9775a1 this route is never
reached, as we now set the catch-all route to look for the path in the
public folder(s) (which makes more sense to be honest).

Modified the middleware tests to reflect this.


Compare: https://github.com/ckan/ckan/compare/6916b7a3cf20...edeb59e20026