[ckan-changes] [ckan/ckan] 8a5beb: Password reset request - generally tighten it up

Fri Feb 8 12:53:21 UTC 2019

  Branch: refs/heads/master
  Home:   https://github.com/ckan/ckan
  Commit: 8a5beb9b53d23173c8d072926a6b84f76131fcd8
      https://github.com/ckan/ckan/commit/8a5beb9b53d23173c8d072926a6b84f76131fcd8
  Author: David Read <david.read at hackneyworkshop.com>
  Date:   2019-02-08 (Fri, 08 Feb 2019)

  Changed paths:
    M ckan/logic/action/get.py
    M ckan/logic/auth/get.py
    M ckan/templates/user/request_reset.html
    M ckan/tests/controllers/test_user.py
    M ckan/tests/logic/action/test_get.py
    M ckan/tests/logic/auth/test_get.py
    M ckan/views/user.py

  Log Message:
  -----------
  Password reset request - generally tighten it up

* Can only specify name or email not - not the looser search done by model.User.search()
  which allowed: partial name, partial fullname (and if sysadmin: partial emails) etc
  (This was originally loose to be helpful, but the balance with security changed)
* Don't confirm whether a user exists or not
* Logging for audit purposes


  Commit: 1197cfa798f1460007eb258a644fd4c10fe4ee13
      https://github.com/ckan/ckan/commit/1197cfa798f1460007eb258a644fd4c10fe4ee13
  Author: Edward Robinson <proteenx11 at gmail.com>
  Date:   2019-02-08 (Fri, 08 Feb 2019)

  Changed paths:
    M ckan/views/user.py

  Log Message:
  -----------
  fix internal server error being shown instead of flash message


  Commit: dad061b25607676d4df7e108396cf7662f7795df
      https://github.com/ckan/ckan/commit/dad061b25607676d4df7e108396cf7662f7795df
  Author: Edward Robinson <proteenx11 at gmail.com>
  Date:   2019-02-08 (Fri, 08 Feb 2019)

  Changed paths:
    M ckan/views/user.py

  Log Message:
  -----------
  fix change no email warning to flash message


  Commit: 25b4d329b7b62caf3b55e4d54731691e030d01b3
      https://github.com/ckan/ckan/commit/25b4d329b7b62caf3b55e4d54731691e030d01b3
  Author: Edward Robinson <proteenx11 at gmail.com>
  Date:   2019-02-08 (Fri, 08 Feb 2019)

  Changed paths:
    M ckan/views/user.py

  Log Message:
  -----------
  add why @ check works for username/email


  Commit: c4707dc8c39f22ce4dd1cf3c33c18df91d3bacb2
      https://github.com/ckan/ckan/commit/c4707dc8c39f22ce4dd1cf3c33c18df91d3bacb2
  Author: Edward Robinson <proteenx11 at gmail.com>
  Date:   2019-02-08 (Fri, 08 Feb 2019)

  Changed paths:
    M ckan/tests/controllers/test_user.py

  Log Message:
  -----------
  update test


  Commit: 607844151f2a71f96a9ba89a00b6539298b142ef
      https://github.com/ckan/ckan/commit/607844151f2a71f96a9ba89a00b6539298b142ef
  Author: David Read <david.read at hackneyworkshop.com>
  Date:   2019-02-08 (Fri, 08 Feb 2019)

  Changed paths:
    M ckan/tests/controllers/test_user.py

  Log Message:
  -----------
  Add a test for mailer not being configured


  Commit: 3f34dd4cdf5bea978a95261c3abd65203e1d4784
      https://github.com/ckan/ckan/commit/3f34dd4cdf5bea978a95261c3abd65203e1d4784
  Author: Adrià Mercader <amercadero at gmail.com>
  Date:   2019-02-08 (Fri, 08 Feb 2019)

  Changed paths:
    M ckan/logic/action/get.py
    M ckan/logic/auth/get.py
    M ckan/templates/user/request_reset.html
    M ckan/tests/controllers/test_user.py
    M ckan/tests/logic/action/test_get.py
    M ckan/tests/logic/auth/test_get.py
    M ckan/views/user.py

  Log Message:
  -----------
  Merge pull request #4636 from ckan/security_dont_confirm_if_user_exists_2

Password reset request - generally tighten it up


Compare: https://github.com/ckan/ckan/compare/689c48872615...3f34dd4cdf5b