[ckan-changes] [ckan/ckan] 9fcc0d: [#3994] Pass a timeout through to the rq.Job objec...

GitHub noreply at github.com
Fri Jan 18 12:19:41 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/ckan/ckan
  Commit: 9fcc0db9ace9887ee59013f191e5e5b5bc17722f
      https://github.com/ckan/ckan/commit/9fcc0db9ace9887ee59013f191e5e5b5bc17722f
  Author: Scott Dillon <scott.dillon at gmail.com>
  Date:   2018-12-21 (Fri, 21 Dec 2018)

  Changed paths:
    M ckan/lib/jobs.py

  Log Message:
  -----------
  [#3994] Pass a timeout through to the rq.Job object.

Pass the job timeout kwarg through to the `rq.queue.enqueue_call` method.

Get the default job timeout from the ckan config.


  Commit: a0cfa22b52e1d232df926952ba508da3ad398734
      https://github.com/ckan/ckan/commit/a0cfa22b52e1d232df926952ba508da3ad398734
  Author: Scott Dillon <scott.dillon at gmail.com>
  Date:   2018-12-21 (Fri, 21 Dec 2018)

  Changed paths:
    M ckan/config/deployment.ini_tmpl

  Log Message:
  -----------
  [#3994] Add default backound job timeout to deployment.ini template.


  Commit: 5d8935fa5c076087c20b0ed9b1fcb999e1b23d9a
      https://github.com/ckan/ckan/commit/5d8935fa5c076087c20b0ed9b1fcb999e1b23d9a
  Author: Scott Dillon <scott.dillon at gmail.com>
  Date:   2018-12-21 (Fri, 21 Dec 2018)

  Changed paths:
    M ckan/tests/lib/test_jobs.py

  Log Message:
  -----------
  [#3994] Test for accurate timeout values in the rq Job.

Test that a timeout was passed to the rq Job objects when called from `ckan.lib.jobs.py`. Test if timeout is not passed and values of 0, -1 and 3600 are passed correctly.


  Commit: 907c60dca8c196e4d025b6772110ffb9e80f5686
      https://github.com/ckan/ckan/commit/907c60dca8c196e4d025b6772110ffb9e80f5686
  Author: Scott Dillon <scott.dillon at gmail.com>
  Date:   2018-12-21 (Fri, 21 Dec 2018)

  Changed paths:
    M doc/maintaining/background-tasks.rst

  Log Message:
  -----------
  [#3994] Background job timeout documentation

Detail how to add a custom timeout to a background job and the location of default value in the ckan config file.


  Commit: f3f841f84a3417259fa14610e8e32e4dea3fb6c0
      https://github.com/ckan/ckan/commit/f3f841f84a3417259fa14610e8e32e4dea3fb6c0
  Author: Scott Dillon <scott.dillon at gmail.com>
  Date:   2018-12-21 (Fri, 21 Dec 2018)

  Changed paths:
    M test-core-circle-ci.ini

  Log Message:
  -----------
  [#3994] Add job timeout to circle CI settings file.


  Commit: 5b83e01fd8d9a6220fefe1a434370b8f206d998a
      https://github.com/ckan/ckan/commit/5b83e01fd8d9a6220fefe1a434370b8f206d998a
  Author: Scott Dillon <scott.dillon at gmail.com>
  Date:   2018-12-21 (Fri, 21 Dec 2018)

  Changed paths:
    M ckan/config/deployment.ini_tmpl
    M test-core-circle-ci.ini

  Log Message:
  -----------
  [#3994] Move timeout setting under the `[app:main]` header in ini file.


  Commit: 76d97865a6150d5714c5b0e387e23ff090cbe16f
      https://github.com/ckan/ckan/commit/76d97865a6150d5714c5b0e387e23ff090cbe16f
  Author: Scott Dillon <scott.dillon at gmail.com>
  Date:   2018-12-21 (Fri, 21 Dec 2018)

  Changed paths:
    M test-core-circle-ci.ini
    M test-core.ini

  Log Message:
  -----------
  [#3994] Move backgroud job timeout to `test-core.ini`


  Commit: dc7532d6ecd6c27de188a638c9e3aec3ec8d96f9
      https://github.com/ckan/ckan/commit/dc7532d6ecd6c27de188a638c9e3aec3ec8d96f9
  Author: Scott Dillon <scott.dillon at gmail.com>
  Date:   2019-01-08 (Tue, 08 Jan 2019)

  Changed paths:
    M ckan/lib/jobs.py

  Log Message:
  -----------
  [#3994] Perform a  lookup in config dict to get a default value.


  Commit: 28d78d3cc912e6d38e9505eabb753c01dfdfa5b4
      https://github.com/ckan/ckan/commit/28d78d3cc912e6d38e9505eabb753c01dfdfa5b4
  Author: Scott Dillon <scott.dillon at gmail.com>
  Date:   2019-01-08 (Tue, 08 Jan 2019)

  Changed paths:
    M ckan/lib/jobs.py

  Log Message:
  -----------
  [#3994] Fix bracket error.


  Commit: 897082f04eed02e39d756c5c1b62ef149808b3e4
      https://github.com/ckan/ckan/commit/897082f04eed02e39d756c5c1b62ef149808b3e4
  Author: Scott Dillon <scott.dillon at gmail.com>
  Date:   2019-01-08 (Tue, 08 Jan 2019)

  Changed paths:
    M ckan/tests/lib/test_jobs.py

  Log Message:
  -----------
  [#3994] Change timeout access to attribute from meta dict lookup.


  Commit: b81155230dbca991c87d2c21f62357803441c0fb
      https://github.com/ckan/ckan/commit/b81155230dbca991c87d2c21f62357803441c0fb
  Author: Scott Dillon <scott.dillon at gmail.com>
  Date:   2019-01-08 (Tue, 08 Jan 2019)

  Changed paths:
    M ckan/tests/lib/test_jobs.py

  Log Message:
  -----------
  [#3994] Fix test reference value when setting timeout to -1. redis queue sets the timeout to the default instead of using no timeout.


  Commit: 2ed66c47ebb786e66e94a5d551957f0b8bb3699e
      https://github.com/ckan/ckan/commit/2ed66c47ebb786e66e94a5d551957f0b8bb3699e
  Author: Scott Dillon <scott.dillon at gmail.com>
  Date:   2019-01-08 (Tue, 08 Jan 2019)

  Changed paths:
    M ckan/lib/jobs.py

  Log Message:
  -----------
  [#3994] Pass the timeout to the  function instead of None


  Commit: abef638041acdc880f0ec45bcbe95de6eb80e311
      https://github.com/ckan/ckan/commit/abef638041acdc880f0ec45bcbe95de6eb80e311
  Author: Scott Dillon <scott.dillon at gmail.com>
  Date:   2019-01-08 (Tue, 08 Jan 2019)

  Changed paths:
    M ckan/tests/lib/test_jobs.py

  Log Message:
  -----------
  [#3994] Fix the test reference value since it does support -1 as a timeout value.


  Commit: 85ee64bddae5c13921cf83e0a5d4dec7e862296c
      https://github.com/ckan/ckan/commit/85ee64bddae5c13921cf83e0a5d4dec7e862296c
  Author: Scott Dillon <scott.dillon at gmail.com>
  Date:   2019-01-15 (Tue, 15 Jan 2019)

  Changed paths:
    M ckan/config/deployment.ini_tmpl
    M ckan/lib/jobs.py
    M doc/maintaining/background-tasks.rst
    M test-core.ini

  Log Message:
  -----------
  Change references to config  variable to be implementation agnostic.


  Commit: 6382d1ec158c6724270e67a6aaf7f51edf56725e
      https://github.com/ckan/ckan/commit/6382d1ec158c6724270e67a6aaf7f51edf56725e
  Author: Scott Dillon <scott.dillon at gmail.com>
  Date:   2019-01-17 (Thu, 17 Jan 2019)

  Changed paths:
    M ckan/config/deployment.ini_tmpl
    M ckan/lib/jobs.py
    M doc/maintaining/background-tasks.rst
    M test-core.ini

  Log Message:
  -----------
  [#3994] Scope the background job timeout to ckan.


  Commit: 5d7a4985f283b1d424c4a1ce3252eedb35f76e83
      https://github.com/ckan/ckan/commit/5d7a4985f283b1d424c4a1ce3252eedb35f76e83
  Author: Adrià Mercader <amercadero at gmail.com>
  Date:   2019-01-18 (Fri, 18 Jan 2019)

  Changed paths:
    M ckan/config/deployment.ini_tmpl
    M ckan/lib/jobs.py
    M ckan/tests/lib/test_jobs.py
    M doc/maintaining/background-tasks.rst
    M test-core.ini

  Log Message:
  -----------
  Merge pull request #4601 from scottdillon/3994-fix-background-job-timeout

3994 fix background job timeout


Compare: https://github.com/ckan/ckan/compare/a342792b97d9...5d7a4985f283
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the ckan-changes mailing list