[ckan-changes] [ckan/ckan] b7a0be: Check ValueError in url_validator

Thu Jan 24 13:06:05 UTC 2019

  Branch: refs/heads/master
  Home:   https://github.com/ckan/ckan
  Commit: b7a0be8b6b07e0dff6db70afb7a51ef2241a5608
      https://github.com/ckan/ckan/commit/b7a0be8b6b07e0dff6db70afb7a51ef2241a5608
  Author: Stefan Oderbolz <stefan.oderbolz at liip.ch>
  Date:   2019-01-23 (Wed, 23 Jan 2019)

  Changed paths:
    M ckan/logic/validators.py
    M ckan/tests/logic/test_validators.py

  Log Message:
  -----------
  Check ValueError in url_validator

If an invalid URL is provided to urlparse (e.g. `https://example.com]`)
it might raise a ValueError. This breaks the url_validator.
This PR aims to fix that and simply add the error msg if a ValueError
occurs.

  Commit: 7d1c9ce5605e04ac37aee9f4b37a570298c6659f
      https://github.com/ckan/ckan/commit/7d1c9ce5605e04ac37aee9f4b37a570298c6659f
  Author: Stefan Oderbolz <stefan.oderbolz at liip.ch>
  Date:   2019-01-23 (Wed, 23 Jan 2019)

  Changed paths:
    M ckan/logic/validators.py

  Log Message:
  -----------
  Remove unneeded variables

  Commit: b42769976b0fdf665ebdf22395c6ee2323fb0e11
      https://github.com/ckan/ckan/commit/b42769976b0fdf665ebdf22395c6ee2323fb0e11
  Author: Adrià Mercader <amercadero at gmail.com>
  Date:   2019-01-24 (Thu, 24 Jan 2019)

  Changed paths:
    M ckan/logic/validators.py
    M ckan/tests/logic/test_validators.py

  Log Message:
  -----------
  Merge pull request #4630 from opendatazurich/url-validator

Check ValueError in url_validator

Compare: https://github.com/ckan/ckan/compare/ec4a6f1ae2a2...b42769976b0f
      **NOTE:** GitHub Services has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      We will provide an alternative path for the email notifications by January 31st, 2019.