[ckan-changes] [ckan/ckan] e5848c: [#4872] Remove _external query param on Pylons gen...

Thu Jun 27 13:10:48 UTC 2019

  Branch: refs/heads/master
  Home:   https://github.com/ckan/ckan
  Commit: e5848c2f68d58075d898f584565ca2e49a13f762
      https://github.com/ckan/ckan/commit/e5848c2f68d58075d898f584565ca2e49a13f762
  Author: amercader <amercadero at gmail.com>
  Date:   2019-06-26 (Wed, 26 Jun 2019)

  Changed paths:
    M ckan/lib/helpers.py
    M ckan/tests/lib/test_helpers.py

  Log Message:
  -----------
  [#4872] Remove _external query param on Pylons generated URLs

Fixes #4872

The url_for wrapper for Pylons requests correctly handles Flask's
`_external` parameter to generate fully qualified URLs, but fails
to remove it, resulting in an extraneous param added to the URL,
 eg: http://example.com/dataset/test?_external=True


  Commit: 6e4a0b9083b40759a7733e841dd609b3a52203ab
      https://github.com/ckan/ckan/commit/6e4a0b9083b40759a7733e841dd609b3a52203ab
  Author: amercader <amercadero at gmail.com>
  Date:   2019-06-27 (Thu, 27 Jun 2019)

  Changed paths:
    M ckan/tests/lib/test_helpers.py

  Log Message:
  -----------
  [#4872] [#4872] Pep8


  Commit: 7256b2949751b5bae31a63d9f5ba4389575b621e
      https://github.com/ckan/ckan/commit/7256b2949751b5bae31a63d9f5ba4389575b621e
  Author: Sergey <tonnydexter at gmail.com>
  Date:   2019-06-27 (Thu, 27 Jun 2019)

  Changed paths:
    M ckan/lib/helpers.py
    M ckan/tests/lib/test_helpers.py

  Log Message:
  -----------
  Merge pull request #4873 from ckan/4872-remove-extra-external-parameter

[#4872] Remove _external query param on Pylons generated URLs


Compare: https://github.com/ckan/ckan/compare/f3f7e97a1470...7256b2949751