[ckan-changes] [ckan/ckan] 31202a: [#4747] Pin pastescript to avoid requirements conf...

Thu May 9 13:39:05 UTC 2019

  Branch: refs/heads/master
  Home:   https://github.com/ckan/ckan
  Commit: 31202ac967b750204409fd7fe66648a77d553023
      https://github.com/ckan/ckan/commit/31202ac967b750204409fd7fe66648a77d553023
  Author: amercader <amercadero at gmail.com>
  Date:   2019-04-26 (Fri, 26 Apr 2019)

  Changed paths:
    M requirements.in
    M requirements.txt

  Log Message:
  -----------
  [#4747] Pin pastescript to avoid requirements conflict

Latest versions require Paste>=3.0 which is not compatible with our
pinned version. The upgrade in PasteDeploy should be all right as there
are only changes in documentation between the two versions AFAICT

  Commit: e26895608412d19d83f1522a72983433417ff96e
      https://github.com/ckan/ckan/commit/e26895608412d19d83f1522a72983433417ff96e
  Author: amercader <amercadero at gmail.com>
  Date:   2019-04-26 (Fri, 26 Apr 2019)

  Changed paths:
    M requirements.txt

  Log Message:
  -----------
  Upgrade requirements

These all look fine. The major change I see is redis but as rq is the
only one using it and it comes from them I assume everything will work
fine.

  Commit: 4de1ad8cdcd303e437d14008005d83df680609fd
      https://github.com/ckan/ckan/commit/4de1ad8cdcd303e437d14008005d83df680609fd
  Author: amercader <amercadero at gmail.com>
  Date:   2019-04-29 (Mon, 29 Apr 2019)

  Changed paths:
    M requirements.in
    M requirements.txt

  Log Message:
  -----------
  [#4747] Pin Werkzeug

After upgrading Werkzeug to 0.15.2 we got the following failures:

        AssertionError: Environmental variable PATH_INFO is not a
        string: <type 'unicode'> (value: u'/ckan-admin/reset_config')

This is webtest complaining that the test request environ used in some
functional tests has a unicode value for environ['PATH_INFO']. Modern
versions of WebTest ensure that the url passed is a string, but sadly
the version we are stuck with only does so for GET requests (We are
stuck with this version of WebTest because newer versions have a higher
WebOb requirement which conflicts with our Pylons requirement).

We could ensure on our side that the urls provided to webtest are
strings but that would involve either

1. Change all app.post() calls in tests to app.post(str(url))
2. Change url_for itself to always return a sting, which obviously is
not a great solution.

Having Werkzeug pinned is not ideal though so we either find a
workaround or speed Pylons removal (allowing us to upgrade
webob/webtest)

  Commit: b7ebf541129697aeef3765e0f52249eac77cd9bb
      https://github.com/ckan/ckan/commit/b7ebf541129697aeef3765e0f52249eac77cd9bb
  Author: amercader <amercadero at gmail.com>
  Date:   2019-04-30 (Tue, 30 Apr 2019)

  Changed paths:
    M requirements.in
    M requirements.txt

  Log Message:
  -----------
  [#4747] Upgrade RQ

Upgrading redis to 3.x caused errors because of an old RQ version.
Rather than pinning an old version of redis, upgrade RQ. I went through
the list of backwards incompatible changes and didn't see anything
relevant (There's mention of renaming the `timeout` to `job_timeout`
parameter but that's on `enqueue`, and we use `enqueu_call`)

  Commit: bcf1271470ec57833eac92fe843a5a5141529833
      https://github.com/ckan/ckan/commit/bcf1271470ec57833eac92fe843a5a5141529833
  Author: Sergey <tonnydexter at gmail.com>
  Date:   2019-05-09 (Thu, 09 May 2019)

  Changed paths:
    M requirements.in
    M requirements.txt

  Log Message:
  -----------
  Merge pull request #4749 from ckan/4747-fix-paste-req

Update requirements, fix paste requirements

Compare: https://github.com/ckan/ckan/compare/5f2814e4df00...bcf1271470ec